From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [PATCH] KVM: x86: Avoid busy loops over uninjectable pending APIC timers Date: Sun, 17 Mar 2013 11:45:34 +0100 Message-ID: <51459ECE.2000107@web.de> References: <5144DAC3.7080401@web.de> <20130317084705.GC11223@redhat.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="----enig2TSANSIIWRWIGSNUJINTB" Cc: Marcelo Tosatti , kvm To: Gleb Natapov Return-path: Received: from mout.web.de ([212.227.17.11]:64545 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752227Ab3CQKpn (ORCPT ); Sun, 17 Mar 2013 06:45:43 -0400 In-Reply-To: <20130317084705.GC11223@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2TSANSIIWRWIGSNUJINTB Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 2013-03-17 09:47, Gleb Natapov wrote: > On Sat, Mar 16, 2013 at 09:49:07PM +0100, Jan Kiszka wrote: >> From: Jan Kiszka >> >> If the guest didn't take the last APIC timer interrupt yet and generat= es >> another one on top, e.g. via periodic mode, we do not block the VCPU >> even if the guest state is halted. The reason is that >> apic_has_pending_timer continues to return a non-zero value. >> >> Fix this busy loop by taking the IRR content for the LVT vector in >> apic_has_pending_timer into account. >> > Just drop coalescing tacking for lapic interrupt. After posted interrup= t > will be merged __apic_accept_irq() will not longer return coalescing > information, so the code will be dead anyway. That requires the RTC decoalescing series to go first to avoid a regression, no? Then let's postpone this topic for now. Jan ------enig2TSANSIIWRWIGSNUJINTB Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iEYEARECAAYFAlFFntIACgkQitSsb3rl5xTg7ACgicEK+wuqACqRrO9bzYfgw+9p JZ8AnifFpUdbA69MKdDgm/50nYBca5uX =G7xW -----END PGP SIGNATURE----- ------enig2TSANSIIWRWIGSNUJINTB--