From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:39412)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <minovotn@redhat.com>) id 1UHwWK-00065Z-FC
	for qemu-devel@nongnu.org; Tue, 19 Mar 2013 09:24:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <minovotn@redhat.com>) id 1UHwWF-0007JY-J3
	for qemu-devel@nongnu.org; Tue, 19 Mar 2013 09:24:04 -0400
Received: from mx1.redhat.com ([209.132.183.28]:57420)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <minovotn@redhat.com>) id 1UHwWF-0007JG-BA
	for qemu-devel@nongnu.org; Tue, 19 Mar 2013 09:23:59 -0400
Received: from int-mx02.intmail.prod.int.phx2.redhat.com
	(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r2JDNwh4022236
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Tue, 19 Mar 2013 09:23:58 -0400
Message-ID: <51486156.7020906@redhat.com>
Date: Tue, 19 Mar 2013 14:00:06 +0100
From: Michal Novotny <minovotn@redhat.com>
MIME-Version: 1.0
References: <e3a6017620c95128121a9748d7a81faf526a08f5.1363104087.git.minovotn@redhat.com>
	<87k3p3bmld.fsf@blackfin.pond.sub.org>
In-Reply-To: <87k3p3bmld.fsf@blackfin.pond.sub.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] Introduce query-cpu-max QMP command and
 cpu_max HMP counterpart
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org, Luiz Capitulino <lcapitulino@redhat.com>


On 03/19/2013 01:28 PM, Markus Armbruster wrote:
> Please cc: Luiz and me on QMP work in the future.
>
> Michal Novotny <minovotn@redhat.com> writes:
>
>> This is the patch to introduce the query-cpu-max QMP command to get
>> the maximum number of CPUs supported by the currently running emulator
>> instance. This may differ machine from machine as defined by -machine
>> settings and max_cpus member of QEMUMachine structure.
> Humor me: don't start commit message bodies with "This patch" or
> variations thereof, and don't repeat the subject.  Suggest:
>
> QMP command query-cpu-max returns the maximum number of CPUs supported
> by the currently running emulator instance, as defined in its
> QEMUMachine struct.
>
>> It's been tested both using QMP/qmp utility and telnet session on
>> the QEMU session.
> What's a QMP/qmp utility?  Let's drop this sentence.  In the future,
> feel free to put testing info below the "---" line.


I meant the utility located in <qemu-dir-clone>/QMP/qmp which is
essentially the python script for QMP testing.


>
>> The HMP counterpart called cpu_max has been introduced by this patch
>> too.
> Grammar nit: s/has been/is/.  Even better, avoid passive voice.
>
> Hmm, I just rewrote most of your commit message, so why not rewrite all
> of it:
>
>     New QMP command query-cpu-max and HMP command cpu_max
>
>     These commands return the maximum number of CPUs supported by the
>     currently running emulator instance, as defined in its QEMUMachine
>     struct.
>
> Perhaps Luiz can fix up the commit message commit, if you don't mind.
>
> Patch looks good.

The commit log change is fine with me. Thanks for your feedback!

Michal

> Should query commands for machine properties multiply, we should
> consider creating a single command returning all of them.  I'm not
> asking you to do that now.
>
> Reviewed-by: Markus Armbruster <armbru@redhat.com>

-- 
Michal Novotny <minovotn@redhat.com>, RHCE, Red Hat
Virtualization | libvirt-php bindings | php-virt-control.org