From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:40322) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UHwZi-000844-Lm for qemu-devel@nongnu.org; Tue, 19 Mar 2013 09:27:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UHwZd-0000Od-OA for qemu-devel@nongnu.org; Tue, 19 Mar 2013 09:27:34 -0400 Received: from cantor2.suse.de ([195.135.220.15]:38384 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UHwZd-0000OY-EK for qemu-devel@nongnu.org; Tue, 19 Mar 2013 09:27:29 -0400 Message-ID: <514867BF.1030009@suse.de> Date: Tue, 19 Mar 2013 14:27:27 +0100 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <87k3p3bmld.fsf@blackfin.pond.sub.org> In-Reply-To: <87k3p3bmld.fsf@blackfin.pond.sub.org> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] Introduce query-cpu-max QMP command and cpu_max HMP counterpart List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , Michal Novotny Cc: Igor Mammedov , qemu-devel@nongnu.org, Eduardo Habkost , Luiz Capitulino Am 19.03.2013 13:28, schrieb Markus Armbruster: > Please cc: Luiz and me on QMP work in the future. >=20 > Michal Novotny writes: >=20 >> This is the patch to introduce the query-cpu-max QMP command to get >> the maximum number of CPUs supported by the currently running emulator >> instance. This may differ machine from machine as defined by -machine >> settings and max_cpus member of QEMUMachine structure. >=20 > Humor me: don't start commit message bodies with "This patch" or > variations thereof, and don't repeat the subject. Suggest: >=20 > QMP command query-cpu-max returns the maximum number of CPUs supported > by the currently running emulator instance, as defined in its > QEMUMachine struct. >=20 >> It's been tested both using QMP/qmp utility and telnet session on >> the QEMU session. >=20 > What's a QMP/qmp utility? Our ./QMP/qmp script, I guess. > Let's drop this sentence. In the future, > feel free to put testing info below the "---" line. >=20 >> The HMP counterpart called cpu_max has been introduced by this patch >> too. >=20 > Grammar nit: s/has been/is/. Even better, avoid passive voice. >=20 > Hmm, I just rewrote most of your commit message, so why not rewrite all > of it: >=20 > New QMP command query-cpu-max and HMP command cpu_max >=20 > These commands return the maximum number of CPUs supported by the > currently running emulator instance, as defined in its QEMUMachine > struct. >=20 > Perhaps Luiz can fix up the commit message commit, if you don't mind. >=20 > Patch looks good. >=20 > Should query commands for machine properties multiply, we should > consider creating a single command returning all of them. I'm not > asking you to do that now. >=20 > Reviewed-by: Markus Armbruster >>From my CPU perspective I am wondering if this info has future as-is? IIUC this QEMUMachine value differs from the value exposed to SeaBIOS/KVM already since recently, as it ignores CPU topology. I'm guessing the libvirt use case is just to detect users specifying too many -cpu options, so I won't veto this, but want to caution that we may need to change this as we proceed with CPU remodelling. Regards, Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg