From: "Jan Beulich" <JBeulich@suse.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: xen-devel@lists.xen.org, linux-kernel@vger.kernel.org,
Roger Pau Monne <roger.pau@citrix.com>
Subject: Re: [PATCH 1/5] xen-blkback: don't store dev_bus_addr
Date: Tue, 19 Mar 2013 15:24:08 +0000 [thread overview]
Message-ID: <5148912802000078000C6CC4__2143.9871321947$1363706767$gmane$org@nat28.tlf.novell.com> (raw)
In-Reply-To: <20130319151000.GA8550@phenom.dumpdata.com>
>>> On 19.03.13 at 16:10, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> wrote:
> On Tue, Mar 19, 2013 at 02:55:56PM +0000, Jan Beulich wrote:
>> >>> On 19.03.13 at 15:32, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> wrote:
>> > @@ -971,7 +962,7 @@ static int dispatch_rw_block_io(struct xen_blkif *blkif,
>> > (bio_add_page(bio,
>> > pages[i],
>> > seg[i].nsec << 9,
>> > - seg[i].buf & ~PAGE_MASK) == 0)) {
>> > + seg[i].offset & ~PAGE_MASK) == 0)) {
>>
>> ... this one could as well use the original field.
>>
>> And the masking with ~PAGE_MASK is not pointless in any case.
>
> Good point. In which might as well make the 'struct seg_buf' be an
> simple array of unsigned int.
Looks like you understood that the "not" in my earlier response
was meant to be "now".
Jan
next prev parent reply other threads:[~2013-03-19 15:24 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-18 16:49 [PATCH 0/5] xen-block: cleanup and fixes Roger Pau Monne
2013-03-18 16:49 ` [PATCH 1/5] xen-blkback: don't store dev_bus_addr Roger Pau Monne
2013-03-19 14:32 ` Konrad Rzeszutek Wilk
2013-03-19 14:32 ` Konrad Rzeszutek Wilk
2013-03-19 14:55 ` Jan Beulich
2013-03-19 14:55 ` [Xen-devel] " Jan Beulich
2013-03-19 15:10 ` Konrad Rzeszutek Wilk
2013-03-19 15:24 ` Jan Beulich [this message]
2013-03-19 15:24 ` Jan Beulich
2013-03-19 15:26 ` Roger Pau Monné
2013-03-19 16:56 ` Konrad Rzeszutek Wilk
2013-03-19 16:56 ` [Xen-devel] " Konrad Rzeszutek Wilk
2013-03-19 15:26 ` Roger Pau Monné
2013-03-19 15:10 ` Konrad Rzeszutek Wilk
2013-03-18 16:49 ` Roger Pau Monne
2013-03-18 16:49 ` [PATCH 2/5] xen-blkback: fix foreach_grant_safe to handle empty lists Roger Pau Monne
2013-03-18 16:49 ` Roger Pau Monne
2013-03-18 16:49 ` [PATCH 3/5] xen-blkfront: switch from llist to list Roger Pau Monne
2013-03-18 16:49 ` Roger Pau Monne
2013-03-19 12:51 ` Konrad Rzeszutek Wilk
2013-03-19 12:51 ` Konrad Rzeszutek Wilk
2013-03-19 12:57 ` Roger Pau Monné
2013-03-19 12:57 ` Roger Pau Monné
2013-03-19 14:31 ` Konrad Rzeszutek Wilk
2013-03-19 14:31 ` Konrad Rzeszutek Wilk
2013-03-18 16:49 ` [PATCH 4/5] xen-blkfront: pre-allocate pages for requests Roger Pau Monne
2013-03-18 16:49 ` Roger Pau Monne
2013-03-18 16:49 ` [PATCH 5/5] xen-blkfront: remove frame list from blk_shadow Roger Pau Monne
2013-03-18 16:49 ` Roger Pau Monne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='5148912802000078000C6CC4__2143.9871321947$1363706767$gmane$org@nat28.tlf.novell.com' \
--to=jbeulich@suse.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.