From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCH 6/7] usb: phy: tegra: Add error handling & clean up. Date: Tue, 19 Mar 2013 14:10:07 -0600 Message-ID: <5148C61F.9060708@wwwdotorg.org> References: <1363609781-4045-1-git-send-email-vbyravarasu@nvidia.com> <1363609781-4045-7-git-send-email-vbyravarasu@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1363609781-4045-7-git-send-email-vbyravarasu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Venu Byravarasu Cc: gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, balbi-l0cyMroinI0@public.gmane.org, stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-tegra@vger.kernel.org On 03/18/2013 06:29 AM, Venu Byravarasu wrote: > Check return values from all GPIO APIs and handle errors accordingly. > Remove clk_disable_unprepare which is no more needed. The call to clk_disable_unprepare is incorrect in the current code. The way you worded that, it sounds like it's no longer needed because of the changes made in this patch. I would re-write that last sentence as: Remove the call to clk_disable_unprepare(); this function does not prepare or enable the clock, so the error path should not disable or unprepare it. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757618Ab3CSUK2 (ORCPT ); Tue, 19 Mar 2013 16:10:28 -0400 Received: from avon.wwwdotorg.org ([70.85.31.133]:46993 "EHLO avon.wwwdotorg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754880Ab3CSUKL (ORCPT ); Tue, 19 Mar 2013 16:10:11 -0400 Message-ID: <5148C61F.9060708@wwwdotorg.org> Date: Tue, 19 Mar 2013 14:10:07 -0600 From: Stephen Warren User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130106 Thunderbird/17.0.2 MIME-Version: 1.0 To: Venu Byravarasu CC: gregkh@linuxfoundation.org, stern@rowland.harvard.edu, balbi@ti.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, devicetree-discuss@lists.ozlabs.org Subject: Re: [PATCH 6/7] usb: phy: tegra: Add error handling & clean up. References: <1363609781-4045-1-git-send-email-vbyravarasu@nvidia.com> <1363609781-4045-7-git-send-email-vbyravarasu@nvidia.com> In-Reply-To: <1363609781-4045-7-git-send-email-vbyravarasu@nvidia.com> X-Enigmail-Version: 1.4.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/18/2013 06:29 AM, Venu Byravarasu wrote: > Check return values from all GPIO APIs and handle errors accordingly. > Remove clk_disable_unprepare which is no more needed. The call to clk_disable_unprepare is incorrect in the current code. The way you worded that, it sounds like it's no longer needed because of the changes made in this patch. I would re-write that last sentence as: Remove the call to clk_disable_unprepare(); this function does not prepare or enable the clock, so the error path should not disable or unprepare it.