From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:38342) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UI3a2-0005KM-MH for qemu-devel@nongnu.org; Tue, 19 Mar 2013 16:56:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UI3Zx-0006ae-OP for qemu-devel@nongnu.org; Tue, 19 Mar 2013 16:56:22 -0400 Received: from mx1.redhat.com ([209.132.183.28]:62631) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UI3Zx-0006a7-Fh for qemu-devel@nongnu.org; Tue, 19 Mar 2013 16:56:17 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r2JKuFNr028469 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 19 Mar 2013 16:56:16 -0400 Message-ID: <5148D0EE.5000209@redhat.com> Date: Tue, 19 Mar 2013 14:56:14 -0600 From: Eric Blake MIME-Version: 1.0 References: <1363627441-8297-1-git-send-email-kwolf@redhat.com> <1363627441-8297-5-git-send-email-kwolf@redhat.com> In-Reply-To: <1363627441-8297-5-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2VCOCHOMFNFWHLGLWCSJF" Subject: Re: [Qemu-devel] [PATCH 04/11] nbd: Keep hostname and port separate List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: pbonzini@redhat.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2VCOCHOMFNFWHLGLWCSJF Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 03/18/2013 11:23 AM, Kevin Wolf wrote: > The NBD block supports an URL syntax, for which a URL parser returns > separate hostname and port fields. It also supports the traditional qem= u > syntax encoded in a filename. Until now, after parsing the URL to get > each piece of information, a new string is built to be fed to socket > functions. >=20 > Instead of building a string in the URL case that is immediately parsed= > again, parse the string in both cases and use the QemuOpts interface to= > qemu-sockets.c. >=20 > Signed-off-by: Kevin Wolf > --- > block/nbd.c | 49 ++++++++++++++++++++++++++++++++++++++++--= ------- > include/block/nbd.h | 2 ++ > include/qemu/sockets.h | 1 + > nbd.c | 12 ++++++++++++ > util/qemu-sockets.c | 6 +++--- > 5 files changed, 58 insertions(+), 12 deletions(-) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2VCOCHOMFNFWHLGLWCSJF Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRSNDuAAoJEKeha0olJ0NqVh8H/ApfDAnuJkcgsSXldG80oTKg zmXORPn8m7mxE76GRAc9yiscUqWnzcyOravGn8zu5NrwAjRQxnbBMw6qDMnlBnZU +4sLIJVaAxtKXs9B3FbigrzW4UFrzd0JUfhh7yE01aamiMdx8MpJmyYx6jJ5fb6Z wbjcv6uorjwTjoqwfaEAhlnhC6kjhGoFVN1IBX0JuiqaphA/VX6YC4cuJJP17nW7 R71NDWNcZTMIHKQwNSwLgM1pE+e2IW4nG/fDCi4LtHenI5G4XhLgrBffhx8npmL/ 660V+SgC5Qc44RAlsH/rKBCyzvFnctXrjv8UzIDsGJ0+8Ak2uz5ce6qwSWFtvlE= =7rnF -----END PGP SIGNATURE----- ------enig2VCOCHOMFNFWHLGLWCSJF--