Re: [Qemu-devel] [PATCH 09/11] block: Make find_image_format safe with NULL filename

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1001 bytes --]

On 03/18/2013 11:23 AM, Kevin Wolf wrote:
> In order to achieve this, the .bdrv_probe callbacks of all drivers must
> cope with this. The DMG driver is the only one that bases its decision
> on the filename and it needs to be changed.
> 
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
>  block/dmg.c | 13 ++++++++++---
>  1 file changed, 10 insertions(+), 3 deletions(-)

Reviewed-by: Eric Blake <eblake@redhat.com>

> 
> diff --git a/block/dmg.c b/block/dmg.c
> index c1066df..3141cb5 100644
> --- a/block/dmg.c
> +++ b/block/dmg.c
> @@ -51,9 +51,16 @@ typedef struct BDRVDMGState {
>  
>  static int dmg_probe(const uint8_t *buf, int buf_size, const char *filename)
>  {
> -    int len=strlen(filename);
> -    if(len>4 && !strcmp(filename+len-4,".dmg"))

Someone really didn't like whitespace :)  Glad to see it rewritten to
keep the patch checker happy.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]