From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:57327) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UI8m5-0006SI-Dr for qemu-devel@nongnu.org; Tue, 19 Mar 2013 22:29:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UI8m3-00012b-M3 for qemu-devel@nongnu.org; Tue, 19 Mar 2013 22:29:09 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41304) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UI8m3-00012S-Dg for qemu-devel@nongnu.org; Tue, 19 Mar 2013 22:29:07 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r2K2T6eT003020 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 19 Mar 2013 22:29:06 -0400 Message-ID: <51491EF1.9000400@redhat.com> Date: Tue, 19 Mar 2013 20:29:05 -0600 From: Eric Blake MIME-Version: 1.0 References: <1363627441-8297-1-git-send-email-kwolf@redhat.com> <1363627441-8297-12-git-send-email-kwolf@redhat.com> In-Reply-To: <1363627441-8297-12-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2JMAPHQCFNNNQKXKLQGDH" Subject: Re: [Qemu-devel] [PATCH 11/11] nbd: Use default port if only host is specified List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: pbonzini@redhat.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2JMAPHQCFNNNQKXKLQGDH Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 03/18/2013 11:24 AM, Kevin Wolf wrote: > The URL method already takes care to apply the default port when none i= s > specfied. Directly specifying driver-specific options required the port= > number until now. Allow leaving it out and apply the default. >=20 > Signed-off-by: Kevin Wolf > --- > block/nbd.c | 17 +++++++++-------- > 1 file changed, 9 insertions(+), 8 deletions(-) >=20 > diff --git a/block/nbd.c b/block/nbd.c > index 218df6a..ac61b6d 100644 > --- a/block/nbd.c > +++ b/block/nbd.c > @@ -119,20 +119,17 @@ static int nbd_parse_uri(const char *filename, QD= ict *options) > qdict_put(options, "path", qstring_from_str(qp->p[0].value)); > } else { > /* nbd[+tcp]://host:port/export */ Should this comment be rewritten as: /* nbd[+tcp]://host[:port]/export */ But that's trivial, so: Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2JMAPHQCFNNNQKXKLQGDH Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRSR7xAAoJEKeha0olJ0Nq5sIH+wbqprTN6AmBTgOfHX6nyF6d 0Xxh6jFMQ/A9Ybc1dfLHOvuO8jOKCrR09mukVczufKmgYzs7g55129y6/HhSEMp6 fh51E6xkBAKak+nK3kSPRhO/jBmrCJdLG6aegqmCA4YNrd1eP5DdffY4GEluLZ1W ffhBgtZ94UfeqD+JW83Xk+1b85VVfMQzWeKILN5R2MmPPgP1V3AADSBtiOp0XUov XQy7ObWzCXu0theP3UJbZUgC8am7/Apv9NYCLoOpKNUhw5/pcl23NJiUKj2/V8b6 VNkAfGlI+5DuCVZhc/LGUS2dect2wg3ZDJnz0Ki00h0Y3+NLnoOWeQcTBdIe2GM= =KpsO -----END PGP SIGNATURE----- ------enig2JMAPHQCFNNNQKXKLQGDH--