From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Vrabel Subject: Re: [PATCH 2/8] evtchn: refactor low-level event channel port ops Date: Wed, 20 Mar 2013 13:37:05 +0000 Message-ID: <5149BB81.9020906@citrix.com> References: <1363726818-25409-1-git-send-email-david.vrabel@citrix.com> <1363726818-25409-3-git-send-email-david.vrabel@citrix.com> <51499BCF02000078000C7171@nat28.tlf.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <51499BCF02000078000C7171@nat28.tlf.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: "Keir (Xen.org)" , Konrad Rzeszutek Wilk , Wei Liu , "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org On 20/03/13 10:21, Jan Beulich wrote: >>>> On 19.03.13 at 22:00, David Vrabel wrote: >> --- /dev/null >> +++ b/xen/common/event_port.c > > Is this really a good name? Wouldn't it be better to have a separate > file per ABI (e.g. this one being evt_port_2l.c)? Agreed. I did this on the Linux side and it's better. >> --- a/xen/include/xen/sched.h >> +++ b/xen/include/xen/sched.h >> @@ -81,6 +81,7 @@ struct evtchn >> } pirq; /* state == ECS_PIRQ */ >> u16 virq; /* state == ECS_VIRQ */ >> } u; >> + u32 port; > > The need for this field doesn't become obvious after going > through the entire patch - if it really needs adding here, the > description should say why, I would think. The evtchn_ops calls all take a struct evtchn * as a parameter so we need this field to get the port. David