From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gregory CLEMENT Subject: Re: [PATCHv3 08/10] clocksource: time-armada-370-xp: Fix sparse warning Date: Wed, 20 Mar 2013 18:06:49 +0100 Message-ID: <5149ECA9.9000100@free-electrons.com> References: <1363198676-30417-1-git-send-email-sboyd@codeaurora.org> <1363198676-30417-9-git-send-email-sboyd@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from mail.free-electrons.com ([94.23.35.102]:49513 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752051Ab3CTRG7 (ORCPT ); Wed, 20 Mar 2013 13:06:59 -0400 In-Reply-To: <1363198676-30417-9-git-send-email-sboyd@codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Stephen Boyd Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Jason Cooper On 03/13/2013 07:17 PM, Stephen Boyd wrote: > drivers/clocksource/time-armada-370-xp.c:217:13: warning: symbol > 'armada_370_xp_timer_init' was not declared. Should it be static? > > Also remove the __init marking in the prototype as it's > unnecessary and drop the init.h file. > > Cc: Gregory CLEMENT > Signed-off-by: Stephen Boyd > --- > drivers/clocksource/time-armada-370-xp.c | 3 ++- > include/linux/time-armada-370-xp.h | 4 +--- > 2 files changed, 3 insertions(+), 4 deletions(-) > > diff --git a/drivers/clocksource/time-armada-370-xp.c b/drivers/clocksource/time-armada-370-xp.c > index 47a6730..efe4aef 100644 > --- a/drivers/clocksource/time-armada-370-xp.c > +++ b/drivers/clocksource/time-armada-370-xp.c > @@ -27,10 +27,11 @@ > #include > #include > #include > +#include > +#include > > #include > #include > -#include > /* > * Timer block registers. > */ > diff --git a/include/linux/time-armada-370-xp.h b/include/linux/time-armada-370-xp.h > index dfdfdc0..6fb0856 100644 > --- a/include/linux/time-armada-370-xp.h > +++ b/include/linux/time-armada-370-xp.h > @@ -11,8 +11,6 @@ > #ifndef __TIME_ARMADA_370_XPPRCMU_H > #define __TIME_ARMADA_370_XPPRCMU_H > > -#include > - > -void __init armada_370_xp_timer_init(void); > +void armada_370_xp_timer_init(void); > > #endif > Acked-by: Gregory CLEMENT -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: gregory.clement@free-electrons.com (Gregory CLEMENT) Date: Wed, 20 Mar 2013 18:06:49 +0100 Subject: [PATCHv3 08/10] clocksource: time-armada-370-xp: Fix sparse warning In-Reply-To: <1363198676-30417-9-git-send-email-sboyd@codeaurora.org> References: <1363198676-30417-1-git-send-email-sboyd@codeaurora.org> <1363198676-30417-9-git-send-email-sboyd@codeaurora.org> Message-ID: <5149ECA9.9000100@free-electrons.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 03/13/2013 07:17 PM, Stephen Boyd wrote: > drivers/clocksource/time-armada-370-xp.c:217:13: warning: symbol > 'armada_370_xp_timer_init' was not declared. Should it be static? > > Also remove the __init marking in the prototype as it's > unnecessary and drop the init.h file. > > Cc: Gregory CLEMENT > Signed-off-by: Stephen Boyd > --- > drivers/clocksource/time-armada-370-xp.c | 3 ++- > include/linux/time-armada-370-xp.h | 4 +--- > 2 files changed, 3 insertions(+), 4 deletions(-) > > diff --git a/drivers/clocksource/time-armada-370-xp.c b/drivers/clocksource/time-armada-370-xp.c > index 47a6730..efe4aef 100644 > --- a/drivers/clocksource/time-armada-370-xp.c > +++ b/drivers/clocksource/time-armada-370-xp.c > @@ -27,10 +27,11 @@ > #include > #include > #include > +#include > +#include > > #include > #include > -#include > /* > * Timer block registers. > */ > diff --git a/include/linux/time-armada-370-xp.h b/include/linux/time-armada-370-xp.h > index dfdfdc0..6fb0856 100644 > --- a/include/linux/time-armada-370-xp.h > +++ b/include/linux/time-armada-370-xp.h > @@ -11,8 +11,6 @@ > #ifndef __TIME_ARMADA_370_XPPRCMU_H > #define __TIME_ARMADA_370_XPPRCMU_H > > -#include > - > -void __init armada_370_xp_timer_init(void); > +void armada_370_xp_timer_init(void); > > #endif > Acked-by: Gregory CLEMENT -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com