From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCH 2/7] ARM: tegra: update device trees for USB binding rework Date: Wed, 20 Mar 2013 11:31:50 -0600 Message-ID: <5149F286.30204@wwwdotorg.org> References: <1363609781-4045-1-git-send-email-vbyravarasu@nvidia.com> <1363609781-4045-3-git-send-email-vbyravarasu@nvidia.com> <51499C29.6070405@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <51499C29.6070405@ti.com> Sender: linux-kernel-owner@vger.kernel.org To: kishon Cc: Venu Byravarasu , gregkh@linuxfoundation.org, stern@rowland.harvard.edu, balbi@ti.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, devicetree-discuss@lists.ozlabs.org List-Id: linux-tegra@vger.kernel.org On 03/20/2013 05:23 AM, kishon wrote: > Hi, > > On Monday 18 March 2013 05:59 PM, Venu Byravarasu wrote: >> This patch updates all Tegra board files so that they contain all the >> properties required by the updated USB DT binding. Note that this patch >> only adds the new properties and does not yet remove the old properties, >> in order to maintain bisectability. The old properties will be removed >> once the driver has been updated to assume the new bindings. >> >> Signed-off-by: Venu Byravarasu >> --- >> arch/arm/boot/dts/tegra20-colibri-512.dtsi | 4 +++ >> arch/arm/boot/dts/tegra20-harmony.dts | 8 +++--- >> arch/arm/boot/dts/tegra20-iris-512.dts | 4 +++ >> arch/arm/boot/dts/tegra20-paz00.dts | 8 +++--- >> arch/arm/boot/dts/tegra20-seaboard.dts | 13 +++++++--- >> arch/arm/boot/dts/tegra20-trimslice.dts | 12 +++++++--- >> arch/arm/boot/dts/tegra20-ventana.dts | 7 +++-- >> arch/arm/boot/dts/tegra20.dtsi | 32 >> +++++++++++++++++---------- >> 8 files changed, 57 insertions(+), 31 deletions(-) >> >> diff --git a/arch/arm/boot/dts/tegra20-colibri-512.dtsi >> b/arch/arm/boot/dts/tegra20-colibri-512.dtsi >> index cb73e62..af5a7ae 100644 >> --- a/arch/arm/boot/dts/tegra20-colibri-512.dtsi >> +++ b/arch/arm/boot/dts/tegra20-colibri-512.dtsi >> @@ -443,6 +443,10 @@ >> nvidia,phy-reset-gpio = <&gpio 169 0>; /* gpio PV1 */ >> }; >> >> + usb-phy@c5004000 { > > This node doesn't have a *reg* property. So "@c5004000" is not needed. > This comment applies to all the nodes which doesn't have *reg* property. Yes it does have a reg property. The node itself is first defined in tegra20.dtsi, and does contain a reg property there. tegra20-colibri-512.dtsi (and many other files in this patch) include tegra20.dtsi, and simply add additional board-specific properties to the existing node, and should not re-iterate properties that already exist.