From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:38707) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UIa8u-0007EY-LF for qemu-devel@nongnu.org; Thu, 21 Mar 2013 03:42:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UIa8t-0000tr-SQ for qemu-devel@nongnu.org; Thu, 21 Mar 2013 03:42:32 -0400 Received: from mx1.redhat.com ([209.132.183.28]:2807) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UIa8t-0000tk-Ke for qemu-devel@nongnu.org; Thu, 21 Mar 2013 03:42:31 -0400 Message-ID: <514AB9E2.1060509@redhat.com> Date: Thu, 21 Mar 2013 08:42:26 +0100 From: Gerd Hoffmann MIME-Version: 1.0 References: <1363772625-9182-1-git-send-email-kraxel@redhat.com> <1363772625-9182-10-git-send-email-kraxel@redhat.com> <514A0478.3090908@gmail.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 09/23] console: displaystate init revamp List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mitsyanko Cc: Anthony Liguori , qemu-devel@nongnu.org Hi, > Shouldn't get_alloc_displaystate() be used here instead? Thought about it, doesn't save a single line of code though, so I skipped the extra indirection. cheers, Gerd