From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Osipenko Subject: Re: [PATCH v2 2/6] ARM: tegra: Expose functions required for cpuidle driver Date: Thu, 11 Jul 2019 20:25:25 +0300 Message-ID: <514c1cd6-2180-b55f-dacc-f0e08d9a366f@gmail.com> References: <20190711031312.10038-1-digetx@gmail.com> <20190711031312.10038-3-digetx@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Jon Hunter , Thierry Reding , Peter De Schrijver , "Rafael J. Wysocki" , Daniel Lezcano Cc: linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org List-Id: linux-tegra@vger.kernel.org MTEuMDcuMjAxOSAxNTo0MiwgSm9uIEh1bnRlciDQv9C40YjQtdGCOgo+IAo+IE9uIDExLzA3LzIw MTkgMDQ6MTMsIERtaXRyeSBPc2lwZW5rbyB3cm90ZToKPj4gVGhlIHVwY29taW5nIHVuaWZpZWQg Q1BVSURMRSBkcml2ZXIgd2lsbCBiZSBhZGRlZCB0byB0aGUgZHJpdmVycy9jcHVpZGxlLwo+PiBk aXJlY3RvcnkgYW5kIGl0IHdpbGwgcmVxdWlyZSBhbGwgdGhlc2UgVGVncmEgUE0tY29yZSBmdW5j dGlvbnMuCj4+Cj4+IFNpZ25lZC1vZmYtYnk6IERtaXRyeSBPc2lwZW5rbyA8ZGlnZXR4QGdtYWls LmNvbT4KPj4gLS0tCj4+ICBhcmNoL2FybS9tYWNoLXRlZ3JhL01ha2VmaWxlICB8ICAyICstCj4+ ICBhcmNoL2FybS9tYWNoLXRlZ3JhL3BsYXRzbXAuYyB8ICAyIC0tCj4+ICBhcmNoL2FybS9tYWNo LXRlZ3JhL3BtLmMgICAgICB8IDE2ICsrKysrKystLS0tLS0tLS0KPj4gIGFyY2gvYXJtL21hY2gt dGVncmEvcG0uaCAgICAgIHwgIDMgLS0tCj4+ICBhcmNoL2FybS9tYWNoLXRlZ3JhL3NsZWVwLmgg ICB8ICAxIC0KPj4gIGluY2x1ZGUvbGludXgvY2xrL3RlZ3JhLmggICAgIHwgMTMgKysrKysrKysr KysrKwo+PiAgaW5jbHVkZS9zb2MvdGVncmEvcG0uaCAgICAgICAgfCAyOCArKysrKysrKysrKysr KysrKysrKysrKysrKysrCj4+ICA3IGZpbGVzIGNoYW5nZWQsIDQ5IGluc2VydGlvbnMoKyksIDE2 IGRlbGV0aW9ucygtKQo+Pgo+PiBkaWZmIC0tZ2l0IGEvYXJjaC9hcm0vbWFjaC10ZWdyYS9NYWtl ZmlsZSBiL2FyY2gvYXJtL21hY2gtdGVncmEvTWFrZWZpbGUKPj4gaW5kZXggNWQ5M2EwYjM2ODY2 Li4yN2JkNWQ5ODY1ZTMgMTAwNjQ0Cj4+IC0tLSBhL2FyY2gvYXJtL21hY2gtdGVncmEvTWFrZWZp bGUKPj4gKysrIGIvYXJjaC9hcm0vbWFjaC10ZWdyYS9NYWtlZmlsZQo+PiBAQCAtMTMsNyArMTMs NyBAQCBvYmotJChDT05GSUdfQVJDSF9URUdSQV8yeF9TT0MpCQkrPSBwbS10ZWdyYTIwLm8KPj4g IG9iai0kKENPTkZJR19BUkNIX1RFR1JBXzN4X1NPQykJCSs9IHNsZWVwLXRlZ3JhMzAubwo+PiAg b2JqLSQoQ09ORklHX0FSQ0hfVEVHUkFfM3hfU09DKQkJKz0gcG0tdGVncmEzMC5vCj4+ICBvYmot JChDT05GSUdfU01QKQkJCSs9IHBsYXRzbXAubwo+PiAtb2JqLSQoQ09ORklHX0hPVFBMVUdfQ1BV KSAgICAgICAgICAgICAgICs9IGhvdHBsdWcubwo+PiArb2JqLXkJCQkJCSs9IGhvdHBsdWcubwo+ PiAgCj4+ICBvYmotJChDT05GSUdfQVJDSF9URUdSQV8xMTRfU09DKQkrPSBzbGVlcC10ZWdyYTMw Lm8KPj4gIG9iai0kKENPTkZJR19BUkNIX1RFR1JBXzExNF9TT0MpCSs9IHBtLXRlZ3JhMzAubwo+ PiBkaWZmIC0tZ2l0IGEvYXJjaC9hcm0vbWFjaC10ZWdyYS9wbGF0c21wLmMgYi9hcmNoL2FybS9t YWNoLXRlZ3JhL3BsYXRzbXAuYwo+PiBpbmRleCBlNjkxMWExNGMwOTYuLmM4YTYzNzE5YTE0MyAx MDA2NDQKPj4gLS0tIGEvYXJjaC9hcm0vbWFjaC10ZWdyYS9wbGF0c21wLmMKPj4gKysrIGIvYXJj aC9hcm0vbWFjaC10ZWdyYS9wbGF0c21wLmMKPj4gQEAgLTE4Myw4ICsxODMsNiBAQCBjb25zdCBz dHJ1Y3Qgc21wX29wZXJhdGlvbnMgdGVncmFfc21wX29wcyBfX2luaXRjb25zdCA9IHsKPj4gIAku c21wX3ByZXBhcmVfY3B1cwk9IHRlZ3JhX3NtcF9wcmVwYXJlX2NwdXMsCj4+ICAJLnNtcF9zZWNv bmRhcnlfaW5pdAk9IHRlZ3JhX3NlY29uZGFyeV9pbml0LAo+PiAgCS5zbXBfYm9vdF9zZWNvbmRh cnkJPSB0ZWdyYV9ib290X3NlY29uZGFyeSwKPj4gLSNpZmRlZiBDT05GSUdfSE9UUExVR19DUFUK Pj4gIAkuY3B1X2tpbGwJCT0gdGVncmFfY3B1X2tpbGwsCj4+ICAJLmNwdV9kaWUJCT0gdGVncmFf Y3B1X2RpZSwKPj4gLSNlbmRpZgo+PiAgfTsKPj4gZGlmZiAtLWdpdCBhL2FyY2gvYXJtL21hY2gt dGVncmEvcG0uYyBiL2FyY2gvYXJtL21hY2gtdGVncmEvcG0uYwo+PiBpbmRleCA2YWFhY2I1NzU3 ZTEuLmY5YzliY2U5ZTE1ZCAxMDA2NDQKPj4gLS0tIGEvYXJjaC9hcm0vbWFjaC10ZWdyYS9wbS5j Cj4+ICsrKyBiL2FyY2gvYXJtL21hY2gtdGVncmEvcG0uYwo+PiBAQCAtMTIzLDExICsxMjMsOSBA QCB2b2lkIHRlZ3JhX2NsZWFyX2NwdV9pbl9scDIodm9pZCkKPj4gIAlzcGluX3VubG9jaygmdGVn cmFfbHAyX2xvY2spOwo+PiAgfQo+PiAgCj4+IC1ib29sIHRlZ3JhX3NldF9jcHVfaW5fbHAyKHZv aWQpCj4+ICt2b2lkIHRlZ3JhX3NldF9jcHVfaW5fbHAyKHZvaWQpCj4+ICB7Cj4+ICAJaW50IHBo eV9jcHVfaWQgPSBjcHVfbG9naWNhbF9tYXAoc21wX3Byb2Nlc3Nvcl9pZCgpKTsKPj4gLQlib29s IGxhc3RfY3B1ID0gZmFsc2U7Cj4+IC0JY3B1bWFza190ICpjcHVfbHAyX21hc2sgPSB0ZWdyYV9j cHVfbHAyX21hc2s7Cj4+ICAJdTMyICpjcHVfaW5fbHAyID0gdGVncmFfY3B1X2xwMl9tYXNrOwo+ PiAgCj4+ICAJc3Bpbl9sb2NrKCZ0ZWdyYV9scDJfbG9jayk7Cj4+IEBAIC0xMzUsMTEgKzEzMyw3 IEBAIGJvb2wgdGVncmFfc2V0X2NwdV9pbl9scDIodm9pZCkKPj4gIAlCVUdfT04oKCpjcHVfaW5f bHAyICYgQklUKHBoeV9jcHVfaWQpKSk7Cj4+ICAJKmNwdV9pbl9scDIgfD0gQklUKHBoeV9jcHVf aWQpOwo+PiAgCj4+IC0JaWYgKChwaHlfY3B1X2lkID09IDApICYmIGNwdW1hc2tfZXF1YWwoY3B1 X2xwMl9tYXNrLCBjcHVfb25saW5lX21hc2spKQo+PiAtCQlsYXN0X2NwdSA9IHRydWU7Cj4+IC0K Pj4gIAlzcGluX3VubG9jaygmdGVncmFfbHAyX2xvY2spOwo+PiAtCXJldHVybiBsYXN0X2NwdTsK Pj4gIH0KPiAKPiBJIHRoaW5rIHRoYXQgdGhlIGNvbW1pdCBtZXNzYWdlIHNob3VsZCBkZXNjcmli ZSB3aGF0IGlzIGdvaW5nIG9uIGhlcmUgb3IKPiB0aGlzIHNob3VsZCBiZSBhIHNlcGFyYXRlIGNo YW5nZS4KCkluZGVlZCwgaXQgY291bGQgYmUgbm90IHZlcnkgb2J2aW91cyB3aGF0J3MgZ29pbmcg b24gaGVyZSB3aXRob3V0IGEKdGhvcm91Z2ggcmV2aWV3LiBJJ2xsIGZhY3RvciBvdXQgYWxsIHRo ZXNlIG1pbm9yIGNoYW5nZXMgaW50byBzZXBhcmF0ZQpjb21taXRzLgoKSW4gcGFydGljdWxhciB0 aGVyZSBpcyBubyBuZWVkIHRvIGtub3cgd2hldGhlciBDUFUgaXMgdGhlICJsYXN0X2NwdSIgZm9y CnRoZSBuZXcgZHJpdmVyIGJlY2F1c2UgQ1BVMCBpcyBhbHdheXMgdGhlICJsYXN0IiBzaW5jZSBp dCBhd2FpdHMgZm9yIHRoZQpzZWNvbmRhcmllcyBpbiB0aGUgY291cGxlZCBzdGF0ZS4KCj4+ICBz dGF0aWMgaW50IHRlZ3JhX3NsZWVwX2NwdSh1bnNpZ25lZCBsb25nIHYycCkKPj4gQEAgLTE5NSwx NCArMTg5LDE2IEBAIHN0YXRpYyB2b2lkIHRlZ3JhX3BtX3NldChlbnVtIHRlZ3JhX3N1c3BlbmRf bW9kZSBtb2RlKQo+PiAgCXRlZ3JhX3BtY19lbnRlcl9zdXNwZW5kX21vZGUobW9kZSk7Cj4+ICB9 Cj4+ICAKPj4gLXZvaWQgdGVncmFfaWRsZV9scDJfbGFzdCh2b2lkKQo+PiAraW50IHRlZ3JhX2lk bGVfbHAyX2xhc3Qodm9pZCkKPj4gIHsKPj4gKwlpbnQgZXJyOwo+PiArCj4+ICAJdGVncmFfcG1f c2V0KFRFR1JBX1NVU1BFTkRfTFAyKTsKPj4gIAo+PiAgCWNwdV9jbHVzdGVyX3BtX2VudGVyKCk7 Cj4+ICAJc3VzcGVuZF9jcHVfY29tcGxleCgpOwo+PiAgCj4+IC0JY3B1X3N1c3BlbmQoUEhZU19P RkZTRVQgLSBQQUdFX09GRlNFVCwgJnRlZ3JhX3NsZWVwX2NwdSk7Cj4+ICsJZXJyID0gY3B1X3N1 c3BlbmQoUEhZU19PRkZTRVQgLSBQQUdFX09GRlNFVCwgJnRlZ3JhX3NsZWVwX2NwdSk7Cj4+ICAK Pj4gIAkvKgo+PiAgCSAqIFJlc3VtZSBMMiBjYWNoZSBpZiBpdCB3YXNuJ3QgcmUtZW5hYmxlZCBl YXJseSBkdXJpbmcgcmVzdW1lLAo+PiBAQCAtMjE0LDYgKzIxMCw4IEBAIHZvaWQgdGVncmFfaWRs ZV9scDJfbGFzdCh2b2lkKQo+PiAgCj4+ICAJcmVzdG9yZV9jcHVfY29tcGxleCgpOwo+PiAgCWNw dV9jbHVzdGVyX3BtX2V4aXQoKTsKPj4gKwo+PiArCXJldHVybiBlcnI7Cj4+ICB9Cj4+ICAKPj4g IGVudW0gdGVncmFfc3VzcGVuZF9tb2RlIHRlZ3JhX3BtX3ZhbGlkYXRlX3N1c3BlbmRfbW9kZSgK Pj4gZGlmZiAtLWdpdCBhL2FyY2gvYXJtL21hY2gtdGVncmEvcG0uaCBiL2FyY2gvYXJtL21hY2gt dGVncmEvcG0uaAo+PiBpbmRleCAxZTUxYTliNjM2ZWIuLjgxNTI1ZjVmNGE0NCAxMDA2NDQKPj4g LS0tIGEvYXJjaC9hcm0vbWFjaC10ZWdyYS9wbS5oCj4+ICsrKyBiL2FyY2gvYXJtL21hY2gtdGVn cmEvcG0uaAo+PiBAQCAtMjMsOSArMjMsNiBAQCB2b2lkIHRlZ3JhMjBfc2xlZXBfY29yZV9pbml0 KHZvaWQpOwo+PiAgdm9pZCB0ZWdyYTMwX2xwMV9pcmFtX2hvb2sodm9pZCk7Cj4+ICB2b2lkIHRl Z3JhMzBfc2xlZXBfY29yZV9pbml0KHZvaWQpOwo+PiAgCj4+IC12b2lkIHRlZ3JhX2NsZWFyX2Nw dV9pbl9scDIodm9pZCk7Cj4+IC1ib29sIHRlZ3JhX3NldF9jcHVfaW5fbHAyKHZvaWQpOwo+PiAt dm9pZCB0ZWdyYV9pZGxlX2xwMl9sYXN0KHZvaWQpOwo+PiAgZXh0ZXJuIHZvaWQgKCp0ZWdyYV90 ZWFyX2Rvd25fY3B1KSh2b2lkKTsKPj4gIAo+PiAgI2lmZGVmIENPTkZJR19QTV9TTEVFUAo+PiBk aWZmIC0tZ2l0IGEvYXJjaC9hcm0vbWFjaC10ZWdyYS9zbGVlcC5oIGIvYXJjaC9hcm0vbWFjaC10 ZWdyYS9zbGVlcC5oCj4+IGluZGV4IGQyMTk4NzJiNzU0Ni4uMGQ5OTU2ZTlhOGVhIDEwMDY0NAo+ PiAtLS0gYS9hcmNoL2FybS9tYWNoLXRlZ3JhL3NsZWVwLmgKPj4gKysrIGIvYXJjaC9hcm0vbWFj aC10ZWdyYS9zbGVlcC5oCj4+IEBAIC0xMjQsNyArMTI0LDYgQEAgdm9pZCB0ZWdyYTMwX2hvdHBs dWdfc2h1dGRvd24odm9pZCk7Cj4+ICAjZW5kaWYKPj4gIAo+PiAgdm9pZCB0ZWdyYTIwX3RlYXJf ZG93bl9jcHUodm9pZCk7Cj4+IC1pbnQgdGVncmEzMF9zbGVlcF9jcHVfc2Vjb25kYXJ5X2Zpbmlz aCh1bnNpZ25lZCBsb25nKTsKPj4gIHZvaWQgdGVncmEzMF90ZWFyX2Rvd25fY3B1KHZvaWQpOwo+ PiAgCj4+ICAjZW5kaWYKPj4gZGlmZiAtLWdpdCBhL2luY2x1ZGUvbGludXgvY2xrL3RlZ3JhLmgg Yi9pbmNsdWRlL2xpbnV4L2Nsay90ZWdyYS5oCj4+IGluZGV4IGI4YWVmNjJjYzNmNS4uY2YwZjJj YjVlMTA5IDEwMDY0NAo+PiAtLS0gYS9pbmNsdWRlL2xpbnV4L2Nsay90ZWdyYS5oCj4+ICsrKyBi L2luY2x1ZGUvbGludXgvY2xrL3RlZ3JhLmgKPj4gQEAgLTEwOCw2ICsxMDgsMTkgQEAgc3RhdGlj IGlubGluZSB2b2lkIHRlZ3JhX2NwdV9jbG9ja19yZXN1bWUodm9pZCkKPj4gIAo+PiAgCXRlZ3Jh X2NwdV9jYXJfb3BzLT5yZXN1bWUoKTsKPj4gIH0KPj4gKyNlbHNlCj4+ICtzdGF0aWMgaW5saW5l IGJvb2wgdGVncmFfY3B1X3JhaWxfb2ZmX3JlYWR5KHZvaWQpCj4+ICt7Cj4+ICsJcmV0dXJuIGZh bHNlOwo+PiArfQo+PiArCj4+ICtzdGF0aWMgaW5saW5lIHZvaWQgdGVncmFfY3B1X2Nsb2NrX3N1 c3BlbmQodm9pZCkKPj4gK3sKPj4gK30KPj4gKwo+PiArc3RhdGljIGlubGluZSB2b2lkIHRlZ3Jh X2NwdV9jbG9ja19yZXN1bWUodm9pZCkKPj4gK3sKPj4gK30KPj4gICNlbmRpZgo+PiAgCj4+ICBl eHRlcm4gdm9pZCB0ZWdyYTIxMF94dXNiX3BsbF9od19jb250cm9sX2VuYWJsZSh2b2lkKTsKPj4g ZGlmZiAtLWdpdCBhL2luY2x1ZGUvc29jL3RlZ3JhL3BtLmggYi9pbmNsdWRlL3NvYy90ZWdyYS9w bS5oCj4+IGluZGV4IDk1MWZjZDczOGQ1NS4uZmExOGMyZGY1MDI4IDEwMDY0NAo+PiAtLS0gYS9p bmNsdWRlL3NvYy90ZWdyYS9wbS5oCj4+ICsrKyBiL2luY2x1ZGUvc29jL3RlZ3JhL3BtLmgKPj4g QEAgLTIwLDYgKzIwLDEyIEBAIHRlZ3JhX3BtX3ZhbGlkYXRlX3N1c3BlbmRfbW9kZShlbnVtIHRl Z3JhX3N1c3BlbmRfbW9kZSBtb2RlKTsKPj4gIAo+PiAgLyogbG93LWxldmVsIHJlc3VtZSBlbnRy eSBwb2ludCAqLwo+PiAgdm9pZCB0ZWdyYV9yZXN1bWUodm9pZCk7Cj4+ICsKPj4gK2ludCB0ZWdy YTMwX3NsZWVwX2NwdV9zZWNvbmRhcnlfZmluaXNoKHVuc2lnbmVkIGxvbmcgYXJnKTsKPj4gK3Zv aWQgdGVncmFfY2xlYXJfY3B1X2luX2xwMih2b2lkKTsKPj4gK3ZvaWQgdGVncmFfc2V0X2NwdV9p bl9scDIodm9pZCk7Cj4+ICtpbnQgdGVncmFfaWRsZV9scDJfbGFzdCh2b2lkKTsKPj4gK3ZvaWQg dGVncmFfY3B1X2RpZSh1bnNpZ25lZCBpbnQgY3B1KTsKPj4gICNlbHNlCj4+ICBzdGF0aWMgaW5s aW5lIGVudW0gdGVncmFfc3VzcGVuZF9tb2RlCj4+ICB0ZWdyYV9wbV92YWxpZGF0ZV9zdXNwZW5k X21vZGUoZW51bSB0ZWdyYV9zdXNwZW5kX21vZGUgbW9kZSkKPj4gQEAgLTMwLDYgKzM2LDI4IEBA IHRlZ3JhX3BtX3ZhbGlkYXRlX3N1c3BlbmRfbW9kZShlbnVtIHRlZ3JhX3N1c3BlbmRfbW9kZSBt b2RlKQo+PiAgc3RhdGljIGlubGluZSB2b2lkIHRlZ3JhX3Jlc3VtZSh2b2lkKQo+PiAgewo+PiAg fQo+PiArCj4+ICtzdGF0aWMgaW5saW5lIGludCB0ZWdyYTMwX3NsZWVwX2NwdV9zZWNvbmRhcnlf ZmluaXNoKHVuc2lnbmVkIGxvbmcgYXJnKQo+PiArewo+PiArCXJldHVybiAtMTsKPj4gK30KPiAK PiAtRU5PVFNVUFA/CgpHb29kIHBvaW50LCB0aGFua3MhCgpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdAps aW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVh ZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6880C71142 for ; Thu, 11 Jul 2019 17:25:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7680920863 for ; Thu, 11 Jul 2019 17:25:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ApmKnjpV" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728878AbfGKRZb (ORCPT ); Thu, 11 Jul 2019 13:25:31 -0400 Received: from mail-lf1-f68.google.com ([209.85.167.68]:34197 "EHLO mail-lf1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726213AbfGKRZa (ORCPT ); Thu, 11 Jul 2019 13:25:30 -0400 Received: by mail-lf1-f68.google.com with SMTP id b29so4621864lfq.1; Thu, 11 Jul 2019 10:25:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=2YMfHUBjXHpo+j06pyniNllvZMRnbJcOo4hnaLC71sE=; b=ApmKnjpVGrYMZYw9nmXLaN19GMQAPjPv7W7548PsMxVOiIztXhPoNpajU9makN5x2H OU0g1aGH+1kMbq6R3KOSnFMvkR8XhQ2jFY2cP+EMCN/4OFxDNNoOwETRn6/Xy+NtZtX4 YKd4yvHwa1C/idpQfxRbeKHt3PemDXwQi4pah8oRvYDoaKqVfPRMzg0UDVwEfg5k4mUN mDTv06DQjk2qoQ+t7NqHgN5e1oupNpskmuphiTmuBMeSlkwl8o6yFHkJAk5PuqFp0gHM aTgj3TNmg6D7mj6G4ID7Ezg4KvEfhTp/OlYXv/nFMYo3JEp4+AtKyQmtxC3zmv1PZApN IqIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=2YMfHUBjXHpo+j06pyniNllvZMRnbJcOo4hnaLC71sE=; b=luE1FzP7fw951kVwYtvGw391QaIPfWDy6yMp5SznCzF8GaGtUDHD5M+BH0Uhbi9WAI IZzo8KYEX/0lJKUOKnJrKsI8HC4LAI99wqCSorLGNn6kv1xsU2z0exhQndJ8gr6eMPCs DDmd/mLT3z6I1I0CxArymII0UblBRnOoYg2spXFni8QbQC6aZu+Ah/w6GwZ+SRSVf/NK A7cfS6AgT+KNlb3/GadnhseUiQZmPC8S2gZoSQjl58LRjHLy5QASMvJ/ANCCUJw9k/Z2 DIFf+3oZR58oFCMDmnIEiqV+UfDHeAlOIvbYYjSet6Exbkujf/Wu5PmDfCkUY0G/fnz9 l0iQ== X-Gm-Message-State: APjAAAUBI6g4wTozkiQscO5gs9rqK41juFEEnxWH1MG/+xWPdxkS3jfS b9WQYCD0V5ng9+qJw+kFgLLBBPmo X-Google-Smtp-Source: APXvYqzfDDUhalkCcqE0q9tb+NTPSe5zxtMtKXFg82as9QK71ou16O9M+55H/j8aZ6Ikhc++VBbZ9A== X-Received: by 2002:ac2:52b7:: with SMTP id r23mr2490854lfm.120.1562865927145; Thu, 11 Jul 2019 10:25:27 -0700 (PDT) Received: from [192.168.2.145] (ppp79-139-233-208.pppoe.spdop.ru. [79.139.233.208]) by smtp.googlemail.com with ESMTPSA id b1sm1084553ljj.26.2019.07.11.10.25.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 11 Jul 2019 10:25:26 -0700 (PDT) Subject: Re: [PATCH v2 2/6] ARM: tegra: Expose functions required for cpuidle driver To: Jon Hunter , Thierry Reding , Peter De Schrijver , "Rafael J. Wysocki" , Daniel Lezcano Cc: linux-pm@vger.kernel.org, linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20190711031312.10038-1-digetx@gmail.com> <20190711031312.10038-3-digetx@gmail.com> From: Dmitry Osipenko Message-ID: <514c1cd6-2180-b55f-dacc-f0e08d9a366f@gmail.com> Date: Thu, 11 Jul 2019 20:25:25 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 11.07.2019 15:42, Jon Hunter пишет: > > On 11/07/2019 04:13, Dmitry Osipenko wrote: >> The upcoming unified CPUIDLE driver will be added to the drivers/cpuidle/ >> directory and it will require all these Tegra PM-core functions. >> >> Signed-off-by: Dmitry Osipenko >> --- >> arch/arm/mach-tegra/Makefile | 2 +- >> arch/arm/mach-tegra/platsmp.c | 2 -- >> arch/arm/mach-tegra/pm.c | 16 +++++++--------- >> arch/arm/mach-tegra/pm.h | 3 --- >> arch/arm/mach-tegra/sleep.h | 1 - >> include/linux/clk/tegra.h | 13 +++++++++++++ >> include/soc/tegra/pm.h | 28 ++++++++++++++++++++++++++++ >> 7 files changed, 49 insertions(+), 16 deletions(-) >> >> diff --git a/arch/arm/mach-tegra/Makefile b/arch/arm/mach-tegra/Makefile >> index 5d93a0b36866..27bd5d9865e3 100644 >> --- a/arch/arm/mach-tegra/Makefile >> +++ b/arch/arm/mach-tegra/Makefile >> @@ -13,7 +13,7 @@ obj-$(CONFIG_ARCH_TEGRA_2x_SOC) += pm-tegra20.o >> obj-$(CONFIG_ARCH_TEGRA_3x_SOC) += sleep-tegra30.o >> obj-$(CONFIG_ARCH_TEGRA_3x_SOC) += pm-tegra30.o >> obj-$(CONFIG_SMP) += platsmp.o >> -obj-$(CONFIG_HOTPLUG_CPU) += hotplug.o >> +obj-y += hotplug.o >> >> obj-$(CONFIG_ARCH_TEGRA_114_SOC) += sleep-tegra30.o >> obj-$(CONFIG_ARCH_TEGRA_114_SOC) += pm-tegra30.o >> diff --git a/arch/arm/mach-tegra/platsmp.c b/arch/arm/mach-tegra/platsmp.c >> index e6911a14c096..c8a63719a143 100644 >> --- a/arch/arm/mach-tegra/platsmp.c >> +++ b/arch/arm/mach-tegra/platsmp.c >> @@ -183,8 +183,6 @@ const struct smp_operations tegra_smp_ops __initconst = { >> .smp_prepare_cpus = tegra_smp_prepare_cpus, >> .smp_secondary_init = tegra_secondary_init, >> .smp_boot_secondary = tegra_boot_secondary, >> -#ifdef CONFIG_HOTPLUG_CPU >> .cpu_kill = tegra_cpu_kill, >> .cpu_die = tegra_cpu_die, >> -#endif >> }; >> diff --git a/arch/arm/mach-tegra/pm.c b/arch/arm/mach-tegra/pm.c >> index 6aaacb5757e1..f9c9bce9e15d 100644 >> --- a/arch/arm/mach-tegra/pm.c >> +++ b/arch/arm/mach-tegra/pm.c >> @@ -123,11 +123,9 @@ void tegra_clear_cpu_in_lp2(void) >> spin_unlock(&tegra_lp2_lock); >> } >> >> -bool tegra_set_cpu_in_lp2(void) >> +void tegra_set_cpu_in_lp2(void) >> { >> int phy_cpu_id = cpu_logical_map(smp_processor_id()); >> - bool last_cpu = false; >> - cpumask_t *cpu_lp2_mask = tegra_cpu_lp2_mask; >> u32 *cpu_in_lp2 = tegra_cpu_lp2_mask; >> >> spin_lock(&tegra_lp2_lock); >> @@ -135,11 +133,7 @@ bool tegra_set_cpu_in_lp2(void) >> BUG_ON((*cpu_in_lp2 & BIT(phy_cpu_id))); >> *cpu_in_lp2 |= BIT(phy_cpu_id); >> >> - if ((phy_cpu_id == 0) && cpumask_equal(cpu_lp2_mask, cpu_online_mask)) >> - last_cpu = true; >> - >> spin_unlock(&tegra_lp2_lock); >> - return last_cpu; >> } > > I think that the commit message should describe what is going on here or > this should be a separate change. Indeed, it could be not very obvious what's going on here without a thorough review. I'll factor out all these minor changes into separate commits. In particular there is no need to know whether CPU is the "last_cpu" for the new driver because CPU0 is always the "last" since it awaits for the secondaries in the coupled state. >> static int tegra_sleep_cpu(unsigned long v2p) >> @@ -195,14 +189,16 @@ static void tegra_pm_set(enum tegra_suspend_mode mode) >> tegra_pmc_enter_suspend_mode(mode); >> } >> >> -void tegra_idle_lp2_last(void) >> +int tegra_idle_lp2_last(void) >> { >> + int err; >> + >> tegra_pm_set(TEGRA_SUSPEND_LP2); >> >> cpu_cluster_pm_enter(); >> suspend_cpu_complex(); >> >> - cpu_suspend(PHYS_OFFSET - PAGE_OFFSET, &tegra_sleep_cpu); >> + err = cpu_suspend(PHYS_OFFSET - PAGE_OFFSET, &tegra_sleep_cpu); >> >> /* >> * Resume L2 cache if it wasn't re-enabled early during resume, >> @@ -214,6 +210,8 @@ void tegra_idle_lp2_last(void) >> >> restore_cpu_complex(); >> cpu_cluster_pm_exit(); >> + >> + return err; >> } >> >> enum tegra_suspend_mode tegra_pm_validate_suspend_mode( >> diff --git a/arch/arm/mach-tegra/pm.h b/arch/arm/mach-tegra/pm.h >> index 1e51a9b636eb..81525f5f4a44 100644 >> --- a/arch/arm/mach-tegra/pm.h >> +++ b/arch/arm/mach-tegra/pm.h >> @@ -23,9 +23,6 @@ void tegra20_sleep_core_init(void); >> void tegra30_lp1_iram_hook(void); >> void tegra30_sleep_core_init(void); >> >> -void tegra_clear_cpu_in_lp2(void); >> -bool tegra_set_cpu_in_lp2(void); >> -void tegra_idle_lp2_last(void); >> extern void (*tegra_tear_down_cpu)(void); >> >> #ifdef CONFIG_PM_SLEEP >> diff --git a/arch/arm/mach-tegra/sleep.h b/arch/arm/mach-tegra/sleep.h >> index d219872b7546..0d9956e9a8ea 100644 >> --- a/arch/arm/mach-tegra/sleep.h >> +++ b/arch/arm/mach-tegra/sleep.h >> @@ -124,7 +124,6 @@ void tegra30_hotplug_shutdown(void); >> #endif >> >> void tegra20_tear_down_cpu(void); >> -int tegra30_sleep_cpu_secondary_finish(unsigned long); >> void tegra30_tear_down_cpu(void); >> >> #endif >> diff --git a/include/linux/clk/tegra.h b/include/linux/clk/tegra.h >> index b8aef62cc3f5..cf0f2cb5e109 100644 >> --- a/include/linux/clk/tegra.h >> +++ b/include/linux/clk/tegra.h >> @@ -108,6 +108,19 @@ static inline void tegra_cpu_clock_resume(void) >> >> tegra_cpu_car_ops->resume(); >> } >> +#else >> +static inline bool tegra_cpu_rail_off_ready(void) >> +{ >> + return false; >> +} >> + >> +static inline void tegra_cpu_clock_suspend(void) >> +{ >> +} >> + >> +static inline void tegra_cpu_clock_resume(void) >> +{ >> +} >> #endif >> >> extern void tegra210_xusb_pll_hw_control_enable(void); >> diff --git a/include/soc/tegra/pm.h b/include/soc/tegra/pm.h >> index 951fcd738d55..fa18c2df5028 100644 >> --- a/include/soc/tegra/pm.h >> +++ b/include/soc/tegra/pm.h >> @@ -20,6 +20,12 @@ tegra_pm_validate_suspend_mode(enum tegra_suspend_mode mode); >> >> /* low-level resume entry point */ >> void tegra_resume(void); >> + >> +int tegra30_sleep_cpu_secondary_finish(unsigned long arg); >> +void tegra_clear_cpu_in_lp2(void); >> +void tegra_set_cpu_in_lp2(void); >> +int tegra_idle_lp2_last(void); >> +void tegra_cpu_die(unsigned int cpu); >> #else >> static inline enum tegra_suspend_mode >> tegra_pm_validate_suspend_mode(enum tegra_suspend_mode mode) >> @@ -30,6 +36,28 @@ tegra_pm_validate_suspend_mode(enum tegra_suspend_mode mode) >> static inline void tegra_resume(void) >> { >> } >> + >> +static inline int tegra30_sleep_cpu_secondary_finish(unsigned long arg) >> +{ >> + return -1; >> +} > > -ENOTSUPP? Good point, thanks!