From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:47534) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UK3kV-00007S-4L for qemu-devel@nongnu.org; Mon, 25 Mar 2013 05:31:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UK3kT-0000aX-Ew for qemu-devel@nongnu.org; Mon, 25 Mar 2013 05:31:27 -0400 Received: from mx1.redhat.com ([209.132.183.28]:10473) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UK3kT-0000aO-7y for qemu-devel@nongnu.org; Mon, 25 Mar 2013 05:31:25 -0400 Message-ID: <515019AE.7030407@redhat.com> Date: Mon, 25 Mar 2013 11:32:30 +0200 From: Orit Wasserman MIME-Version: 1.0 References: <1363956370-23681-1-git-send-email-pl@kamp.de> <1363956370-23681-7-git-send-email-pl@kamp.de> In-Reply-To: <1363956370-23681-7-git-send-email-pl@kamp.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCHv4 6/9] migration: add an indicator for bulk state of ram migration List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Lieven Cc: Stefan Hajnoczi , Paolo Bonzini , qemu-devel@nongnu.org, quintela@redhat.com On 03/22/2013 02:46 PM, Peter Lieven wrote: > the first round of ram transfer is special since all pages > are dirty and thus all memory pages are transferred to > the target. this patch adds a boolean variable to track > this stage. > > Signed-off-by: Peter Lieven > Reviewed-by: Eric Blake > --- > arch_init.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch_init.c b/arch_init.c > index 9ebca83..4c4caf4 100644 > --- a/arch_init.c > +++ b/arch_init.c > @@ -317,6 +317,7 @@ static ram_addr_t last_offset; > static unsigned long *migration_bitmap; > static uint64_t migration_dirty_pages; > static uint32_t last_version; > +static bool ram_bulk_stage; > > static inline > ram_addr_t migration_bitmap_find_and_reset_dirty(MemoryRegion *mr, > @@ -424,6 +425,7 @@ static int ram_save_block(QEMUFile *f, bool last_stage) > if (!block) { > block = QTAILQ_FIRST(&ram_list.blocks); > complete_round = true; > + ram_bulk_stage = false; > } > } else { > uint8_t *p; > @@ -527,6 +529,7 @@ static void reset_ram_globals(void) > last_sent_block = NULL; > last_offset = 0; > last_version = ram_list.version; > + ram_bulk_stage = true; > } > > #define MAX_WAIT 50 /* ms, half buffered_file limit */ > Reviewed-by: Orit Wasserman