From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Vrabel Subject: Re: [PATCH 1/6] xen-netfront: remove unused variable `extra' Date: Mon, 25 Mar 2013 14:21:23 +0000 Message-ID: <51505D63.7090102__32419.7802380242$1364221417$gmane$org@citrix.com> References: <1364209702-12437-1-git-send-email-wei.liu2@citrix.com> <1364209702-12437-2-git-send-email-wei.liu2@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1364209702-12437-2-git-send-email-wei.liu2@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Liu Cc: ian.campbell@citrix.com, konrad.wilk@oracle.com, netdev@vger.kernel.org, xen-devel@lists.xen.org, annie.li@oracle.com, david.vrabel@citrix.com List-Id: xen-devel@lists.xenproject.org On 25/03/13 11:08, Wei Liu wrote: > This variable is supposed to hold reference to the last extra_info in the > loop. However there is only type of extra info here and the loop to process > extra info is missing, so this variable is never used and causes confusion. > > Remove it at the moment. We can add it back when necessary. > > Signed-off-by: Wei Liu Obviously correct. Reviewed-by: David Vrabel David