All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Hostetler <git@jeffhostetler.com>
To: Jonathan Tan <jonathantanmy@google.com>
Cc: git@vger.kernel.org, gitster@pobox.com, peff@peff.net,
	Jeff Hostetler <jeffhost@microsoft.com>
Subject: Re: [PATCH 1/9] extension.partialclone: introduce partial clone extension
Date: Wed, 8 Nov 2017 15:32:21 -0500	[thread overview]
Message-ID: <515130bd-6fd8-2c53-e935-e811330f8512@jeffhostetler.com> (raw)
In-Reply-To: <20171106111642.696a006e802cf0259098b44f@google.com>



On 11/6/2017 2:16 PM, Jonathan Tan wrote:
> On Mon, 6 Nov 2017 12:32:45 -0500
> Jeff Hostetler <git@jeffhostetler.com> wrote:
> 
>>>> Yes, that is a point I wanted to ask about.  I renamed the
>>>> extensions.partialclone that you created and then I moved your
>>>> remote.<name>.blob-max-bytes setting to be in extensions too.
>>>> Moving it to core.partialclonefilter is fine.
>>>
>>> OK - in that case, it might be easier to just reuse my first patch in
>>> its entirety. "core.partialclonefilter" is not used until the
>>> fetching/cloning part anyway.
>>>
>>
>> Good point.  I'll take a look at refactoring that.
>> If it looks like the result will be mostly/effectively
>> your original patches, I'll let you know and hand part 2
>> back to you.
> 
> Sounds good. I uploaded the result of rebasing my part 2 patches on top
> of your part 1 patches here, if you would like it as a reference:
> 
> https://github.com/jonathantanmy/git/commits/pc20171106
> 

Thanks Jonathan.

I moved my version of part 2 on top of yesterday's part 1.
There are a few changes between my version and yours. Could
you take a quick look at them and see if they make sense?
(I'll spare the mailing list another patch series until after
I attend to the feed back on part 1.)

https://github.com/jeffhostetler/git/commits/core/pc3_p2

Thanks
Jeff


  reply	other threads:[~2017-11-08 20:32 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-02 20:20 [PATCH 0/9] WIP Partial clone part 2: fsck and promisors Jeff Hostetler
2017-11-02 20:20 ` [PATCH 1/9] extension.partialclone: introduce partial clone extension Jeff Hostetler
2017-11-02 22:24   ` Jonathan Tan
2017-11-03 13:57     ` Jeff Hostetler
2017-11-03 18:39       ` Jonathan Tan
2017-11-06 17:32         ` Jeff Hostetler
2017-11-06 19:16           ` Jonathan Tan
2017-11-08 20:32             ` Jeff Hostetler [this message]
2017-11-08 21:51               ` Jonathan Tan
2017-11-08 22:11                 ` Jeff Hostetler
2017-11-16 17:33                 ` Jeff Hostetler
2017-11-02 20:20 ` [PATCH 2/9] fsck: introduce partialclone extension Jeff Hostetler
2017-11-02 20:20 ` [PATCH 3/9] fsck: support refs pointing to promisor objects Jeff Hostetler
2017-11-02 20:20 ` [PATCH 4/9] fsck: support referenced " Jeff Hostetler
2017-11-02 20:20 ` [PATCH 5/9] fsck: support promisor objects as CLI argument Jeff Hostetler
2017-11-02 20:20 ` [PATCH 6/9] index-pack: refactor writing of .keep files Jeff Hostetler
2017-11-02 20:20 ` [PATCH 7/9] introduce fetch-object: fetch one promisor object Jeff Hostetler
2017-11-02 20:20 ` [PATCH 8/9] sha1_file: support lazily fetching missing objects Jeff Hostetler
2017-11-02 20:20 ` [PATCH 9/9] gc: do not repack promisor packfiles Jeff Hostetler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=515130bd-6fd8-2c53-e935-e811330f8512@jeffhostetler.com \
    --to=git@jeffhostetler.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jeffhost@microsoft.com \
    --cc=jonathantanmy@google.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.