All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Greear <greearb@candelatech.com>
To: Adrian Chadd <adrian@freebsd.org>
Cc: Robert Shade <robert.shade@gmail.com>,
	Christian Lamparter <chunkeey@googlemail.com>,
	ath9k-devel@venema.h4ckr.net, linux-wireless@vger.kernel.org,
	Marco Fonseca <marco@tampabay.rr.com>
Subject: Re: [ath9k-devel] Auth Packet TX Delay
Date: Tue, 26 Mar 2013 10:45:55 -0700	[thread overview]
Message-ID: <5151DED3.8090009@candelatech.com> (raw)
In-Reply-To: <CAJ-Vmom67dWGVASc-dm03NfG2bWFQ+v6b1UMW7nh1t4Q+j0RJw@mail.gmail.com>

On 03/26/2013 10:33 AM, Adrian Chadd wrote:
> Right. Well, when you reset the FIFO chances are you should walk said
> FIFO queue in the TXQ (not the pending frames, the "hw" frames) and
> requeue each to the hardware.
>
> What I am doing in my EDMA restart routine in FreeBSD:
>
> * (assume TX is stopped, chip is reset, the completed frames are
> already removed from the FIFO queue in the TXQ);
>
> * save the old FIFO count
> * blank the FIFO count
> * walk the FIFO list (NOT the pending list), pushing head pointers
> back into the FIFO - and this will bump the FIFO counter by one each
> time;
> * when I've finished that, compare the FIFO count to the old FIFO
> count - they should match.
>
> I've not looked at the ath9k code in too much depth lately as I've
> been more interested in getting FreeBSD's EDMA code finished (and I
> think it is, woo!); so if you give me an hour or two I'll go do
> another code review and see what pops up.

Ok, I'm happy to test patches.  Last we tried, we could reproduce
the problem very often using lots of stations (32, I think) sending
64kbps or so UDP traffic through an attenuator as we ramp up the
attenuation in 10db steps...

Thanks,
Ben

-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com


WARNING: multiple messages have this Message-ID (diff)
From: Ben Greear <greearb@candelatech.com>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] Auth Packet TX Delay
Date: Tue, 26 Mar 2013 10:45:55 -0700	[thread overview]
Message-ID: <5151DED3.8090009@candelatech.com> (raw)
In-Reply-To: <CAJ-Vmom67dWGVASc-dm03NfG2bWFQ+v6b1UMW7nh1t4Q+j0RJw@mail.gmail.com>

On 03/26/2013 10:33 AM, Adrian Chadd wrote:
> Right. Well, when you reset the FIFO chances are you should walk said
> FIFO queue in the TXQ (not the pending frames, the "hw" frames) and
> requeue each to the hardware.
>
> What I am doing in my EDMA restart routine in FreeBSD:
>
> * (assume TX is stopped, chip is reset, the completed frames are
> already removed from the FIFO queue in the TXQ);
>
> * save the old FIFO count
> * blank the FIFO count
> * walk the FIFO list (NOT the pending list), pushing head pointers
> back into the FIFO - and this will bump the FIFO counter by one each
> time;
> * when I've finished that, compare the FIFO count to the old FIFO
> count - they should match.
>
> I've not looked at the ath9k code in too much depth lately as I've
> been more interested in getting FreeBSD's EDMA code finished (and I
> think it is, woo!); so if you give me an hour or two I'll go do
> another code review and see what pops up.

Ok, I'm happy to test patches.  Last we tried, we could reproduce
the problem very often using lots of stations (32, I think) sending
64kbps or so UDP traffic through an attenuator as we ramp up the
attenuation in 10db steps...

Thanks,
Ben

-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com

  reply	other threads:[~2013-03-26 17:46 UTC|newest]

Thread overview: 74+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-20 18:45 [ath9k-devel] Auth Packet TX Delay Robert Shade
2013-01-15 22:06 ` Robert Shade
2013-01-15 22:06   ` [ath9k-devel] " Robert Shade
2013-01-16 23:09   ` Adrian Chadd
2013-01-16 23:09     ` [ath9k-devel] " Adrian Chadd
2013-01-17  1:00     ` Robert Shade
2013-01-17  1:00       ` [ath9k-devel] " Robert Shade
2013-01-17  3:12       ` Adrian Chadd
2013-01-17  3:12         ` [ath9k-devel] " Adrian Chadd
2013-02-06  2:51         ` Robert Shade
2013-02-06  2:51           ` [ath9k-devel] " Robert Shade
2013-02-06  3:08           ` Adrian Chadd
2013-02-06  3:08             ` [ath9k-devel] " Adrian Chadd
2013-02-06 12:53             ` Robert Shade
2013-02-06 12:53               ` [ath9k-devel] " Robert Shade
2013-02-06 22:58               ` Robert Shade
2013-02-06 22:58                 ` [ath9k-devel] " Robert Shade
2013-02-07  5:06                 ` Adrian Chadd
2013-02-07  5:06                   ` [ath9k-devel] " Adrian Chadd
2013-02-07 16:25                   ` David Littell
2013-02-07 16:25                     ` David Littell
2013-02-07 19:43                   ` Robert Shade
2013-02-07 19:43                     ` [ath9k-devel] " Robert Shade
2013-02-07 21:40                     ` Adrian Chadd
2013-02-07 21:40                       ` [ath9k-devel] " Adrian Chadd
2013-02-08 18:48                       ` Robert Shade
2013-02-08 18:48                         ` [ath9k-devel] " Robert Shade
2013-02-09  7:39                         ` Adrian Chadd
2013-02-09  7:39                           ` [ath9k-devel] " Adrian Chadd
2013-03-24 18:55                           ` Robert Shade
2013-03-24 18:55                             ` [ath9k-devel] " Robert Shade
2013-03-24 21:52                             ` Adrian Chadd
2013-03-24 21:52                               ` [ath9k-devel] " Adrian Chadd
2013-03-24 22:40                               ` Robert Shade
2013-03-24 22:40                                 ` [ath9k-devel] " Robert Shade
2013-03-24 22:58                                 ` Christian Lamparter
2013-03-24 22:58                                   ` [ath9k-devel] " Christian Lamparter
2013-03-25  0:03                                   ` Adrian Chadd
2013-03-25  0:03                                     ` [ath9k-devel] " Adrian Chadd
2013-03-25  2:23                                     ` Adrian Chadd
2013-03-25  2:23                                       ` [ath9k-devel] " Adrian Chadd
2013-03-25 16:12                                       ` Christian Lamparter
2013-03-25 16:12                                         ` [ath9k-devel] " Christian Lamparter
2013-03-25 16:45                                         ` Adrian Chadd
2013-03-25 16:45                                           ` [ath9k-devel] " Adrian Chadd
2013-03-26 12:21                                           ` Robert Shade
2013-03-26 12:21                                             ` [ath9k-devel] " Robert Shade
2013-03-26 13:23                                             ` Robert Shade
2013-03-26 13:23                                               ` [ath9k-devel] " Robert Shade
2013-03-26 16:28                                             ` Adrian Chadd
2013-03-26 16:28                                               ` [ath9k-devel] " Adrian Chadd
2013-03-26 16:29                                               ` Robert Shade
2013-03-26 16:29                                                 ` [ath9k-devel] " Robert Shade
2013-03-26 17:13                                                 ` Ben Greear
2013-03-26 17:13                                                   ` Ben Greear
2013-03-26 17:16                                                   ` Adrian Chadd
2013-03-26 17:16                                                     ` Adrian Chadd
2013-03-26 17:27                                                     ` Ben Greear
2013-03-26 17:27                                                       ` Ben Greear
2013-03-26 17:33                                                       ` Adrian Chadd
2013-03-26 17:33                                                         ` Adrian Chadd
2013-03-26 17:45                                                         ` Ben Greear [this message]
2013-03-26 17:45                                                           ` Ben Greear
2013-03-27  0:55                                                   ` Robert Shade
2013-03-27  0:55                                                     ` Robert Shade
2013-03-27  3:11                                                     ` Robert Shade
2013-03-27  3:11                                                       ` Robert Shade
2013-03-27 16:33                                                       ` Adrian Chadd
2013-03-27 16:33                                                         ` Adrian Chadd
2013-03-26 17:14                                                 ` Adrian Chadd
2013-03-26 17:14                                                   ` [ath9k-devel] " Adrian Chadd
2013-03-26 14:13                                           ` Marco Fonseca
2013-03-26 14:13                                             ` [ath9k-devel] " Marco Fonseca
2013-01-17 18:48 David Littell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5151DED3.8090009@candelatech.com \
    --to=greearb@candelatech.com \
    --cc=adrian@freebsd.org \
    --cc=ath9k-devel@venema.h4ckr.net \
    --cc=chunkeey@googlemail.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=marco@tampabay.rr.com \
    --cc=robert.shade@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.