All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] arm-bsp/image_types_disk_img: do not force 'ext4' FS by default
@ 2020-07-16 11:53 kamil.dziezyk
  2020-07-16 12:02 ` Diego Sueiro
  0 siblings, 1 reply; 5+ messages in thread
From: kamil.dziezyk @ 2020-07-16 11:53 UTC (permalink / raw)
  To: meta-arm; +Cc: nd, Kamil Dziezyk

In some cases user doesn't want to create any file system on a specific partition.

Change-Id: I4596d97b95034952436cfd0a267a3f6ae4c0401d
Signed-off-by: Kamil Dziezyk <kamil.dziezyk@arm.com>
---
 meta-arm-bsp/classes/image_types_disk_img.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta-arm-bsp/classes/image_types_disk_img.bbclass b/meta-arm-bsp/classes/image_types_disk_img.bbclass
index ea7ba86..78cc0d8 100644
--- a/meta-arm-bsp/classes/image_types_disk_img.bbclass
+++ b/meta-arm-bsp/classes/image_types_disk_img.bbclass
@@ -51,7 +51,7 @@ disk_img_createpart() {
     local imagefile="$1"
     local start="$2"
     local size="$3"
-    local fstype="${4:-ext4}"
+    local fstype="${4:-}"
     local content="${5:-}"
     local formatargs=""
 
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] arm-bsp/image_types_disk_img: do not force 'ext4' FS by default
  2020-07-16 11:53 [PATCH] arm-bsp/image_types_disk_img: do not force 'ext4' FS by default kamil.dziezyk
@ 2020-07-16 12:02 ` Diego Sueiro
  2020-07-17 13:14   ` [meta-arm] " Jon Mason
  0 siblings, 1 reply; 5+ messages in thread
From: Diego Sueiro @ 2020-07-16 12:02 UTC (permalink / raw)
  To: meta-arm

On Thu, Jul 16, 2020 at 12:53 PM, Kamil Dziezyk wrote:

>
> In some cases user doesn't want to create any file system on a specific
> partition.
> 
> Change-Id: I4596d97b95034952436cfd0a267a3f6ae4c0401d
> Signed-off-by: Kamil Dziezyk <kamil.dziezyk@arm.com>

Reviewed-by: Diego Sueiro <diego.sueiro@arm.com>

> ---
>  meta-arm-bsp/classes/image_types_disk_img.bbclass | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta-arm-bsp/classes/image_types_disk_img.bbclass
> b/meta-arm-bsp/classes/image_types_disk_img.bbclass
> index ea7ba86..78cc0d8 100644
> --- a/meta-arm-bsp/classes/image_types_disk_img.bbclass
> +++ b/meta-arm-bsp/classes/image_types_disk_img.bbclass
> @@ -51,7 +51,7 @@ disk_img_createpart() {
>      local imagefile="$1"
>      local start="$2"
>      local size="$3"
> -    local fstype="${4:-ext4}"
> +    local fstype="${4:-}"
>      local content="${5:-}"
>      local formatargs=""
>
> -- 
> 2.17.1
> 
>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [meta-arm] [PATCH] arm-bsp/image_types_disk_img: do not force 'ext4' FS by default
  2020-07-16 12:02 ` Diego Sueiro
@ 2020-07-17 13:14   ` Jon Mason
  2020-07-17 13:42     ` Kamil Dziezyk
  0 siblings, 1 reply; 5+ messages in thread
From: Jon Mason @ 2020-07-17 13:14 UTC (permalink / raw)
  To: Diego Sueiro; +Cc: meta-arm

On Thu, Jul 16, 2020 at 05:02:06AM -0700, Diego Sueiro wrote:
> On Thu, Jul 16, 2020 at 12:53 PM, Kamil Dziezyk wrote:
> 
> >
> > In some cases user doesn't want to create any file system on a specific
> > partition.
> > 
> > Change-Id: I4596d97b95034952436cfd0a267a3f6ae4c0401d
> > Signed-off-by: Kamil Dziezyk <kamil.dziezyk@arm.com>
> 
> Reviewed-by: Diego Sueiro <diego.sueiro@arm.com>

Applied to master.

Thanks,
Jon

> 
> > ---
> >  meta-arm-bsp/classes/image_types_disk_img.bbclass | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/meta-arm-bsp/classes/image_types_disk_img.bbclass
> > b/meta-arm-bsp/classes/image_types_disk_img.bbclass
> > index ea7ba86..78cc0d8 100644
> > --- a/meta-arm-bsp/classes/image_types_disk_img.bbclass
> > +++ b/meta-arm-bsp/classes/image_types_disk_img.bbclass
> > @@ -51,7 +51,7 @@ disk_img_createpart() {
> >      local imagefile="$1"
> >      local start="$2"
> >      local size="$3"
> > -    local fstype="${4:-ext4}"
> > +    local fstype="${4:-}"
> >      local content="${5:-}"
> >      local formatargs=""
> >
> > -- 
> > 2.17.1
> > 
> >

> 


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] arm-bsp/image_types_disk_img: do not force 'ext4' FS by default
  2020-07-17 13:14   ` [meta-arm] " Jon Mason
@ 2020-07-17 13:42     ` Kamil Dziezyk
  2020-07-17 19:34       ` [meta-arm] " Jon Mason
  0 siblings, 1 reply; 5+ messages in thread
From: Kamil Dziezyk @ 2020-07-17 13:42 UTC (permalink / raw)
  To: meta-arm

[-- Attachment #1: Type: text/plain, Size: 42 bytes --]

Can you backport this change to dunfell?

[-- Attachment #2: Type: text/html, Size: 1085 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [meta-arm] [PATCH] arm-bsp/image_types_disk_img: do not force 'ext4' FS by default
  2020-07-17 13:42     ` Kamil Dziezyk
@ 2020-07-17 19:34       ` Jon Mason
  0 siblings, 0 replies; 5+ messages in thread
From: Jon Mason @ 2020-07-17 19:34 UTC (permalink / raw)
  To: Kamil Dziezyk; +Cc: meta-arm

On Fri, Jul 17, 2020 at 06:42:36AM -0700, Kamil Dziezyk wrote:
> Can you backport this change to dunfell?

Done.


> 


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2020-07-17 19:34 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-16 11:53 [PATCH] arm-bsp/image_types_disk_img: do not force 'ext4' FS by default kamil.dziezyk
2020-07-16 12:02 ` Diego Sueiro
2020-07-17 13:14   ` [meta-arm] " Jon Mason
2020-07-17 13:42     ` Kamil Dziezyk
2020-07-17 19:34       ` [meta-arm] " Jon Mason

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.