From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Axel Lin <axel.lin@ingics.com>
Cc: Thierry Reding <thierry.reding@avionic-design.de>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] pwm: twl: Return proper error if twl6030_pwm_enable() fails
Date: Tue, 2 Apr 2013 09:14:54 +0200 [thread overview]
Message-ID: <515A856E.1000402@ti.com> (raw)
In-Reply-To: <1364742450.3834.8.camel@phoenix>
On 03/31/2013 05:07 PM, Axel Lin wrote:
> Return proper error instead of 0 if twl6030_pwm_enable() fails.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> ---
> drivers/pwm/pwm-twl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pwm/pwm-twl.c b/drivers/pwm/pwm-twl.c
> index ee7fa5d..2782001 100644
> --- a/drivers/pwm/pwm-twl.c
> +++ b/drivers/pwm/pwm-twl.c
> @@ -248,7 +248,7 @@ static int twl6030_pwm_enable(struct pwm_chip *chip, struct pwm_device *pwm)
> twl->twl6030_toggle3 = val;
> out:
> mutex_unlock(&twl->mutex);
> - return 0;
> + return ret;
> }
>
> static void twl6030_pwm_disable(struct pwm_chip *chip, struct pwm_device *pwm)
>
--
Péter
next prev parent reply other threads:[~2013-04-02 7:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-31 15:07 [PATCH] pwm: twl: Return proper error if twl6030_pwm_enable() fails Axel Lin
2013-04-02 7:14 ` Peter Ujfalusi [this message]
2013-04-02 9:40 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=515A856E.1000402@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=axel.lin@ingics.com \
--cc=linux-kernel@vger.kernel.org \
--cc=thierry.reding@avionic-design.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.