From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adnan Ali Date: Tue, 02 Apr 2013 18:13:51 +0100 Subject: [U-Boot] [PATCH v11 2/2] Enable btrfs support in mx53loco config In-Reply-To: <515B0F70.2070502@ti.com> References: <1364912259-15488-1-git-send-email-adnan.ali@codethink.co.uk> <1364912259-15488-2-git-send-email-adnan.ali@codethink.co.uk> <515AFB8E.2030801@codethink.co.uk> <515B0F70.2070502@ti.com> Message-ID: <515B11CF.3040004@codethink.co.uk> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 02/04/13 18:03, Tom Rini wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > On 04/02/2013 11:52 AM, Robert Nelson wrote: >> On Tue, Apr 2, 2013 at 10:38 AM, Adnan Ali >> wrote: >>> On 02/04/13 16:19, Robert Nelson wrote: >>>> On Tue, Apr 2, 2013 at 9:17 AM, Adnan Ali >>>> wrote: >>>>> Enable btrfs support in mx53loco config >>>>> >>>>> Signed-off-by: Adnan Ali --- >>>>> include/configs/mx53loco.h | 4 +++- 1 file changed, 3 >>>>> insertions(+), 1 deletion(-) >>>>> >>>>> diff --git a/include/configs/mx53loco.h >>>>> b/include/configs/mx53loco.h index a4b610f..62e9a76 100644 >>>>> --- a/include/configs/mx53loco.h +++ >>>>> b/include/configs/mx53loco.h @@ -56,6 +56,8 @@ #define >>>>> CONFIG_GENERIC_MMC #define CONFIG_CMD_FAT #define >>>>> CONFIG_CMD_EXT2 +#define CONFIG_CMD_BTR +#define >>>>> CONFIG_CMD_FS_GENERIC #define CONFIG_DOS_PARTITION >>>>> >>>>> /* Eth Configs */ @@ -128,7 +130,7 @@ "mmcroot=/dev/mmcblk0p3 >>>>> rw rootwait\0" \ "mmcargs=setenv bootargs >>>>> console=ttymxc0,${baudrate} root=${mmcroot}\0" \ >>>>> "loadbootscript=" \ - "fatload mmc >>>>> ${mmcdev}:${mmcpart} ${loadaddr} ${script};\0" \ + >>>>> "btrload mmc ${mmcdev}:${mmcpart} ${loadaddr} ${script};\0" >>>>> \ >>>> Instead of changing this to btrload for everyone, wouldn't it >>>> make more sense to use the generic "load" command? As your >>>> already setting "CONFIG_CMD_FS_GENERIC" >>> Well idea of adding that was to enable btrfs and to show its >>> associated commands. Yes you can use generic 'load' command. >>> Defaults was using fatload so i change it to btrload. >> That's perfectly fine for showing the btrfs command's as an RFC >> patch, but if this was heading for mainline as-is, it would be nice >> to use the "load" command instead of moving from one partition >> format that's been default for a couple years to a new format with >> less users. (not that I don't like the btrfs format. ;) as i've >> been running it on a few omap boards for a couple years now..) > Exactly. The code needs to be built somewhere, to not be considered > dead code. The next change here, to loadbootscript needs to be done > in a forward-compatible way like 'load' so now it just works for > everyone. Thanks! I will need to send this as separate patch. [snip] Thanks Adnan