From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?ISO-8859-1?Q?Christian_K=F6nig?= Subject: Re: [PATCH 01/10] drm/radeon: UVD doesn't needs VM on SI Date: Wed, 03 Apr 2013 17:29:36 +0200 Message-ID: <515C4AE0.4070204@vodafone.de> References: <1364944719-5175-1-git-send-email-deathsimple@vodafone.de> <1364944719-5175-2-git-send-email-deathsimple@vodafone.de> <20130403144230.GB2010@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1"; Format="flowed" Content-Transfer-Encoding: quoted-printable Return-path: Received: from outgoing.email.vodafone.de (outgoing.email.vodafone.de [139.7.28.128]) by gabe.freedesktop.org (Postfix) with ESMTP id 82831E5CE5 for ; Wed, 3 Apr 2013 08:29:42 -0700 (PDT) In-Reply-To: <20130403144230.GB2010@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Jerome Glisse Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org Am 03.04.2013 16:42, schrieb Jerome Glisse: > On Wed, Apr 03, 2013 at 01:18:30AM +0200, Christian K=F6nig wrote: >> Signed-off-by: Christian K=F6nig >> --- >> drivers/gpu/drm/radeon/radeon_cs.c | 10 +++++----- >> 1 file changed, 5 insertions(+), 5 deletions(-) >> >> diff --git a/drivers/gpu/drm/radeon/radeon_cs.c b/drivers/gpu/drm/radeon= /radeon_cs.c >> index 70d3824..7d66e01 100644 >> --- a/drivers/gpu/drm/radeon/radeon_cs.c >> +++ b/drivers/gpu/drm/radeon/radeon_cs.c >> @@ -241,15 +241,15 @@ int radeon_cs_parser_init(struct radeon_cs_parser = *p, void *data) >> return -EINVAL; >> } >> = >> + if (radeon_cs_get_ring(p, ring, priority)) >> + return -EINVAL; >> + >> /* we only support VM on SI+ */ >> - if ((p->rdev->family >=3D CHIP_TAHITI) && >> - ((p->cs_flags & RADEON_CS_USE_VM) =3D=3D 0)) { >> + if ((p->rdev->asic->ring[p->ring].cs_parse =3D=3D NULL) && >> + ((p->cs_flags & RADEON_CS_USE_VM) =3D=3D 0)) { >> DRM_ERROR("VM required on SI+!\n"); >> return -EINVAL; > What about updating the error message to something more appropriate like > ring %d require virtual memory Good point, going to change it. Christian. > Cheers, > Jerome > >> } >> - >> - if (radeon_cs_get_ring(p, ring, priority)) >> - return -EINVAL; >> } >> = >> /* deal with non-vm */ >> -- = >> 1.7.9.5 >> >> _______________________________________________ >> dri-devel mailing list >> dri-devel@lists.freedesktop.org >> http://lists.freedesktop.org/mailman/listinfo/dri-devel