From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1162813Ab3DEVRT (ORCPT ); Fri, 5 Apr 2013 17:17:19 -0400 Received: from mail-qe0-f46.google.com ([209.85.128.46]:48644 "EHLO mail-qe0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1162724Ab3DEVRR (ORCPT ); Fri, 5 Apr 2013 17:17:17 -0400 Message-ID: <515F3F5C.2090709@gmail.com> Date: Fri, 05 Apr 2013 17:17:16 -0400 From: KOSAKI Motohiro User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:17.0) Gecko/20130307 Thunderbird/17.0.4 MIME-Version: 1.0 To: Naoya Horiguchi CC: linux-mm@kvack.org, Andrew Morton , Mel Gorman , Hugh Dickins , KOSAKI Motohiro , Andi Kleen , Hillf Danton , Michal Hocko , linux-kernel@vger.kernel.org, kosaki.motohiro@gmail.com Subject: Re: [PATCH 05/10] migrate: add hugepage migration code to migrate_pages() References: <1363983835-20184-1-git-send-email-n-horiguchi@ah.jp.nec.com> <1363983835-20184-6-git-send-email-n-horiguchi@ah.jp.nec.com> In-Reply-To: <1363983835-20184-6-git-send-email-n-horiguchi@ah.jp.nec.com> Content-Type: text/plain; charset=ISO-2022-JP Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org (3/22/13 4:23 PM), Naoya Horiguchi wrote: > This patch extends check_range() to handle vma with VM_HUGETLB set. > We will be able to migrate hugepage with migrate_pages(2) after > applying the enablement patch which comes later in this series. > > Note that for larger hugepages (covered by pud entries, 1GB for > x86_64 for example), we simply skip it now. check_range() has largely duplication with mm_walk and it is quirk subset. Instead of, could you replace them to mm_walk and enhance/cleanup mm_walk? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx133.postini.com [74.125.245.133]) by kanga.kvack.org (Postfix) with SMTP id 119346B0126 for ; Fri, 5 Apr 2013 17:17:17 -0400 (EDT) Received: by mail-qe0-f47.google.com with SMTP id w7so2278509qeb.6 for ; Fri, 05 Apr 2013 14:17:17 -0700 (PDT) Message-ID: <515F3F5C.2090709@gmail.com> Date: Fri, 05 Apr 2013 17:17:16 -0400 From: KOSAKI Motohiro MIME-Version: 1.0 Subject: Re: [PATCH 05/10] migrate: add hugepage migration code to migrate_pages() References: <1363983835-20184-1-git-send-email-n-horiguchi@ah.jp.nec.com> <1363983835-20184-6-git-send-email-n-horiguchi@ah.jp.nec.com> In-Reply-To: <1363983835-20184-6-git-send-email-n-horiguchi@ah.jp.nec.com> Content-Type: text/plain; charset=ISO-2022-JP Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Naoya Horiguchi Cc: linux-mm@kvack.org, Andrew Morton , Mel Gorman , Hugh Dickins , KOSAKI Motohiro , Andi Kleen , Hillf Danton , Michal Hocko , linux-kernel@vger.kernel.org, kosaki.motohiro@gmail.com (3/22/13 4:23 PM), Naoya Horiguchi wrote: > This patch extends check_range() to handle vma with VM_HUGETLB set. > We will be able to migrate hugepage with migrate_pages(2) after > applying the enablement patch which comes later in this series. > > Note that for larger hugepages (covered by pud entries, 1GB for > x86_64 for example), we simply skip it now. check_range() has largely duplication with mm_walk and it is quirk subset. Instead of, could you replace them to mm_walk and enhance/cleanup mm_walk? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org