All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dominique Dumont <dod@debian.org>
To: Salvatore Bonaccorso <carnil@debian.org>
Cc: "Alex Deucher" <alexander.deucher@amd.com>,
	"Sasha Levin" <sashal@kernel.org>,
	"David Airlie" <airlied@linux.ie>,
	"Maling list - DRI developers" <dri-devel@lists.freedesktop.org>,
	"Pan, Xinhui" <Xinhui.Pan@amd.com>,
	LKML <linux-kernel@vger.kernel.org>,
	1005005@bugs.debian.org, "Luben Tuikov" <luben.tuikov@amd.com>,
	"amd-gfx list" <amd-gfx@lists.freedesktop.org>,
	"Evan Quan" <evan.quan@amd.com>,
	"Christian König" <christian.koenig@amd.com>
Subject: Re: Regression from 3c196f056666 ("drm/amdgpu: always reset the asic in suspend (v2)") on suspend?
Date: Sun, 20 Feb 2022 16:48:43 +0100	[thread overview]
Message-ID: <5164225.DI6hChFYCN@ylum> (raw)
In-Reply-To: <CADnq5_MfR99OhjumQESCO7Oq+JVOHOVgyVQHX4FpGFDnPu6CyQ@mail.gmail.com>

On Monday, 14 February 2022 22:52:27 CET Alex Deucher wrote:
> Does the system actually suspend?  

Not really. The screens looks like it's going to suspend, but it does come 
back after 10s or so. The light mounted in the middle of the power button does 
not switch off.

> Is this system S0i3 or regular S3?

I'm not sure how to check that. After a bit of reading on the Internet [1], I 
hope that the following information answers that question. Please get back to 
me if that's not the case.

Looks like my system supports both Soi3 and S3

$ cat /sys/power/state 
freeze mem disk

I get the same result running these 2 commands as root:
# echo freeze > /sys/power/state
# echo mem > /sys/power/state

>  Does this patch help by any chance?
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?i
> d=e55a3aea418269266d84f426b3bd70794d3389c8

yes, with this patch:
- the suspend issue is solved
- kernel logs no longer show messages like "failed to send message" or 
"*ERROR* suspend of IP block <powerplay> failed" while suspending

All the best

[1] https://01.org/blogs/rzhang/2015/best-practice-debug-linux-suspend/
hibernate-issues



WARNING: multiple messages have this Message-ID (diff)
From: Dominique Dumont <dod@debian.org>
To: Salvatore Bonaccorso <carnil@debian.org>
Cc: "Sasha Levin" <sashal@kernel.org>,
	"amd-gfx list" <amd-gfx@lists.freedesktop.org>,
	"David Airlie" <airlied@linux.ie>,
	"Pan, Xinhui" <Xinhui.Pan@amd.com>,
	LKML <linux-kernel@vger.kernel.org>,
	"Maling list - DRI developers" <dri-devel@lists.freedesktop.org>,
	"Luben Tuikov" <luben.tuikov@amd.com>,
	1005005@bugs.debian.org,
	"Alex Deucher" <alexander.deucher@amd.com>,
	"Evan Quan" <evan.quan@amd.com>,
	"Christian König" <christian.koenig@amd.com>
Subject: Re: Regression from 3c196f056666 ("drm/amdgpu: always reset the asic in suspend (v2)") on suspend?
Date: Sun, 20 Feb 2022 16:48:43 +0100	[thread overview]
Message-ID: <5164225.DI6hChFYCN@ylum> (raw)
In-Reply-To: <CADnq5_MfR99OhjumQESCO7Oq+JVOHOVgyVQHX4FpGFDnPu6CyQ@mail.gmail.com>

On Monday, 14 February 2022 22:52:27 CET Alex Deucher wrote:
> Does the system actually suspend?  

Not really. The screens looks like it's going to suspend, but it does come 
back after 10s or so. The light mounted in the middle of the power button does 
not switch off.

> Is this system S0i3 or regular S3?

I'm not sure how to check that. After a bit of reading on the Internet [1], I 
hope that the following information answers that question. Please get back to 
me if that's not the case.

Looks like my system supports both Soi3 and S3

$ cat /sys/power/state 
freeze mem disk

I get the same result running these 2 commands as root:
# echo freeze > /sys/power/state
# echo mem > /sys/power/state

>  Does this patch help by any chance?
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?i
> d=e55a3aea418269266d84f426b3bd70794d3389c8

yes, with this patch:
- the suspend issue is solved
- kernel logs no longer show messages like "failed to send message" or 
"*ERROR* suspend of IP block <powerplay> failed" while suspending

All the best

[1] https://01.org/blogs/rzhang/2015/best-practice-debug-linux-suspend/
hibernate-issues



  reply	other threads:[~2022-02-20 15:49 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-12 18:23 Regression from 3c196f056666 ("drm/amdgpu: always reset the asic in suspend (v2)") on suspend? Salvatore Bonaccorso
2022-02-12 18:23 ` Salvatore Bonaccorso
2022-02-12 18:23 ` Salvatore Bonaccorso
2022-02-14 12:17 ` Thorsten Leemhuis
2022-02-14 12:17   ` Thorsten Leemhuis
2022-02-14 12:17   ` Thorsten Leemhuis
2022-02-14 21:52 ` Alex Deucher
2022-02-14 21:52   ` Alex Deucher
2022-02-20 15:48   ` Dominique Dumont [this message]
2022-02-20 15:48     ` Dominique Dumont
2022-02-20 18:03     ` Eric Valette
2022-02-20 18:03       ` Eric Valette
2022-02-21 14:16       ` Alex Deucher
2022-02-21 14:16         ` Alex Deucher
2022-03-21  8:57         ` Thorsten Leemhuis
2022-03-21  8:57           ` Thorsten Leemhuis
2022-03-21  8:57           ` Thorsten Leemhuis
2022-03-21 12:07           ` Éric Valette
2022-03-21 12:07             ` Éric Valette
2022-03-21 12:07             ` Éric Valette
2022-03-21 14:30             ` Thorsten Leemhuis
2022-03-21 14:30               ` Thorsten Leemhuis
2022-03-21 14:30               ` Thorsten Leemhuis
2022-03-24 14:39               ` Regression from 3c196f056666 ("drm/amdgpu: always reset the asic in suspend (v2)") on suspend? #forregzbot Thorsten Leemhuis
2022-03-21 18:49           ` Regression from 3c196f056666 ("drm/amdgpu: always reset the asic in suspend (v2)") on suspend? Dominique Dumont
2022-03-21 18:49             ` Dominique Dumont
2022-03-21 18:49             ` Dominique Dumont
2022-03-21 19:00             ` Thorsten Leemhuis
2022-03-21 19:00               ` Thorsten Leemhuis
2022-03-21 19:00               ` Thorsten Leemhuis
2022-03-21 19:09             ` Bug#1005005: " Diederik de Haas
2022-03-21 19:09               ` Diederik de Haas
2022-03-21 19:09               ` Diederik de Haas
2022-02-15  3:07 ` Quan, Evan
2022-02-15  3:07   ` Quan, Evan
2022-02-15  3:07   ` Quan, Evan
2022-02-24 12:22 Éric Valette
2022-02-24 12:22 ` Éric Valette

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5164225.DI6hChFYCN@ylum \
    --to=dod@debian.org \
    --cc=1005005@bugs.debian.org \
    --cc=Xinhui.Pan@amd.com \
    --cc=airlied@linux.ie \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=carnil@debian.org \
    --cc=christian.koenig@amd.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=evan.quan@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luben.tuikov@amd.com \
    --cc=sashal@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.