From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:34301)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1UPc03-000686-6I
	for qemu-devel@nongnu.org; Tue, 09 Apr 2013 13:06:28 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1UPc01-0001aA-6N
	for qemu-devel@nongnu.org; Tue, 09 Apr 2013 13:06:26 -0400
Received: from mx1.redhat.com ([209.132.183.28]:61158)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1UPc00-0001Zw-UI
	for qemu-devel@nongnu.org; Tue, 09 Apr 2013 13:06:25 -0400
Message-ID: <51644A6D.7030003@redhat.com>
Date: Tue, 09 Apr 2013 19:05:49 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1365476681-31593-1-git-send-email-mrhines@linux.vnet.ibm.com>
	<1365476681-31593-2-git-send-email-mrhines@linux.vnet.ibm.com>
In-Reply-To: <1365476681-31593-2-git-send-email-mrhines@linux.vnet.ibm.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC PATCH RDMA support v5: 01/12] ./configure
 with and without --enable-rdma
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: mrhines@linux.vnet.ibm.com
Cc: aliguori@us.ibm.com, mst@redhat.com, qemu-devel@nongnu.org, owasserm@redhat.com, abali@us.ibm.com, mrhines@us.ibm.com, gokul@us.ibm.com

Il 09/04/2013 05:04, mrhines@linux.vnet.ibm.com ha scritto:
> +if test "$rdma" = "yes" ; then
> +  cat > $TMPC <<EOF
> +#include <rdma/rdma_cma.h>
> +int main(void) { return 0; }
> +EOF
> +  rdma_libs="-lrdmacm -libverbs"
> +  if ! compile_prog "" "$rdma_libs" ; then
> +      feature_not_found "rdma"
> +  fi
> +    

Please enable this by default, or it will bitrot.

The test should be like this:

if test "$rdma" != "no" ; then
  cat > $TMPC << EOF
...
EOF
  rdma_libs="-lrdmacm -libverbs"
  if compile_prog "-Werror" "$rdma_libs" ; then
    rdma="yes"
    libs_softmmu="$libs_softmmu $rdma_libs"
  else
    if test "$rdma" = "yes" ; then
      feature_not_found "rdma"
    fi
    rdma="no"
  fi
fi


...

if test "$rdma" = "yes" ; then
  echo "CONFIG_RDMA=y" >> $config_host_mak
fi