From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:50724) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UPcuo-0005Kk-On for qemu-devel@nongnu.org; Tue, 09 Apr 2013 14:05:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UPcuk-00060p-Mq for qemu-devel@nongnu.org; Tue, 09 Apr 2013 14:05:06 -0400 Received: from e8.ny.us.ibm.com ([32.97.182.138]:45177) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UPcuk-0005yR-IT for qemu-devel@nongnu.org; Tue, 09 Apr 2013 14:05:02 -0400 Received: from /spool/local by e8.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 9 Apr 2013 14:04:59 -0400 Received: from d01relay05.pok.ibm.com (d01relay05.pok.ibm.com [9.56.227.237]) by d01dlp01.pok.ibm.com (Postfix) with ESMTP id 10B6838C8065 for ; Tue, 9 Apr 2013 14:04:36 -0400 (EDT) Received: from d01av03.pok.ibm.com (d01av03.pok.ibm.com [9.56.224.217]) by d01relay05.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r39I4U05343852 for ; Tue, 9 Apr 2013 14:04:30 -0400 Received: from d01av03.pok.ibm.com (loopback [127.0.0.1]) by d01av03.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r39I4Sjp008339 for ; Tue, 9 Apr 2013 15:04:30 -0300 Message-ID: <51645829.8050207@linux.vnet.ibm.com> Date: Tue, 09 Apr 2013 14:04:25 -0400 From: "Michael R. Hines" MIME-Version: 1.0 References: <1365476681-31593-1-git-send-email-mrhines@linux.vnet.ibm.com> <1365476681-31593-8-git-send-email-mrhines@linux.vnet.ibm.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH RDMA support v5: 07/12] additional savevm.c accessors for RDMA List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: aliguori@us.ibm.com, mst@redhat.com, qemu-devel@nongnu.org, owasserm@redhat.com, abali@us.ibm.com, mrhines@us.ibm.com, gokul@us.ibm.com, pbonzini@redhat.com On 04/09/2013 01:31 PM, Peter Maydell wrote: > On 9 April 2013 04:04, wrote: >> From: "Michael R. Hines" >> >> 1. qemu_file_ops_are() >> 2. qemu_file_update_position() (for f->pos) >> >> Also need to be here: >> rdma_read_ops >> rdma_write_ops My apologies..... will do =) > Do you think you could try to expand on your commit messages > a bit? The idea is that a commit message should generally > give an overview of the patch including rationale; it should > be reasonably meaningful if you look only at the commit > message and not the patch itself. This one has a very > abbreviated description of the "what" and is missing any > kind of "why". > > thanks > -- PMM >