On 04/11/2013 11:22 AM, Mylene Josserand wrote:
> Le 11/04/2013 10:39, Marc Kleine-Budde a écrit :
>> On 04/11/2013 10:04 AM, Mylene Josserand wrote:
>>>>> root@navocap:~# ifconfig can0 up
>>>>> genirq: Threaded irq requested with handler=NULL and !ONESHOT for irq 201
>>>>> mcp251x spi0.0: failed to acquire irq 201
>>>>
>>>> It's a bug in the driver....which was introduced in v3.5[1]. I'm looking
>>>> for a fix.
>>>>
>>>> Marc
>>>>
>>>> [1] 1c6c695 genirq: Reject bogus threaded irq requests
>>>>
>>>
>>> Okay.
>>>
>>> In this
>>> http://markmail.org/thread/uc2adurel247yitp#query:+page:1+mid:uc2adurel247yitp+state:results
>>> and this
>>> http://www.raspberrypi.org/phpBB3/viewtopic.php?f=44&t=7027&start=150
>>> posts, they set the irq_flags to IRQF_ONESHOT.
>>>
>>> I have tested it and I did not have the error anymore. Maybe it is not a
>>> good way to fix that ? (I don't know what is a "one shot" IRQ) but in
>>> case it could help.
>>> However, it did not fix my static-mcp251x boot hang.
>>
>> Can you test my patch and give me a Tested-by?
>>
>> Marc
>>
> 
> I tested your patch and it works ! (As module), I can UP the can 
> interface and set an IP adress. I did not test much (cansend / candump, 
> ...).

Err... don't set IP addresses on CAN interfaces, that's wrong.

> Sorry, it is the first time I take part of a kernel patch (thank you for 
> that !) so I don't know what the "procedure" to give you a "Tested-by" ? :)

Please do a "real test" and and send and receive some 10k frames. Reply
to the patch and say something like:

"I've tested your patch and successfully send and received 10000
CAN-Frames. You can add my Tested-by: Mylene Josserand
<Mylene.Josserand@navocap.com>"

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |