From: Fenglin Wu <quic_fenglinw@quicinc.com>
To: Rob Herring <robh@kernel.org>
Cc: <devicetree@vger.kernel.org>, <collinsd@codeaurora.org>,
<linux-kernel@vger.kernel.org>, Andy Gross <agross@kernel.org>,
"Subbaraman Narayanamurthy" <quic_subbaram@quicinc.com>,
<subbaram@codeaurora.org>, <sboyd@kernel.org>,
Rob Herring <robh+dt@kernel.org>, <maz@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
<linux-arm-msm@vger.kernel.org>, <tglx@linutronix.de>
Subject: Re: [PATCH v4 11/11] dt-bindings: convert qcom,spmi-pmic-arb binding to YAML format
Date: Wed, 22 Dec 2021 07:41:34 +0800 [thread overview]
Message-ID: <517655ce-e4b2-809d-3244-25ab25128b65@quicinc.com> (raw)
In-Reply-To: <1640085064.276534.1014103.nullmailer@robh.at.kernel.org>
On 2021/12/21 19:11, Rob Herring wrote:
> On Tue, 21 Dec 2021 15:20:09 +0800, Fenglin Wu wrote:
>> Convert the SPMI PMIC arbiter documentation to JSON/yaml.
>>
>> Signed-off-by: Fenglin Wu <quic_fenglinw@quicinc.com>
>> ---
>> .../bindings/spmi/qcom,spmi-pmic-arb.txt | 67 ----------
>> .../bindings/spmi/qcom,spmi-pmic-arb.yaml | 146 +++++++++++++++++++++
>> 2 files changed, 146 insertions(+), 67 deletions(-)
>> delete mode 100644 Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.txt
>> create mode 100644 Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.yaml
>>
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.example.dt.yaml: spmi@fc4cf000: reg: [[4232900608, 4096], [4232884224, 4096], [4232880128, 4096]] is too long
> From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/spmi/spmi.yaml
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.example.dt.yaml: spmi@fc4cf000: reg: [[4232900608, 4096], [4232884224, 4096], [4232880128, 4096]] is too long
> From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.yaml
I re-based the change on the tip of spmi-next project which has this
change included:
https://lore.kernel.org/all/20211119034613.32489-2-james.lo@mediatek.com/
With it, the constraint should be removed and this warning/error won't
be seen.
> doc reference errors (make refcheckdocs):
> Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt: Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.txt
>
> See https://patchwork.ozlabs.org/patch/1571409
>
> This check can fail if there are any dependencies. The base for a patch
> series is generally the most recent rc1.
>
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
>
> pip3 install dtschema --upgrade
>
> Please check and re-submit.
>
next prev parent reply other threads:[~2021-12-21 23:41 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-21 7:19 [PATCH v4 00/11] A bunch of fix and optimization patches in spmi-pmic-arb.c Fenglin Wu
2021-12-21 7:19 ` [PATCH v4 01/11] spmi: pmic-arb: add a print in cleanup_irq Fenglin Wu
2021-12-21 7:20 ` [PATCH v4 02/11] spmi: pmic-arb: handle spurious interrupt Fenglin Wu
2021-12-21 7:20 ` [PATCH v4 03/11] spmi: pmic-arb: do not ack and clear peripheral interrupts in cleanup_irq Fenglin Wu
2021-12-21 7:20 ` [PATCH v4 04/11] spmi: pmic-arb: check apid against limits before calling irq handler Fenglin Wu
2021-12-21 7:20 ` [PATCH v4 05/11] spmi: pmic-arb: add support to dispatch interrupt based on IRQ status Fenglin Wu
2021-12-21 7:20 ` [PATCH v4 06/11] spmi: pmic-arb: correct duplicate APID to PPID mapping logic Fenglin Wu
2021-12-21 7:20 ` [PATCH v4 07/11] spmi: pmic-arb: block access for invalid PMIC arbiter v5 SPMI writes Fenglin Wu
2021-12-21 7:20 ` [PATCH v4 08/11] bindings: spmi: spmi-pmic-arb: mark interrupt properties as optional Fenglin Wu
2021-12-21 15:13 ` Rob Herring
2021-12-22 0:48 ` Fenglin Wu
2021-12-21 7:20 ` [PATCH v4 09/11] spmi: pmic-arb: make interrupt support optional Fenglin Wu
2021-12-21 7:20 ` [PATCH v4 10/11] spmi: pmic-arb: increase SPMI transaction timeout delay Fenglin Wu
2021-12-21 7:20 ` [PATCH v4 11/11] dt-bindings: convert qcom,spmi-pmic-arb binding to YAML format Fenglin Wu
2021-12-21 11:11 ` Rob Herring
2021-12-21 23:41 ` Fenglin Wu [this message]
2021-12-21 14:42 ` Rob Herring
2021-12-22 0:45 ` Fenglin Wu
2022-01-07 7:03 ` Fenglin Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=517655ce-e4b2-809d-3244-25ab25128b65@quicinc.com \
--to=quic_fenglinw@quicinc.com \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=collinsd@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=quic_subbaram@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=subbaram@codeaurora.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.