From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:36995) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UZqbV-0007R5-UG for qemu-devel@nongnu.org; Tue, 07 May 2013 18:43:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UZqbU-0000R7-JA for qemu-devel@nongnu.org; Tue, 07 May 2013 18:43:25 -0400 Received: from mout.web.de ([212.227.17.12]:54356) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UZqbU-0000Qo-92 for qemu-devel@nongnu.org; Tue, 07 May 2013 18:43:24 -0400 Message-ID: <5189836B.2080000@web.de> Date: Wed, 08 May 2013 00:42:51 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <1361367806-4599-1-git-send-email-aliguori@us.ibm.com> <1361367806-4599-10-git-send-email-aliguori@us.ibm.com> <5127B788.40701@siemens.com> <5127BBC1.5070607@siemens.com> <512B7B8B.1000402@siemens.com> <87zjys9zcv.fsf@codemonkey.ws> <512B86E7.80603@siemens.com> <514F40A2.6000202@web.de> In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="----enig2VKOROQXLMNGANLIQKEGS" Subject: Re: [Qemu-devel] [PATCH v2] gtk: Fix accelerator filtering List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jordan Justen , Anthony Liguori Cc: Kevin Wolf , "qemu-devel@nongnu.org" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2VKOROQXLMNGANLIQKEGS Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 2013-05-07 23:03, Jordan Justen wrote: > On Sun, Mar 24, 2013 at 11:06 AM, Jan Kiszka wrote:= >> On 2013-02-25 16:44, Jan Kiszka wrote: >>> On 2013-02-25 16:39, Anthony Liguori wrote: >>>> Jan Kiszka writes: >>>> >>>>> This is in fact very simply: When the input in grabbed, everything >>>>> should be exclusively passed to the guest - except it has our magic= >>>>> CTRL-ALT modifier set. Then let GTK filter out those accels that ar= e in >>>>> use. When checking the modifier state, we just need to filter out N= UM >>>>> and CAPS lock. >>>> >>>> Can you explain what you're fixing? >>> >>> That it's not filtering what it is supposed to. >>> >>>> >>>> We shouldn't hard code modifiers like this. The reason you give >>>> accelerators paths like this is so that they can be overridden by a >>>> user. >>>> >>>> That's why I filtered by path. Once we're running, we shouldn't ass= ume >>>> that accelerators use the modifiers we started with. >>> >>> Your path-based filtering does not work as it uses an unsupported >>> internal function (see my other mail). >>> >>> We can make the modifier configurable via QEMU means (command line >>> parameter, gconfig, whatever). But let's get the basics working first= =2E >> >> The bug still exists, my patch still applies. Unless you have some ide= a >> for a better solution, please apply this for now so that CTRL-q inside= a >> guest doesn't kill more kittens. >=20 > I finally built qemu with gtk support, and in general it seems like a > great improvement over SDL. >=20 > ...except ctrl-q to quit the VM. Why is binding a hotkey to quit a > good idea at all? It seems kind of like attaching your computer's > power to a wall-switch. :) Yeah, this bug should really be fixed in some way before 1.5 is released because GTK will be default. Anthony, what is the status of your experiments with alternative solutions? Jan ------enig2VKOROQXLMNGANLIQKEGS Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iEYEARECAAYFAlGJg2wACgkQitSsb3rl5xT1hwCgm+/P6EGgPwNlIikqN+U2NDkx H1QAoKJwV2g1o+nKq8hAmZCxWDaL0SY9 =rTvH -----END PGP SIGNATURE----- ------enig2VKOROQXLMNGANLIQKEGS--