From: Zhenzhong Duan <zhenzhong.duan@oracle.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Chien Yen <chien.yen@oracle.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Feng Jin <joe.jin@oracle.com>,
Yuval Shaia <yuval.shaia@oracle.com>,
xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH 1/2] xen, libxc: init msix addr/data with value from qemu via hypercall
Date: Wed, 08 May 2013 18:00:23 +0800 [thread overview]
Message-ID: <518A2237.9060709@oracle.com> (raw)
In-Reply-To: <518A397F02000078000D44AE@nat28.tlf.novell.com>
On 2013-05-08 17:39, Jan Beulich wrote:
>>>> On 08.05.13 at 10:17, Zhenzhong Duan<zhenzhong.duan@oracle.com> wrote:
>> Accelerated msix entry is initialized to zero when msixtbl_pt_register is
>> called. This doesn't match the value from qemu side, although pirq may
>> already
>> be mapped and binded in qemu side. Kernel will get wrong value when reading
>> msix info.
>>
>> Signed-off-by: Zhenzhong Duan<zhenzhong.duan@oracle.com>
>> Tested-by: Yuval Shaia<yuval.shaia@oracle.com>
> I appreciate this needing to change, but it is a no-go to expose an
> implementation detail of the hypervisor (number of accelerated
> entries being 3) trough a hypercall interface (and even less so by
> scattering around literal 3-s).
I presume you mean msi_ad[3]. msi_ad[3] is addr_lo, addr_high and data.
Not related to accelerated entries count.
or others?
> Please work towards a different solution, leaving the tool stack
> agnostic to the number of accelerated entries. And if at all
> possible, arrange for the patch to be split into tool stack and
> hypervisor pieces, such that they can be applied independently
> (and in either order).
sure, will do it after above question is clear.
Regards
zduan
next prev parent reply other threads:[~2013-05-08 10:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-08 8:17 [PATCH 1/2] xen, libxc: init msix addr/data with value from qemu via hypercall Zhenzhong Duan
2013-05-08 9:39 ` Jan Beulich
2013-05-08 10:00 ` Zhenzhong Duan [this message]
2013-05-08 12:03 ` Jan Beulich
2013-05-09 3:02 ` Zhenzhong Duan
2013-05-09 19:05 ` Jan Beulich
2013-05-10 2:49 ` Zhenzhong Duan
2013-05-10 6:37 ` Jan Beulich
2013-05-10 7:39 ` Zhenzhong Duan
2013-05-10 7:55 ` Jan Beulich
2013-05-10 8:22 ` Zhenzhong Duan
2013-05-10 19:03 ` Is: Telling QEMU to re-use PIRQ value Was: " Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=518A2237.9060709@oracle.com \
--to=zhenzhong.duan@oracle.com \
--cc=JBeulich@suse.com \
--cc=chien.yen@oracle.com \
--cc=joe.jin@oracle.com \
--cc=konrad.wilk@oracle.com \
--cc=xen-devel@lists.xen.org \
--cc=yuval.shaia@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.