From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jan Beulich" Subject: Re: [PATCH 1/2] xen, libxc: init msix addr/data with value from qemu via hypercall Date: Wed, 08 May 2013 10:39:42 +0100 Message-ID: <518A397F02000078000D44AE@nat28.tlf.novell.com> References: <518A0A15.60301@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <518A0A15.60301@oracle.com> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: zhenzhong.duan@oracle.com Cc: Chien Yen , Konrad Rzeszutek Wilk , Feng Jin , Yuval Shaia , xen-devel List-Id: xen-devel@lists.xenproject.org >>> On 08.05.13 at 10:17, Zhenzhong Duan wrote: > Accelerated msix entry is initialized to zero when msixtbl_pt_register is > called. This doesn't match the value from qemu side, although pirq may > already > be mapped and binded in qemu side. Kernel will get wrong value when reading > msix info. > > Signed-off-by: Zhenzhong Duan > Tested-by: Yuval Shaia I appreciate this needing to change, but it is a no-go to expose an implementation detail of the hypervisor (number of accelerated entries being 3) trough a hypercall interface (and even less so by scattering around literal 3-s). Please work towards a different solution, leaving the tool stack agnostic to the number of accelerated entries. And if at all possible, arrange for the patch to be split into tool stack and hypervisor pieces, such that they can be applied independently (and in either order). Jan