All of lore.kernel.org
 help / color / mirror / Atom feed
From: Clemens Ladisch <clemens@ladisch.de>
To: David Henningsson <david.henningsson@canonical.com>
Cc: rex.tsai@canonical.com,
	"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>
Subject: Re: TLV question - ranges not in volume order
Date: Wed, 08 May 2013 14:09:31 +0200	[thread overview]
Message-ID: <518A407B.3070802@ladisch.de> (raw)
In-Reply-To: <518A3545.8000809@canonical.com>

David Henningsson wrote:
> I recently came across a strange ASoC volume control. In this case,
> the values are not in volume order, i e, the control is declared
> something like below.
>
> However alsamixer seems not to handle this "reordering" correctly. My
> question is if this is something that should be fixed in alsamixer (or
> possibly alsa-lib?), or does one need to write some kind of mapping
> table in the kernel, just to make something come in volume order to
> userspace?

Items in a DB_RANGE container must be ordered by their values *and* by
their dB values.  This implies that larger values must correspond with
larger dB values, whis is also required for all other mixer controls.

If the register values are unordered, the driver must reorder them.

> static const unsigned int tlv[] = {
>         TLV_DB_RANGE_HEAD(8),

This should be rewritten as:

static const DECLARE_TLV_DB_RANGE(tlv,
	0, 0, TLV_DB_SCALE_ITEM(-100, 0, 1),
	...
);


Regards,
Clemens

  reply	other threads:[~2013-05-08 12:09 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-08 11:21 TLV question - ranges not in volume order David Henningsson
2013-05-08 12:09 ` Clemens Ladisch [this message]
2013-05-08 12:14   ` Takashi Iwai
2013-05-08 13:33     ` David Henningsson
2013-05-08 13:44       ` Takashi Iwai
2013-05-09 10:12 ` Mark Brown
2013-05-10  6:55   ` David Henningsson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=518A407B.3070802@ladisch.de \
    --to=clemens@ladisch.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=david.henningsson@canonical.com \
    --cc=rex.tsai@canonical.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.