From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michal Kazior Date: Thu, 9 May 2013 09:22:37 +0200 Subject: [ath9k-devel] [RFT] ath10k: retry target reset In-Reply-To: <87sj1wy71p.fsf@kamboji.qca.qualcomm.com> References: <87wqrhcqxq.fsf@kamboji.qca.qualcomm.com> <1367826431-643-1-git-send-email-michal.kazior@tieto.com> <87sj1wy71p.fsf@kamboji.qca.qualcomm.com> Message-ID: <518B4EBD.1080703@tieto.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ath9k-devel@lists.ath9k.org On 09/05/13 08:57, Kalle Valo wrote: > Michal Kazior writes: > >> Sometimes the device just won't reset cleanly >> without retrying. This seems to depend on the host >> hardware. >> >> Signed-off-by: Michal Kazior >> --- >> >> I can't reproduce the issue on my hw. Can someone >> confirm if this fixes the problem? > > If you are referencing to the crash I reported to you privately, I have > seen that problem only once and haven't been able to reproduce since. So > I can't really test this patch. Yes. This is both fortunate, and unfortunate :) The patch is actually my best guess what that issue might've been related to. > You have same warnings messages in different places now. I recommend > adding "..for start" and "...for reset", or something like that, to > exactly identify the warning location. Example: > > ath10k_warn("target did not wake up for reset\n"); Good catch. Thanks! -- Pozdrawiam / Best regards, Michal Kazior.