From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Jan Beulich" <JBeulich@suse.com>
Subject: Re: [PATCH 16/17] PVH xen: elf and iommu related
 changes to prep for dom0 PVH
Date: Tue, 14 May 2013 07:56:47 +0100
Message-ID: <5191FC4F02000078000D5D43@nat28.tlf.novell.com>
References: <1366752366-16594-1-git-send-email-mukesh.rathor@oracle.com>
	<1366752366-16594-17-git-send-email-mukesh.rathor@oracle.com>
	<5177BECD02000078000D0413@nat28.tlf.novell.com>
	<20130513181640.08b012a7@mantra.us.oracle.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20130513181640.08b012a7@mantra.us.oracle.com>
Content-Disposition: inline
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Mukesh Rathor <mukesh.rathor@oracle.com>
Cc: xen-devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

>>> On 14.05.13 at 03:16, Mukesh Rathor <mukesh.rathor@oracle.com> wrote:
> On Wed, 24 Apr 2013 10:15:25 +0100
> "Jan Beulich" <JBeulich@suse.com> wrote:
> 
>> >>> On 23.04.13 at 23:26, Mukesh Rathor <mukesh.rathor@oracle.com>
>> >>> wrote:
>> >  
>> > -static int elf_load_image(void *dst, const void *src, uint64_t
>> > filesz, uint64_t memsz) +extern void __init
>> > early_pvh_copy_or_zero(unsigned long dest, char *src,
>> > +                                          int len, unsigned long
>> > v_start);
>> 
>> This needs to be put in a header included both here and at the
>> producer side.
>> 
>> Also, if you need to pass v_start around just to pass it back to
>> this function, you could as well store it in a static variable in
>> domain_build.c, and leave all of these functions untouched.
> 
> Actually, elf_load_image() <-- elf_load_binary() needs to know if it's 
> PVH domain, so I'd need to change it to pass is_pvh_domain anyways. 

But the single place where it's being looked at for purposes other
than forwarding to the next function is a pretty odd hack anyway.

> I could check for idle_domain in elf_load_binary() and assume PVH dom0
> construct, since for other callers, current should never be idle domain,
> but, that seems pretty hacky... 

Using v_start being (non-)zero as a flag to tell pv from pvh isn't
much less of a hack.

> So, I could either leave it as is with v_start being passed, or make
> v_start static and pass is_pvh_domain flag. Please LMK.

In the end I wonder whether for all this special casing a cleaner
implementation can't be found.

Jan