From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Egger Subject: Re: [PATCH] Make sure to use tools as found by configure Date: Tue, 14 May 2013 11:09:51 +0200 Message-ID: <5191FF5F.4070000@amazon.de> References: <518CE139.6080701@amazon.de> <20130510171032.GB10713@u109add4315675089e695.ant.amazon.com> <1368438711.537.21.camel@zakaz.uk.xensource.com> <20130513203219.GA6716@u109add4315675089e695.ant.amazon.com> <1368521063.537.128.camel@zakaz.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1368521063.537.128.camel@zakaz.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: Matt Wilson , xen-devel List-Id: xen-devel@lists.xenproject.org On 14.05.13 10:44, Ian Campbell wrote: > On Mon, 2013-05-13 at 21:32 +0100, Matt Wilson wrote: >> On Mon, May 13, 2013 at 10:51:51AM +0100, Ian Campbell wrote: >>> On Fri, 2013-05-10 at 18:10 +0100, Matt Wilson wrote: >>>> On Fri, May 10, 2013 at 01:59:53PM +0200, Christoph Egger wrote: >>>>> >>>>> commit 7172e6e0020328d14638a0bbb66a52c905cb4b0b >>>>> Author: Christoph Egger >>>>> Date: Thu Feb 7 14:29:19 2013 +0000 >>>>> >>>>> Make sure to use tools as found by configure. >>>>> Fold inclusion of Tools.mk into toplevel Config.mk. >>>>> >>>>> Signed-off-by: Christoph Egger >>>>> Reviewed-by: Matthew Wilson >>>> >>>> To be clear, I Nack'ed this in review and gave two options: >>> >>> I was about to query this, thanks for clarifying. >>> >>> Christoph, please be more careful in future not to misrepresent peoples >>> review. >>> >>> In general I would think it a good idea if Reviewed-by tags are posted >>> publicly by the Reviewer on xen-devel, even if the review was carried >>> out internally prior to posting, this would help avoid this sort of >>> issue. Not a rule I don't think, but would help avoid mistakes... >> >> I think it could help avoid mistakes, but it might cause some >> complications. I asked Christoph to post patches with the appropriate >> Reviewed-by:/Acked-by:/etc. line > > I'm confused, you Nacked this patch and then asked Christoph to post it > with your Reviewed-by anyway? I think, this is my fault. We agreed on moving the discussion about the patch to xen-devel and not the patch itself. One reason for my mistake is that I didn't understand the design of the build system. I was thinking in: there is a hypervisor and a tools part. But in real there is a hypervisor part, a tools part, a stubdom part and a docs part and each part has its own configure except the hypervisor part. Christoph > >> because I'm in a timezone that's >> fairly far from him and most committers. I sometimes get behind on >> xen-devel mail and it's possible that a committer might commit a >> posted patch before I reply on the list, and we'd lose a valuable bit >> of audit trail in the history. > > I'm not sure what you are worried about here, we could always revert if > when you catch up you aren't happy with the commit. > > Ian. > >