All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Jun Nakajima <jun.nakajima@intel.com>
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH v3 13/13] nEPT: Inject EPT violation/misconfigration
Date: Tue, 14 May 2013 14:41:10 +0200	[thread overview]
Message-ID: <519230E6.8080500@redhat.com> (raw)
In-Reply-To: <1368060805-2790-13-git-send-email-jun.nakajima@intel.com>

Il 09/05/2013 02:53, Jun Nakajima ha scritto:
> +#endif
>  	walker->fault.address = addr;
>  	walker->fault.nested_page_fault = mmu != vcpu->arch.walk_mmu;
>  
> diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
> index ca49e19..a44e7fd 100644
> --- a/arch/x86/kvm/vmx.c
> +++ b/arch/x86/kvm/vmx.c
> @@ -5310,6 +5310,8 @@ static int handle_ept_violation(struct kvm_vcpu *vcpu)
>  	/* ept page table is present? */
>  	error_code |= (exit_qualification >> 3) & 0x1;
>  
> +	vcpu->arch.exit_qualification = exit_qualification;
> +
>  	return kvm_mmu_page_fault(vcpu, gpa, error_code, NULL, 0);
>  }
>  
> @@ -7426,7 +7428,7 @@ static unsigned long nested_ept_get_cr3(struct kvm_vcpu *vcpu)
>  }
>  
>  static void nested_ept_inject_page_fault(struct kvm_vcpu *vcpu,
> -	struct x86_exception *fault)
> +					struct x86_exception *fault)
>  {
>  	struct vmcs12 *vmcs12;
>  	nested_vmx_vmexit(vcpu);
> @@ -7435,10 +7437,81 @@ static void nested_ept_inject_page_fault(struct kvm_vcpu *vcpu,
>  	 * Note no need to set vmcs12->vm_exit_reason as it is already copied
>  	 * from vmcs02 in nested_vmx_vmexit() above, i.e., EPT_VIOLATION.
>  	 */
> -	vmcs12->exit_qualification = fault->error_code;
> +	if (fault->error_code & PFERR_RSVD_MASK)
> +		vmcs12->vm_exit_reason = EXIT_REASON_EPT_MISCONFIG;
> +	else
> +		vmcs12->vm_exit_reason = EXIT_REASON_EPT_VIOLATION;
> +
> +	vmcs12->exit_qualification = vcpu->arch.exit_qualification;

Not exactly pretty, but I cannot think of anything better.

Paolo

  reply	other threads:[~2013-05-14 12:41 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-09  0:53 [PATCH v3 01/13] nEPT: Support LOAD_IA32_EFER entry/exit controls for L1 Jun Nakajima
2013-05-09  0:53 ` [PATCH v3 02/13] nEPT: Move gpte_access() and prefetch_invalid_gpte() to paging_tmpl.h Jun Nakajima
2013-05-09  0:53   ` [PATCH v3 03/13] nEPT: Add EPT tables support " Jun Nakajima
2013-05-09  0:53     ` [PATCH v3 04/13] nEPT: Define EPT-specific link_shadow_page() Jun Nakajima
2013-05-09  0:53       ` [PATCH v3 05/13] nEPT: MMU context for nested EPT Jun Nakajima
2013-05-09  0:53         ` [PATCH v3 06/13] nEPT: Fix cr3 handling in nested exit and entry Jun Nakajima
2013-05-09  0:53           ` [PATCH v3 07/13] nEPT: Fix wrong test in kvm_set_cr3 Jun Nakajima
2013-05-09  0:53             ` [PATCH v3 08/13] nEPT: Some additional comments Jun Nakajima
2013-05-09  0:53               ` [PATCH v3 09/13] nEPT: Advertise EPT to L1 Jun Nakajima
2013-05-09  0:53                 ` [PATCH v3 10/13] nEPT: Nested INVEPT Jun Nakajima
2013-05-09  0:53                   ` [PATCH v3 11/13] nEPT: Miscelleneous cleanups Jun Nakajima
2013-05-09  0:53                     ` [PATCH v3 12/13] nEPT: Move is_rsvd_bits_set() to paging_tmpl.h Jun Nakajima
2013-05-09  0:53                       ` [PATCH v3 13/13] nEPT: Inject EPT violation/misconfigration Jun Nakajima
2013-05-14 12:41                         ` Paolo Bonzini [this message]
2013-05-13 12:25 ` [PATCH v3 01/13] nEPT: Support LOAD_IA32_EFER entry/exit controls for L1 Gleb Natapov
2013-05-19  4:57   ` Nakajima, Jun
2013-05-19  4:52 Jun Nakajima
2013-05-19  4:52 ` [PATCH v3 13/13] nEPT: Inject EPT violation/misconfigration Jun Nakajima
2013-05-20 13:09   ` Paolo Bonzini
2013-05-21 10:56   ` Xiao Guangrong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=519230E6.8080500@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=jun.nakajima@intel.com \
    --cc=kvm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.