From: "Jan Beulich" <JBeulich@suse.com>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: "Keir (Xen.org)" <keir@xen.org>,
Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>,
"Tim (Xen.org)" <tim@xen.org>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>,
Julien Grall <julien.grall@citrix.com>
Subject: Re: [PATCH 4/4] xen/arm: correctly handle an empty array of platform descs.
Date: Tue, 14 May 2013 16:46:35 +0100 [thread overview]
Message-ID: <5192787B02000078000D61D3@nat28.tlf.novell.com> (raw)
In-Reply-To: <1368544071.14264.46.camel@zakaz.uk.xensource.com>
>>> On 14.05.13 at 17:07, Ian Campbell <Ian.Campbell@citrix.com> wrote:
> But if I remove only -DGCC_HAS_VISIBILITY_ATTRIBUTE the issue goes away.
>
> Which makes no sense because the test code has no use of that, but Aha:
> -include
> /local/scratch/ianc/devel/arm/xen.git/xen/include/xen/config.h
>
> Which eventually gets us, from compiler.h:
> #ifdef GCC_HAS_VISIBILITY_ATTRIBUTE
> /* Results in more efficient PIC code (no indirections through GOT or PLT).
> */
> #pragma GCC visibility push(hidden)
> #endif
That's a very interesting (to me at least) side effect of applying
hidden visibility to symbols.
Jan
next prev parent reply other threads:[~2013-05-14 15:46 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-13 16:22 [PATCH 0/4] xen/arm: fixes for 64 bit Ian Campbell
2013-05-13 16:22 ` [PATCH 1/4] xen/arm: Add emacs magic blocks to asm files Ian Campbell
2013-05-13 16:44 ` Stefano Stabellini
2013-05-13 17:35 ` Tim Deegan
2013-05-13 16:23 ` [PATCH 2/4] xen/arm64: do not clobber callee saved register in early_putch Ian Campbell
2013-05-13 16:53 ` Stefano Stabellini
2013-05-13 16:23 ` [PATCH 3/4] xen/arm: support "arm, armv8-timer" DTS compatibility Ian Campbell
2013-05-13 16:46 ` Stefano Stabellini
2013-05-13 16:23 ` [PATCH 4/4] xen/arm: correctly handle an empty array of platform descs Ian Campbell
2013-05-13 16:48 ` Stefano Stabellini
2013-05-14 9:32 ` Ian Campbell
2013-05-14 9:48 ` Jan Beulich
2013-05-14 10:21 ` Ian Campbell
2013-05-14 14:29 ` Jan Beulich
2013-05-14 14:37 ` Jan Beulich
2013-05-14 14:54 ` Ian Campbell
2013-05-14 14:56 ` Ian Campbell
2013-05-14 15:07 ` Ian Campbell
2013-05-14 15:46 ` Jan Beulich [this message]
2013-05-14 16:41 ` Ian Campbell
2013-05-15 7:12 ` Jan Beulich
2013-05-15 9:47 ` Ian Campbell
2013-05-15 12:19 ` Jan Beulich
2013-05-15 13:47 ` Ian Campbell
2013-05-16 10:17 ` Jan Beulich
2013-05-17 10:07 ` Ian Campbell
2013-05-17 10:39 ` Jan Beulich
2013-05-17 14:34 ` Ian Campbell
2013-05-17 15:34 ` Jan Beulich
2013-05-17 17:03 ` Ian Campbell
2013-05-21 7:54 ` Jan Beulich
2013-05-14 15:11 ` Jan Beulich
2013-05-14 15:14 ` Ian Campbell
2013-05-14 9:36 ` [PATCH 0/4] xen/arm: fixes for 64 bit Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5192787B02000078000D61D3@nat28.tlf.novell.com \
--to=jbeulich@suse.com \
--cc=Ian.Campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=Stefano.Stabellini@eu.citrix.com \
--cc=julien.grall@citrix.com \
--cc=keir@xen.org \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.