From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jan Beulich" Subject: Re: [PATCH 02/20] PVH xen: add XENMEM_add_to_physmap_range Date: Wed, 15 May 2013 10:58:43 +0100 Message-ID: <5193787302000078000D659C@nat28.tlf.novell.com> References: <1368579168-30829-1-git-send-email-mukesh.rathor@oracle.com> <1368579168-30829-3-git-send-email-mukesh.rathor@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1368579168-30829-3-git-send-email-mukesh.rathor@oracle.com> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Mukesh Rathor Cc: xen-devel List-Id: xen-devel@lists.xenproject.org >>> On 15.05.13 at 02:52, Mukesh Rathor wrote: > --- a/xen/arch/x86/mm.c > +++ b/xen/arch/x86/mm.c > @@ -4519,7 +4519,8 @@ static int handle_iomem_range(unsigned long s, unsigned long e, void *p) > > static int xenmem_add_to_physmap_once( > struct domain *d, > - const struct xen_add_to_physmap *xatp) > + const struct xen_add_to_physmap *xatp, > + domid_t foreign_domid) > { > struct page_info *page = NULL; > unsigned long gfn = 0; /* gcc ... */ > @@ -4646,7 +4647,7 @@ static int xenmem_add_to_physmap(struct domain *d, I know I said this before: This patch can't be complete, or else the new function parameter would actually get used. With the way things are, if this patch gets applied, a user of the new XENMEM_ sub-op would not get the expected behavior. And I know I said this before too: It should be possible to apply any contiguous initial sub-portion of a patch series without introducing breakage to the tree - you shouldn't assume the whole series gets applied in one go (or, if found necessary later, gets reverted altogether). Jan