From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:45980) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ucgxg-0001tx-Da for qemu-devel@nongnu.org; Wed, 15 May 2013 15:02:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ucgxb-0006V6-14 for qemu-devel@nongnu.org; Wed, 15 May 2013 15:02:04 -0400 Received: from mx1.redhat.com ([209.132.183.28]:10947) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ucgxa-0006Ux-Pw for qemu-devel@nongnu.org; Wed, 15 May 2013 15:01:58 -0400 Message-ID: <5193DB7B.5010404@redhat.com> Date: Wed, 15 May 2013 13:01:15 -0600 From: Eric Blake MIME-Version: 1.0 References: <1368628476-19622-1-git-send-email-stefanha@redhat.com> <1368628476-19622-8-git-send-email-stefanha@redhat.com> In-Reply-To: <1368628476-19622-8-git-send-email-stefanha@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2GDBIADJMBDFJHOFQPOXI" Subject: Re: [Qemu-devel] [PATCH v3 7/8] blockdev: add Abort transaction List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Kevin Wolf , Fam Zheng , qemu-devel@nongnu.org, dietmar@proxmox.com, imain@redhat.com, Paolo Bonzini , xiawenc@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2GDBIADJMBDFJHOFQPOXI Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 05/15/2013 08:34 AM, Stefan Hajnoczi wrote: > The Abort action can be used to test QMP 'transaction' failure. Add it= > as the last action to exercise the .abort() and .cleanup() code paths > for all previous actions. >=20 > Signed-off-by: Stefan Hajnoczi > --- > blockdev.c | 15 +++++++++++++++ > qapi-schema.json | 11 ++++++++++- > 2 files changed, 25 insertions(+), 1 deletion(-) I like it! Even though libvirt will never use it, I can see how having it definitely helps development of other transaction actions. > +++ b/qapi-schema.json > @@ -1630,6 +1630,14 @@ > '*mode': 'NewImageMode', '*speed': 'int' } } > =20 > ## > +# @Abort > +# > +# This action can be used to test transaction failure. > +### > +{ 'type': 'Abort', > + 'data': { } } > + Probably should add a Since: 1.6 notation. With that, Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2GDBIADJMBDFJHOFQPOXI Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRk9t7AAoJEKeha0olJ0NqRwwH/jn33onXmPZ62y69kQYoZb3M gM5/qQHoYJ5K3mJWbqxu3cYAqFOxkS6fa2V/SZqXQVeGXksfx2DHU2kJrXxQVsB2 kIDoIRAmfn6fOxrQav5F73UKblVAb88IaIok/yMruaW9Ia2dlNDfBKjBq9zRvH9k 8LdfpMLDia8FocbEtKgA3CmEwV9goo9FeRHekrlnhiB12LztPGyYf3meAz7XCIjM /sscJQ1Vpctgm2SSNk2F+smCnfU4Bq9D1do/OP1rhej8FbXE3X2/aWYrC/Z4VY6x baS6vd4OL+Ha9tQXrDbfMNIqE7HXibpKX/MI9yeKDmlYVLNvzkG4oi4cX9flpO0= =3ZIM -----END PGP SIGNATURE----- ------enig2GDBIADJMBDFJHOFQPOXI--