From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:49155) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uch7K-0004ek-45 for qemu-devel@nongnu.org; Wed, 15 May 2013 15:12:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Uch7I-0001VD-RH for qemu-devel@nongnu.org; Wed, 15 May 2013 15:12:02 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53511) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uch7I-0001V7-I2 for qemu-devel@nongnu.org; Wed, 15 May 2013 15:12:00 -0400 Message-ID: <5193DD7B.9050704@redhat.com> Date: Wed, 15 May 2013 13:09:47 -0600 From: Eric Blake MIME-Version: 1.0 References: <1368628476-19622-1-git-send-email-stefanha@redhat.com> <1368628476-19622-6-git-send-email-stefanha@redhat.com> In-Reply-To: <1368628476-19622-6-git-send-email-stefanha@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2SQNQIXXLGXRHDKDNEOMO" Subject: Re: [Qemu-devel] [PATCH v3 5/8] blockdev: rename BlkTransactionStates to singular List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Kevin Wolf , Fam Zheng , qemu-devel@nongnu.org, dietmar@proxmox.com, imain@redhat.com, Paolo Bonzini , xiawenc@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2SQNQIXXLGXRHDKDNEOMO Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 05/15/2013 08:34 AM, Stefan Hajnoczi wrote: > The QMP 'transaction' command keeps a list of in-flight transactions. > The transaction state structure is called BlkTransactionStates even > though it only deals with a single transaction. The only plural thing > is the linked list of transaction states. >=20 > I find it confusing to call the single structure "States". This patch > renames it to "State", just like BlockDriverState is singular. >=20 > Signed-off-by: Stefan Hajnoczi > --- > blockdev.c | 104 ++++++++++++++++++++++++++++++-----------------------= -------- > 1 file changed, 52 insertions(+), 52 deletions(-) Mechanical, and singular makes sense to me (for a given callback, you are dealing with the single state for that callback, not all the states chained into the transaction). Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2SQNQIXXLGXRHDKDNEOMO Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRk917AAoJEKeha0olJ0NqhRYH/3B7M7vZGeKvA+0Q8Y1EjNPC S7e5HtVQD0T7Sz+MrgAFWlXNpFj7iVMr1LQMrU9RXZgpcSzaJ4wo+EIpnJxq8pyn k1QNKvyVaQ5np0wmDHRD3FdjRlV+Ks2CyPSAVDTDGUQRjHtsiR7Udt3RO5R+q/zz HWgRW9hCQdZGW3Og6QxXDZewsXNpe4pVSJD4MkieDPf+Qz/t/NoPpsVvC0bksWqU TsoM+6i7GSORXS2osjai8yJ5x6cC+79QLsUKGjuYKEeX2uG8g2012XLH4ED8+3Gw D39Lf89BG8B+l+RcnGyyGQuPmglt+QutOz7VHG/LS9AVb0fJx8+F18MNaVwFVAo= =/HkU -----END PGP SIGNATURE----- ------enig2SQNQIXXLGXRHDKDNEOMO--