From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:57039) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UcnuH-0006kD-BS for qemu-devel@nongnu.org; Wed, 15 May 2013 22:27:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UcnuF-0002zb-Qy for qemu-devel@nongnu.org; Wed, 15 May 2013 22:27:01 -0400 Received: from e23smtp08.au.ibm.com ([202.81.31.141]:43869) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UcnuF-0002zK-7l for qemu-devel@nongnu.org; Wed, 15 May 2013 22:26:59 -0400 Received: from /spool/local by e23smtp08.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 16 May 2013 12:24:24 +1000 Received: from d23relay04.au.ibm.com (d23relay04.au.ibm.com [9.190.234.120]) by d23dlp02.au.ibm.com (Postfix) with ESMTP id CF0272BB0051 for ; Thu, 16 May 2013 12:26:46 +1000 (EST) Received: from d23av01.au.ibm.com (d23av01.au.ibm.com [9.190.234.96]) by d23relay04.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r4G2CkWR23789736 for ; Thu, 16 May 2013 12:12:46 +1000 Received: from d23av01.au.ibm.com (loopback [127.0.0.1]) by d23av01.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r4G2Qklg014525 for ; Thu, 16 May 2013 12:26:46 +1000 Message-ID: <519443DE.5040809@linux.vnet.ibm.com> Date: Thu, 16 May 2013 10:26:38 +0800 From: Wenchao Xia MIME-Version: 1.0 References: <1368628476-19622-1-git-send-email-stefanha@redhat.com> <1368628476-19622-8-git-send-email-stefanha@redhat.com> <5193DB7B.5010404@redhat.com> In-Reply-To: <5193DB7B.5010404@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH v3 7/8] blockdev: add Abort transaction List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: Kevin Wolf , Fam Zheng , qemu-devel@nongnu.org, imain@redhat.com, Stefan Hajnoczi , Paolo Bonzini , dietmar@proxmox.com 于 2013-5-16 3:01, Eric Blake 写道: > On 05/15/2013 08:34 AM, Stefan Hajnoczi wrote: >> The Abort action can be used to test QMP 'transaction' failure. Add it >> as the last action to exercise the .abort() and .cleanup() code paths >> for all previous actions. >> >> Signed-off-by: Stefan Hajnoczi >> --- >> blockdev.c | 15 +++++++++++++++ >> qapi-schema.json | 11 ++++++++++- >> 2 files changed, 25 insertions(+), 1 deletion(-) > > I like it! Even though libvirt will never use it, I can see how having > it definitely helps development of other transaction actions. > >> +++ b/qapi-schema.json >> @@ -1630,6 +1630,14 @@ >> '*mode': 'NewImageMode', '*speed': 'int' } } >> >> ## >> +# @Abort >> +# >> +# This action can be used to test transaction failure. >> +### >> +{ 'type': 'Abort', >> + 'data': { } } >> + > > Probably should add a Since: 1.6 notation. With that, > > Reviewed-by: Eric Blake > Nice to have it for injecting error. Reviewed-by: Wenchao Xia -- Best Regards Wenchao Xia