From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:57562) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UcnwD-0007bG-Nj for qemu-devel@nongnu.org; Wed, 15 May 2013 22:29:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UcnwC-0003nO-Fx for qemu-devel@nongnu.org; Wed, 15 May 2013 22:29:01 -0400 Received: from e23smtp01.au.ibm.com ([202.81.31.143]:55713) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UcnwB-0003nG-T6 for qemu-devel@nongnu.org; Wed, 15 May 2013 22:29:00 -0400 Received: from /spool/local by e23smtp01.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 16 May 2013 12:21:05 +1000 Received: from d23relay03.au.ibm.com (d23relay03.au.ibm.com [9.190.235.21]) by d23dlp01.au.ibm.com (Postfix) with ESMTP id 1DE6C2CE804A for ; Thu, 16 May 2013 12:28:53 +1000 (EST) Received: from d23av01.au.ibm.com (d23av01.au.ibm.com [9.190.234.96]) by d23relay03.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r4G2Sjhr17563670 for ; Thu, 16 May 2013 12:28:45 +1000 Received: from d23av01.au.ibm.com (loopback [127.0.0.1]) by d23av01.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r4G2SqC8017808 for ; Thu, 16 May 2013 12:28:52 +1000 Message-ID: <5194445C.9090601@linux.vnet.ibm.com> Date: Thu, 16 May 2013 10:28:44 +0800 From: Wenchao Xia MIME-Version: 1.0 References: <1368628476-19622-1-git-send-email-stefanha@redhat.com> <1368628476-19622-6-git-send-email-stefanha@redhat.com> In-Reply-To: <1368628476-19622-6-git-send-email-stefanha@redhat.com> Content-Type: text/plain; charset=GB2312 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 5/8] blockdev: rename BlkTransactionStates to singular List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Kevin Wolf , Fam Zheng , qemu-devel@nongnu.org, imain@redhat.com, Paolo Bonzini , dietmar@proxmox.com > The QMP 'transaction' command keeps a list of in-flight transactions. > The transaction state structure is called BlkTransactionStates even > though it only deals with a single transaction. The only plural thing > is the linked list of transaction states. > > I find it confusing to call the single structure "States". This patch > renames it to "State", just like BlockDriverState is singular. > > Signed-off-by: Stefan Hajnoczi > --- > blockdev.c | 104 ++++++++++++++++++++++++++++++------------------------------- > 1 file changed, 52 insertions(+), 52 deletions(-) > Reviewed-by: Wenchao Xia -- Best Regards Wenchao Xia