* [PATCH] ASoC: dfbmcs320: make the driver common for other BT modules
@ 2013-05-16 6:53 ` Barry Song
0 siblings, 0 replies; 12+ messages in thread
From: Barry Song @ 2013-05-16 6:53 UTC (permalink / raw)
To: lgirdwood, broonie
Cc: alsa-devel, Lars-Peter Clausen, workgroup.linux, Graeme Gregory,
Barry Song, linux-arm-kernel
DFBM-CS320 is only one of bluetooth modules using CSR bluetooth chips,
we don't want everyone to have a seperate codec driver. anyway, the
feature of Bluetooth handsfree is same on all platforms, so this patch
makes the DFBM-CS320 driver become a common BT handsfree driver.
Cc: Graeme Gregory <graeme@openmoko.org>
Cc: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Barry Song <Baohua.Song@csr.com>
---
sound/soc/codecs/Kconfig | 4 ++--
sound/soc/codecs/Makefile | 4 ++--
sound/soc/codecs/{dfbmcs320.c => bt-handsfree.c} | 28 ++++++++++++------------
sound/soc/samsung/neo1973_wm8753.c | 6 ++---
4 files changed, 21 insertions(+), 21 deletions(-)
rename sound/soc/codecs/{dfbmcs320.c => bt-handsfree.c} (57%)
diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig
index d8c4f3d..618928a 100644
--- a/sound/soc/codecs/Kconfig
+++ b/sound/soc/codecs/Kconfig
@@ -40,7 +40,7 @@ config SND_SOC_ALL_CODECS
select SND_SOC_DA7213 if I2C
select SND_SOC_DA732X if I2C
select SND_SOC_DA9055 if I2C
- select SND_SOC_DFBMCS320
+ select SND_SOC_BT_HANDSFREE
select SND_SOC_ISABELLE if I2C
select SND_SOC_JZ4740_CODEC
select SND_SOC_LM4857 if I2C
@@ -263,7 +263,7 @@ config SND_SOC_DA732X
config SND_SOC_DA9055
tristate
-config SND_SOC_DFBMCS320
+config SND_SOC_BT_HANDSFREE
tristate
config SND_SOC_DMIC
diff --git a/sound/soc/codecs/Makefile b/sound/soc/codecs/Makefile
index 49ff127..23a8c06 100644
--- a/sound/soc/codecs/Makefile
+++ b/sound/soc/codecs/Makefile
@@ -27,7 +27,7 @@ snd-soc-da7210-objs := da7210.o
snd-soc-da7213-objs := da7213.o
snd-soc-da732x-objs := da732x.o
snd-soc-da9055-objs := da9055.o
-snd-soc-dfbmcs320-objs := dfbmcs320.o
+snd-soc-bt-handsfree-objs := bt-handsfree.o
snd-soc-dmic-objs := dmic.o
snd-soc-isabelle-objs := isabelle.o
snd-soc-jz4740-codec-objs := jz4740.o
@@ -154,7 +154,7 @@ obj-$(CONFIG_SND_SOC_DA7210) += snd-soc-da7210.o
obj-$(CONFIG_SND_SOC_DA7213) += snd-soc-da7213.o
obj-$(CONFIG_SND_SOC_DA732X) += snd-soc-da732x.o
obj-$(CONFIG_SND_SOC_DA9055) += snd-soc-da9055.o
-obj-$(CONFIG_SND_SOC_DFBMCS320) += snd-soc-dfbmcs320.o
+obj-$(CONFIG_SND_SOC_BT_HANDSFREE) += snd-soc-bt-handsfree.o
obj-$(CONFIG_SND_SOC_DMIC) += snd-soc-dmic.o
obj-$(CONFIG_SND_SOC_ISABELLE) += snd-soc-isabelle.o
obj-$(CONFIG_SND_SOC_JZ4740_CODEC) += snd-soc-jz4740-codec.o
diff --git a/sound/soc/codecs/dfbmcs320.c b/sound/soc/codecs/bt-handsfree.c
similarity index 57%
rename from sound/soc/codecs/dfbmcs320.c
rename to sound/soc/codecs/bt-handsfree.c
index 4f4f7f4..99291e0 100644
--- a/sound/soc/codecs/dfbmcs320.c
+++ b/sound/soc/codecs/bt-handsfree.c
@@ -1,5 +1,5 @@
/*
- * Driver for the DFBM-CS320 bluetooth module
+ * Driver for generic Bluetooth Handsfree
* Copyright 2011 Lars-Peter Clausen <lars@metafoo.de>
*
* This program is free software; you can redistribute it and/or modify it
@@ -15,8 +15,8 @@
#include <sound/soc.h>
-static struct snd_soc_dai_driver dfbmcs320_dai = {
- .name = "dfbmcs320-pcm",
+static struct snd_soc_dai_driver bt_handsfree_dai = {
+ .name = "bt-handsfree-pcm",
.playback = {
.channels_min = 1,
.channels_max = 1,
@@ -31,32 +31,32 @@ static struct snd_soc_dai_driver dfbmcs320_dai = {
},
};
-static struct snd_soc_codec_driver soc_codec_dev_dfbmcs320;
+static struct snd_soc_codec_driver soc_codec_dev_bt_handsfree;
-static int dfbmcs320_probe(struct platform_device *pdev)
+static int bt_handsfree_probe(struct platform_device *pdev)
{
- return snd_soc_register_codec(&pdev->dev, &soc_codec_dev_dfbmcs320,
- &dfbmcs320_dai, 1);
+ return snd_soc_register_codec(&pdev->dev, &soc_codec_dev_bt_handsfree,
+ &bt_handsfree_dai, 1);
}
-static int dfbmcs320_remove(struct platform_device *pdev)
+static int bt_handsfree_remove(struct platform_device *pdev)
{
snd_soc_unregister_codec(&pdev->dev);
return 0;
}
-static struct platform_driver dfmcs320_driver = {
+static struct platform_driver bt_handsfree_driver = {
.driver = {
- .name = "dfbmcs320",
+ .name = "bt-handsfree",
.owner = THIS_MODULE,
},
- .probe = dfbmcs320_probe,
- .remove = dfbmcs320_remove,
+ .probe = bt_handsfree_probe,
+ .remove = bt_handsfree_remove,
};
-module_platform_driver(dfmcs320_driver);
+module_platform_driver(bt_handsfree_driver);
MODULE_AUTHOR("Lars-Peter Clausen <lars@metafoo.de>");
-MODULE_DESCRIPTION("ASoC DFBM-CS320 bluethooth module driver");
+MODULE_DESCRIPTION("ASoC generic bluethooth handsfree driver");
MODULE_LICENSE("GPL");
diff --git a/sound/soc/samsung/neo1973_wm8753.c b/sound/soc/samsung/neo1973_wm8753.c
index e591c38..bae5144 100644
--- a/sound/soc/samsung/neo1973_wm8753.c
+++ b/sound/soc/samsung/neo1973_wm8753.c
@@ -373,7 +373,7 @@ static struct snd_soc_dai_link neo1973_dai[] = {
{ /* Voice via BT */
.name = "Bluetooth",
.stream_name = "Voice",
- .cpu_dai_name = "dfbmcs320-pcm",
+ .cpu_dai_name = "bt-handsfree-pcm",
.codec_dai_name = "wm8753-voice",
.codec_name = "wm8753.0-001a",
.ops = &neo1973_voice_ops,
@@ -382,8 +382,8 @@ static struct snd_soc_dai_link neo1973_dai[] = {
static struct snd_soc_aux_dev neo1973_aux_devs[] = {
{
- .name = "dfbmcs320",
- .codec_name = "dfbmcs320.0",
+ .name = "bt_handsfree",
+ .codec_name = "bt_handsfree.0",
},
};
--
1.8.2.3
Member of the CSR plc group of companies. CSR plc registered in England and Wales, registered number 4187346, registered office Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, United Kingdom
More information can be found at www.csr.com. Follow CSR on Twitter at http://twitter.com/CSR_PLC and read our blog at www.csr.com/blog
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH] ASoC: dfbmcs320: make the driver common for other BT modules
@ 2013-05-16 6:53 ` Barry Song
0 siblings, 0 replies; 12+ messages in thread
From: Barry Song @ 2013-05-16 6:53 UTC (permalink / raw)
To: linux-arm-kernel
DFBM-CS320 is only one of bluetooth modules using CSR bluetooth chips,
we don't want everyone to have a seperate codec driver. anyway, the
feature of Bluetooth handsfree is same on all platforms, so this patch
makes the DFBM-CS320 driver become a common BT handsfree driver.
Cc: Graeme Gregory <graeme@openmoko.org>
Cc: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Barry Song <Baohua.Song@csr.com>
---
sound/soc/codecs/Kconfig | 4 ++--
sound/soc/codecs/Makefile | 4 ++--
sound/soc/codecs/{dfbmcs320.c => bt-handsfree.c} | 28 ++++++++++++------------
sound/soc/samsung/neo1973_wm8753.c | 6 ++---
4 files changed, 21 insertions(+), 21 deletions(-)
rename sound/soc/codecs/{dfbmcs320.c => bt-handsfree.c} (57%)
diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig
index d8c4f3d..618928a 100644
--- a/sound/soc/codecs/Kconfig
+++ b/sound/soc/codecs/Kconfig
@@ -40,7 +40,7 @@ config SND_SOC_ALL_CODECS
select SND_SOC_DA7213 if I2C
select SND_SOC_DA732X if I2C
select SND_SOC_DA9055 if I2C
- select SND_SOC_DFBMCS320
+ select SND_SOC_BT_HANDSFREE
select SND_SOC_ISABELLE if I2C
select SND_SOC_JZ4740_CODEC
select SND_SOC_LM4857 if I2C
@@ -263,7 +263,7 @@ config SND_SOC_DA732X
config SND_SOC_DA9055
tristate
-config SND_SOC_DFBMCS320
+config SND_SOC_BT_HANDSFREE
tristate
config SND_SOC_DMIC
diff --git a/sound/soc/codecs/Makefile b/sound/soc/codecs/Makefile
index 49ff127..23a8c06 100644
--- a/sound/soc/codecs/Makefile
+++ b/sound/soc/codecs/Makefile
@@ -27,7 +27,7 @@ snd-soc-da7210-objs := da7210.o
snd-soc-da7213-objs := da7213.o
snd-soc-da732x-objs := da732x.o
snd-soc-da9055-objs := da9055.o
-snd-soc-dfbmcs320-objs := dfbmcs320.o
+snd-soc-bt-handsfree-objs := bt-handsfree.o
snd-soc-dmic-objs := dmic.o
snd-soc-isabelle-objs := isabelle.o
snd-soc-jz4740-codec-objs := jz4740.o
@@ -154,7 +154,7 @@ obj-$(CONFIG_SND_SOC_DA7210) += snd-soc-da7210.o
obj-$(CONFIG_SND_SOC_DA7213) += snd-soc-da7213.o
obj-$(CONFIG_SND_SOC_DA732X) += snd-soc-da732x.o
obj-$(CONFIG_SND_SOC_DA9055) += snd-soc-da9055.o
-obj-$(CONFIG_SND_SOC_DFBMCS320) += snd-soc-dfbmcs320.o
+obj-$(CONFIG_SND_SOC_BT_HANDSFREE) += snd-soc-bt-handsfree.o
obj-$(CONFIG_SND_SOC_DMIC) += snd-soc-dmic.o
obj-$(CONFIG_SND_SOC_ISABELLE) += snd-soc-isabelle.o
obj-$(CONFIG_SND_SOC_JZ4740_CODEC) += snd-soc-jz4740-codec.o
diff --git a/sound/soc/codecs/dfbmcs320.c b/sound/soc/codecs/bt-handsfree.c
similarity index 57%
rename from sound/soc/codecs/dfbmcs320.c
rename to sound/soc/codecs/bt-handsfree.c
index 4f4f7f4..99291e0 100644
--- a/sound/soc/codecs/dfbmcs320.c
+++ b/sound/soc/codecs/bt-handsfree.c
@@ -1,5 +1,5 @@
/*
- * Driver for the DFBM-CS320 bluetooth module
+ * Driver for generic Bluetooth Handsfree
* Copyright 2011 Lars-Peter Clausen <lars@metafoo.de>
*
* This program is free software; you can redistribute it and/or modify it
@@ -15,8 +15,8 @@
#include <sound/soc.h>
-static struct snd_soc_dai_driver dfbmcs320_dai = {
- .name = "dfbmcs320-pcm",
+static struct snd_soc_dai_driver bt_handsfree_dai = {
+ .name = "bt-handsfree-pcm",
.playback = {
.channels_min = 1,
.channels_max = 1,
@@ -31,32 +31,32 @@ static struct snd_soc_dai_driver dfbmcs320_dai = {
},
};
-static struct snd_soc_codec_driver soc_codec_dev_dfbmcs320;
+static struct snd_soc_codec_driver soc_codec_dev_bt_handsfree;
-static int dfbmcs320_probe(struct platform_device *pdev)
+static int bt_handsfree_probe(struct platform_device *pdev)
{
- return snd_soc_register_codec(&pdev->dev, &soc_codec_dev_dfbmcs320,
- &dfbmcs320_dai, 1);
+ return snd_soc_register_codec(&pdev->dev, &soc_codec_dev_bt_handsfree,
+ &bt_handsfree_dai, 1);
}
-static int dfbmcs320_remove(struct platform_device *pdev)
+static int bt_handsfree_remove(struct platform_device *pdev)
{
snd_soc_unregister_codec(&pdev->dev);
return 0;
}
-static struct platform_driver dfmcs320_driver = {
+static struct platform_driver bt_handsfree_driver = {
.driver = {
- .name = "dfbmcs320",
+ .name = "bt-handsfree",
.owner = THIS_MODULE,
},
- .probe = dfbmcs320_probe,
- .remove = dfbmcs320_remove,
+ .probe = bt_handsfree_probe,
+ .remove = bt_handsfree_remove,
};
-module_platform_driver(dfmcs320_driver);
+module_platform_driver(bt_handsfree_driver);
MODULE_AUTHOR("Lars-Peter Clausen <lars@metafoo.de>");
-MODULE_DESCRIPTION("ASoC DFBM-CS320 bluethooth module driver");
+MODULE_DESCRIPTION("ASoC generic bluethooth handsfree driver");
MODULE_LICENSE("GPL");
diff --git a/sound/soc/samsung/neo1973_wm8753.c b/sound/soc/samsung/neo1973_wm8753.c
index e591c38..bae5144 100644
--- a/sound/soc/samsung/neo1973_wm8753.c
+++ b/sound/soc/samsung/neo1973_wm8753.c
@@ -373,7 +373,7 @@ static struct snd_soc_dai_link neo1973_dai[] = {
{ /* Voice via BT */
.name = "Bluetooth",
.stream_name = "Voice",
- .cpu_dai_name = "dfbmcs320-pcm",
+ .cpu_dai_name = "bt-handsfree-pcm",
.codec_dai_name = "wm8753-voice",
.codec_name = "wm8753.0-001a",
.ops = &neo1973_voice_ops,
@@ -382,8 +382,8 @@ static struct snd_soc_dai_link neo1973_dai[] = {
static struct snd_soc_aux_dev neo1973_aux_devs[] = {
{
- .name = "dfbmcs320",
- .codec_name = "dfbmcs320.0",
+ .name = "bt_handsfree",
+ .codec_name = "bt_handsfree.0",
},
};
--
1.8.2.3
Member of the CSR plc group of companies. CSR plc registered in England and Wales, registered number 4187346, registered office Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, United Kingdom
More information can be found at www.csr.com. Follow CSR on Twitter at http://twitter.com/CSR_PLC and read our blog at www.csr.com/blog
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH] ASoC: dfbmcs320: make the driver common for other BT modules
2013-05-16 6:53 ` Barry Song
@ 2013-05-16 9:51 ` Lars-Peter Clausen
-1 siblings, 0 replies; 12+ messages in thread
From: Lars-Peter Clausen @ 2013-05-16 9:51 UTC (permalink / raw)
To: Barry Song
Cc: alsa-devel, lgirdwood, workgroup.linux, Graeme Gregory, broonie,
linux-arm-kernel
On 05/16/2013 08:53 AM, Barry Song wrote:
> DFBM-CS320 is only one of bluetooth modules using CSR bluetooth chips,
> we don't want everyone to have a seperate codec driver. anyway, the
> feature of Bluetooth handsfree is same on all platforms, so this patch
> makes the DFBM-CS320 driver become a common BT handsfree driver.
[...]
> -static struct platform_driver dfmcs320_driver = {
> +static struct platform_driver bt_handsfree_driver = {
> .driver = {
> - .name = "dfbmcs320",
> + .name = "bt-handsfree",
> .owner = THIS_MODULE,
In my opinion it's a good idea to keep a platform_id list of all the
supported devices.
> },
> - .probe = dfbmcs320_probe,
> - .remove = dfbmcs320_remove,
> + .probe = bt_handsfree_probe,
> + .remove = bt_handsfree_remove,
> };
>
> -module_platform_driver(dfmcs320_driver);
> +module_platform_driver(bt_handsfree_driver);
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH] ASoC: dfbmcs320: make the driver common for other BT modules
@ 2013-05-16 9:51 ` Lars-Peter Clausen
0 siblings, 0 replies; 12+ messages in thread
From: Lars-Peter Clausen @ 2013-05-16 9:51 UTC (permalink / raw)
To: linux-arm-kernel
On 05/16/2013 08:53 AM, Barry Song wrote:
> DFBM-CS320 is only one of bluetooth modules using CSR bluetooth chips,
> we don't want everyone to have a seperate codec driver. anyway, the
> feature of Bluetooth handsfree is same on all platforms, so this patch
> makes the DFBM-CS320 driver become a common BT handsfree driver.
[...]
> -static struct platform_driver dfmcs320_driver = {
> +static struct platform_driver bt_handsfree_driver = {
> .driver = {
> - .name = "dfbmcs320",
> + .name = "bt-handsfree",
> .owner = THIS_MODULE,
In my opinion it's a good idea to keep a platform_id list of all the
supported devices.
> },
> - .probe = dfbmcs320_probe,
> - .remove = dfbmcs320_remove,
> + .probe = bt_handsfree_probe,
> + .remove = bt_handsfree_remove,
> };
>
> -module_platform_driver(dfmcs320_driver);
> +module_platform_driver(bt_handsfree_driver);
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] ASoC: dfbmcs320: make the driver common for other BT modules
2013-05-16 9:51 ` Lars-Peter Clausen
@ 2013-05-16 10:31 ` Barry Song
-1 siblings, 0 replies; 12+ messages in thread
From: Barry Song @ 2013-05-16 10:31 UTC (permalink / raw)
To: Lars-Peter Clausen
Cc: alsa-devel, lgirdwood, workgroup.linux, Graeme Gregory, broonie,
Barry Song, linux-arm-kernel
2013/5/16 Lars-Peter Clausen <lars@metafoo.de>:
> On 05/16/2013 08:53 AM, Barry Song wrote:
>> DFBM-CS320 is only one of bluetooth modules using CSR bluetooth chips,
>> we don't want everyone to have a seperate codec driver. anyway, the
>> feature of Bluetooth handsfree is same on all platforms, so this patch
>> makes the DFBM-CS320 driver become a common BT handsfree driver.
> [...]
>> -static struct platform_driver dfmcs320_driver = {
>> +static struct platform_driver bt_handsfree_driver = {
>> .driver = {
>> - .name = "dfbmcs320",
>> + .name = "bt-handsfree",
>> .owner = THIS_MODULE,
>
> In my opinion it's a good idea to keep a platform_id list of all the
> supported devices.
i have no idea how many bluetooth handsfree module exist in the world.
there must be many. actually the driver works for almost all BT
handsfree.
so my basic idea is making the codes as common as possible.
and i also want to add dt compatible in this driver, a generic
compatible string can be "bluetooth, handsfree", but users can add
specific string in its board dts like:
compatible = "delta, dfbmcs320", "bluetooth, handsfree";
so the driver will still work for "delta, dfbmcs320".
>
>> },
>> - .probe = dfbmcs320_probe,
>> - .remove = dfbmcs320_remove,
>> + .probe = bt_handsfree_probe,
>> + .remove = bt_handsfree_remove,
>> };
>>
>> -module_platform_driver(dfmcs320_driver);
>> +module_platform_driver(bt_handsfree_driver);
-barry
^ permalink raw reply [flat|nested] 12+ messages in thread
* [alsa-devel] [PATCH] ASoC: dfbmcs320: make the driver common for other BT modules
@ 2013-05-16 10:31 ` Barry Song
0 siblings, 0 replies; 12+ messages in thread
From: Barry Song @ 2013-05-16 10:31 UTC (permalink / raw)
To: linux-arm-kernel
2013/5/16 Lars-Peter Clausen <lars@metafoo.de>:
> On 05/16/2013 08:53 AM, Barry Song wrote:
>> DFBM-CS320 is only one of bluetooth modules using CSR bluetooth chips,
>> we don't want everyone to have a seperate codec driver. anyway, the
>> feature of Bluetooth handsfree is same on all platforms, so this patch
>> makes the DFBM-CS320 driver become a common BT handsfree driver.
> [...]
>> -static struct platform_driver dfmcs320_driver = {
>> +static struct platform_driver bt_handsfree_driver = {
>> .driver = {
>> - .name = "dfbmcs320",
>> + .name = "bt-handsfree",
>> .owner = THIS_MODULE,
>
> In my opinion it's a good idea to keep a platform_id list of all the
> supported devices.
i have no idea how many bluetooth handsfree module exist in the world.
there must be many. actually the driver works for almost all BT
handsfree.
so my basic idea is making the codes as common as possible.
and i also want to add dt compatible in this driver, a generic
compatible string can be "bluetooth, handsfree", but users can add
specific string in its board dts like:
compatible = "delta, dfbmcs320", "bluetooth, handsfree";
so the driver will still work for "delta, dfbmcs320".
>
>> },
>> - .probe = dfbmcs320_probe,
>> - .remove = dfbmcs320_remove,
>> + .probe = bt_handsfree_probe,
>> + .remove = bt_handsfree_remove,
>> };
>>
>> -module_platform_driver(dfmcs320_driver);
>> +module_platform_driver(bt_handsfree_driver);
-barry
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] ASoC: dfbmcs320: make the driver common for other BT modules
2013-05-16 10:31 ` [alsa-devel] " Barry Song
@ 2013-05-16 11:29 ` Lars-Peter Clausen
-1 siblings, 0 replies; 12+ messages in thread
From: Lars-Peter Clausen @ 2013-05-16 11:29 UTC (permalink / raw)
To: Barry Song
Cc: alsa-devel, lgirdwood, workgroup.linux, Graeme Gregory, broonie,
Barry Song, linux-arm-kernel
On 05/16/2013 12:31 PM, Barry Song wrote:
> 2013/5/16 Lars-Peter Clausen <lars@metafoo.de>:
>> On 05/16/2013 08:53 AM, Barry Song wrote:
>>> DFBM-CS320 is only one of bluetooth modules using CSR bluetooth chips,
>>> we don't want everyone to have a seperate codec driver. anyway, the
>>> feature of Bluetooth handsfree is same on all platforms, so this patch
>>> makes the DFBM-CS320 driver become a common BT handsfree driver.
>> [...]
>>> -static struct platform_driver dfmcs320_driver = {
>>> +static struct platform_driver bt_handsfree_driver = {
>>> .driver = {
>>> - .name = "dfbmcs320",
>>> + .name = "bt-handsfree",
>>> .owner = THIS_MODULE,
>>
>> In my opinion it's a good idea to keep a platform_id list of all the
>> supported devices.
>
> i have no idea how many bluetooth handsfree module exist in the world.
> there must be many. actually the driver works for almost all BT
> handsfree.
> so my basic idea is making the codes as common as possible.
you don't have to know all the device names, but I'd prefer to keep at least
dfbmcs320 in the device id list.
- Lars
^ permalink raw reply [flat|nested] 12+ messages in thread
* [alsa-devel] [PATCH] ASoC: dfbmcs320: make the driver common for other BT modules
@ 2013-05-16 11:29 ` Lars-Peter Clausen
0 siblings, 0 replies; 12+ messages in thread
From: Lars-Peter Clausen @ 2013-05-16 11:29 UTC (permalink / raw)
To: linux-arm-kernel
On 05/16/2013 12:31 PM, Barry Song wrote:
> 2013/5/16 Lars-Peter Clausen <lars@metafoo.de>:
>> On 05/16/2013 08:53 AM, Barry Song wrote:
>>> DFBM-CS320 is only one of bluetooth modules using CSR bluetooth chips,
>>> we don't want everyone to have a seperate codec driver. anyway, the
>>> feature of Bluetooth handsfree is same on all platforms, so this patch
>>> makes the DFBM-CS320 driver become a common BT handsfree driver.
>> [...]
>>> -static struct platform_driver dfmcs320_driver = {
>>> +static struct platform_driver bt_handsfree_driver = {
>>> .driver = {
>>> - .name = "dfbmcs320",
>>> + .name = "bt-handsfree",
>>> .owner = THIS_MODULE,
>>
>> In my opinion it's a good idea to keep a platform_id list of all the
>> supported devices.
>
> i have no idea how many bluetooth handsfree module exist in the world.
> there must be many. actually the driver works for almost all BT
> handsfree.
> so my basic idea is making the codes as common as possible.
you don't have to know all the device names, but I'd prefer to keep at least
dfbmcs320 in the device id list.
- Lars
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] ASoC: dfbmcs320: make the driver common for other BT modules
2013-05-16 11:29 ` [alsa-devel] " Lars-Peter Clausen
@ 2013-05-16 12:00 ` Barry Song
-1 siblings, 0 replies; 12+ messages in thread
From: Barry Song @ 2013-05-16 12:00 UTC (permalink / raw)
To: Lars-Peter Clausen
Cc: alsa-devel, lgirdwood, workgroup.linux, Graeme Gregory, broonie,
Barry Song, linux-arm-kernel
2013/5/16 Lars-Peter Clausen <lars@metafoo.de>:
> On 05/16/2013 12:31 PM, Barry Song wrote:
>> 2013/5/16 Lars-Peter Clausen <lars@metafoo.de>:
>>> On 05/16/2013 08:53 AM, Barry Song wrote:
>>>> DFBM-CS320 is only one of bluetooth modules using CSR bluetooth chips,
>>>> we don't want everyone to have a seperate codec driver. anyway, the
>>>> feature of Bluetooth handsfree is same on all platforms, so this patch
>>>> makes the DFBM-CS320 driver become a common BT handsfree driver.
>>> [...]
>>>> -static struct platform_driver dfmcs320_driver = {
>>>> +static struct platform_driver bt_handsfree_driver = {
>>>> .driver = {
>>>> - .name = "dfbmcs320",
>>>> + .name = "bt-handsfree",
>>>> .owner = THIS_MODULE,
>>>
>>> In my opinion it's a good idea to keep a platform_id list of all the
>>> supported devices.
>>
>> i have no idea how many bluetooth handsfree module exist in the world.
>> there must be many. actually the driver works for almost all BT
>> handsfree.
>> so my basic idea is making the codes as common as possible.
>
> you don't have to know all the device names, but I'd prefer to keep at least
> dfbmcs320 in the device id list.
i did think it is a good idea to have device id list while i sent the
last mail. and it matches with the generic device driver engineering
sense. the problem is i don't how long the list will be.
if you like to keep dfbmcs320 at least for the moment, i would agree.
>
> - Lars
-barry
^ permalink raw reply [flat|nested] 12+ messages in thread
* [alsa-devel] [PATCH] ASoC: dfbmcs320: make the driver common for other BT modules
@ 2013-05-16 12:00 ` Barry Song
0 siblings, 0 replies; 12+ messages in thread
From: Barry Song @ 2013-05-16 12:00 UTC (permalink / raw)
To: linux-arm-kernel
2013/5/16 Lars-Peter Clausen <lars@metafoo.de>:
> On 05/16/2013 12:31 PM, Barry Song wrote:
>> 2013/5/16 Lars-Peter Clausen <lars@metafoo.de>:
>>> On 05/16/2013 08:53 AM, Barry Song wrote:
>>>> DFBM-CS320 is only one of bluetooth modules using CSR bluetooth chips,
>>>> we don't want everyone to have a seperate codec driver. anyway, the
>>>> feature of Bluetooth handsfree is same on all platforms, so this patch
>>>> makes the DFBM-CS320 driver become a common BT handsfree driver.
>>> [...]
>>>> -static struct platform_driver dfmcs320_driver = {
>>>> +static struct platform_driver bt_handsfree_driver = {
>>>> .driver = {
>>>> - .name = "dfbmcs320",
>>>> + .name = "bt-handsfree",
>>>> .owner = THIS_MODULE,
>>>
>>> In my opinion it's a good idea to keep a platform_id list of all the
>>> supported devices.
>>
>> i have no idea how many bluetooth handsfree module exist in the world.
>> there must be many. actually the driver works for almost all BT
>> handsfree.
>> so my basic idea is making the codes as common as possible.
>
> you don't have to know all the device names, but I'd prefer to keep at least
> dfbmcs320 in the device id list.
i did think it is a good idea to have device id list while i sent the
last mail. and it matches with the generic device driver engineering
sense. the problem is i don't how long the list will be.
if you like to keep dfbmcs320 at least for the moment, i would agree.
>
> - Lars
-barry
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] ASoC: dfbmcs320: make the driver common for other BT modules
2013-05-16 12:00 ` [alsa-devel] " Barry Song
@ 2013-05-16 17:35 ` Mark Brown
-1 siblings, 0 replies; 12+ messages in thread
From: Mark Brown @ 2013-05-16 17:35 UTC (permalink / raw)
To: Barry Song
Cc: alsa-devel, Lars-Peter Clausen, lgirdwood, workgroup.linux,
Graeme Gregory, Barry Song, linux-arm-kernel
[-- Attachment #1.1: Type: text/plain, Size: 552 bytes --]
On Thu, May 16, 2013 at 08:00:17PM +0800, Barry Song wrote:
> i did think it is a good idea to have device id list while i sent the
> last mail. and it matches with the generic device driver engineering
> sense. the problem is i don't how long the list will be.
> if you like to keep dfbmcs320 at least for the moment, i would agree.
I'd prefer to see the ID list; we shouldn't be throwing away
information. Probably we can go a long way towards cutting down the
length of the list if it gets silly with use of wildcards in the device
names listed.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* [alsa-devel] [PATCH] ASoC: dfbmcs320: make the driver common for other BT modules
@ 2013-05-16 17:35 ` Mark Brown
0 siblings, 0 replies; 12+ messages in thread
From: Mark Brown @ 2013-05-16 17:35 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, May 16, 2013 at 08:00:17PM +0800, Barry Song wrote:
> i did think it is a good idea to have device id list while i sent the
> last mail. and it matches with the generic device driver engineering
> sense. the problem is i don't how long the list will be.
> if you like to keep dfbmcs320 at least for the moment, i would agree.
I'd prefer to see the ID list; we shouldn't be throwing away
information. Probably we can go a long way towards cutting down the
length of the list if it gets silly with use of wildcards in the device
names listed.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130516/b49bd1d4/attachment.sig>
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2013-05-16 17:36 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-05-16 6:53 [PATCH] ASoC: dfbmcs320: make the driver common for other BT modules Barry Song
2013-05-16 6:53 ` Barry Song
2013-05-16 9:51 ` Lars-Peter Clausen
2013-05-16 9:51 ` Lars-Peter Clausen
2013-05-16 10:31 ` Barry Song
2013-05-16 10:31 ` [alsa-devel] " Barry Song
2013-05-16 11:29 ` Lars-Peter Clausen
2013-05-16 11:29 ` [alsa-devel] " Lars-Peter Clausen
2013-05-16 12:00 ` Barry Song
2013-05-16 12:00 ` [alsa-devel] " Barry Song
2013-05-16 17:35 ` Mark Brown
2013-05-16 17:35 ` [alsa-devel] " Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.