From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:41378) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UczjB-0002jq-He for qemu-devel@nongnu.org; Thu, 16 May 2013 11:04:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UczjA-0001Sn-2z for qemu-devel@nongnu.org; Thu, 16 May 2013 11:04:21 -0400 Received: from mail-gh0-f179.google.com ([209.85.160.179]:33963) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uczj9-0001Sf-Lu for qemu-devel@nongnu.org; Thu, 16 May 2013 11:04:19 -0400 Received: by mail-gh0-f179.google.com with SMTP id f16so92307ghb.24 for ; Thu, 16 May 2013 08:04:19 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <5194F567.3020201@redhat.com> Date: Thu, 16 May 2013 17:04:07 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1368678651-3561-1-git-send-email-akong@redhat.com> <1368682228.5142.68.camel@liguang.fnst.cn.fujitsu.com> <20130516065810.GB3785@t430s.nay.redhat.com> In-Reply-To: <20130516065810.GB3785@t430s.nay.redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] ps2: add support of auto-repeat List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Amos Kong Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org, lcapitulino@redhat.com, kraxel@redhat.com, lersek@redhat.com, li guang Il 16/05/2013 08:58, Amos Kong ha scritto: >> > theoretically, we have to check if the typematic key is in break >> > now, if so, we will not do repeat anymore. > You mean key is released? I checked by '~keycode & 0x80', stop repeat > when key is release. > BTW, !(keycode & 0x80) is more readable. Paolo