From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753948Ab3EQFkW (ORCPT ); Fri, 17 May 2013 01:40:22 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:39127 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751238Ab3EQFkU (ORCPT ); Fri, 17 May 2013 01:40:20 -0400 Message-ID: <5195C28C.40300@ti.com> Date: Fri, 17 May 2013 11:09:24 +0530 From: Kishon Vijay Abraham I User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130329 Thunderbird/17.0.5 MIME-Version: 1.0 To: Tony Lindgren CC: Tomi Valkeinen , , , , , Subject: Re: [PATCH] ARM: OMAP4: change the device names in usb_bind_phy References: <1366697656-14315-1-git-send-email-kishon@ti.com> <51936946.3030507@iki.fi> <20130516155857.GV5600@atomide.com> <519503DA.5070303@iki.fi> <20130516162034.GX5600@atomide.com> In-Reply-To: <20130516162034.GX5600@atomide.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Thursday 16 May 2013 09:50 PM, Tony Lindgren wrote: > * Tomi Valkeinen [130516 09:11]: >> On 16/05/13 18:58, Tony Lindgren wrote: >>> * Tomi Valkeinen [130515 03:59]: >>> >>> Just checking.. Do you have CONFIG_OMAP_OCP2SCP=y in your .config? Sounds >>> like the some transceivers should depend on that for omap4. >> >> Yes, I have OCP2SCP=y. > > Hmm well no idea beyond that then. Sounds like Kishon should check it. > >>>> The musb-hdrc id is wrong on overo also. >>> >>> Hmm has there been a fix posted for that? >> >> I couldn't find with a quick look. We debugged and discussed this on an irc >> channel with Kishon, who said he'll send a patch. Changing the musb-hdrc ID >> on overo fixed the issue, and it looks very similar to the error on 4430sdp. >> The overo fix was just: hmm.. I think using device name to bind the controller and the phy can no longer be used reliably. I think it's better to have something like what Grant suggested in my other patch series.. to have the phy reference into the host controllers platform_data structure. And for the phy reference I'll have label and id. Does this makes sense to you? Thanks Kishon From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kishon Vijay Abraham I Subject: Re: [PATCH] ARM: OMAP4: change the device names in usb_bind_phy Date: Fri, 17 May 2013 11:09:24 +0530 Message-ID: <5195C28C.40300@ti.com> References: <1366697656-14315-1-git-send-email-kishon@ti.com> <51936946.3030507@iki.fi> <20130516155857.GV5600@atomide.com> <519503DA.5070303@iki.fi> <20130516162034.GX5600@atomide.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20130516162034.GX5600@atomide.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Tony Lindgren Cc: linux@arm.linux.org.uk, linux-kernel@vger.kernel.org, balbi@ti.com, Tomi Valkeinen , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org List-Id: linux-omap@vger.kernel.org Hi, On Thursday 16 May 2013 09:50 PM, Tony Lindgren wrote: > * Tomi Valkeinen [130516 09:11]: >> On 16/05/13 18:58, Tony Lindgren wrote: >>> * Tomi Valkeinen [130515 03:59]: >>> >>> Just checking.. Do you have CONFIG_OMAP_OCP2SCP=y in your .config? Sounds >>> like the some transceivers should depend on that for omap4. >> >> Yes, I have OCP2SCP=y. > > Hmm well no idea beyond that then. Sounds like Kishon should check it. > >>>> The musb-hdrc id is wrong on overo also. >>> >>> Hmm has there been a fix posted for that? >> >> I couldn't find with a quick look. We debugged and discussed this on an irc >> channel with Kishon, who said he'll send a patch. Changing the musb-hdrc ID >> on overo fixed the issue, and it looks very similar to the error on 4430sdp. >> The overo fix was just: hmm.. I think using device name to bind the controller and the phy can no longer be used reliably. I think it's better to have something like what Grant suggested in my other patch series.. to have the phy reference into the host controllers platform_data structure. And for the phy reference I'll have label and id. Does this makes sense to you? Thanks Kishon From mboxrd@z Thu Jan 1 00:00:00 1970 From: kishon@ti.com (Kishon Vijay Abraham I) Date: Fri, 17 May 2013 11:09:24 +0530 Subject: [PATCH] ARM: OMAP4: change the device names in usb_bind_phy In-Reply-To: <20130516162034.GX5600@atomide.com> References: <1366697656-14315-1-git-send-email-kishon@ti.com> <51936946.3030507@iki.fi> <20130516155857.GV5600@atomide.com> <519503DA.5070303@iki.fi> <20130516162034.GX5600@atomide.com> Message-ID: <5195C28C.40300@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, On Thursday 16 May 2013 09:50 PM, Tony Lindgren wrote: > * Tomi Valkeinen [130516 09:11]: >> On 16/05/13 18:58, Tony Lindgren wrote: >>> * Tomi Valkeinen [130515 03:59]: >>> >>> Just checking.. Do you have CONFIG_OMAP_OCP2SCP=y in your .config? Sounds >>> like the some transceivers should depend on that for omap4. >> >> Yes, I have OCP2SCP=y. > > Hmm well no idea beyond that then. Sounds like Kishon should check it. > >>>> The musb-hdrc id is wrong on overo also. >>> >>> Hmm has there been a fix posted for that? >> >> I couldn't find with a quick look. We debugged and discussed this on an irc >> channel with Kishon, who said he'll send a patch. Changing the musb-hdrc ID >> on overo fixed the issue, and it looks very similar to the error on 4430sdp. >> The overo fix was just: hmm.. I think using device name to bind the controller and the phy can no longer be used reliably. I think it's better to have something like what Grant suggested in my other patch series.. to have the phy reference into the host controllers platform_data structure. And for the phy reference I'll have label and id. Does this makes sense to you? Thanks Kishon