From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jan Beulich" Subject: Re: [PATCH 11/20] PVH xen: introduce pvh.c Date: Tue, 21 May 2013 08:07:16 +0100 Message-ID: <519B394402000078000D77D3@nat28.tlf.novell.com> References: <1368579168-30829-1-git-send-email-mukesh.rathor@oracle.com> <1368579168-30829-12-git-send-email-mukesh.rathor@oracle.com> <519382BA02000078000D6658@nat28.tlf.novell.com> <20130515184207.0f50b06d@mantra.us.oracle.com> <5194AE4C02000078000D6A2D@nat28.tlf.novell.com> <20130516172721.74867731@mantra.us.oracle.com> <5195EDA702000078000D6E88@nat28.tlf.novell.com> <20130520170806.7a96a8d8@mantra.us.oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20130520170806.7a96a8d8@mantra.us.oracle.com> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Mukesh Rathor Cc: xen-devel List-Id: xen-devel@lists.xenproject.org >>> On 21.05.13 at 02:08, Mukesh Rathor wrote: > On Fri, 17 May 2013 07:43:19 +0100 > "Jan Beulich" wrote: > >> >>> On 17.05.13 at 02:27, Mukesh Rathor >> >>> wrote: >> > On Thu, 16 May 2013 09:00:44 +0100 >> > "Jan Beulich" wrote: >> > >> >> >>> On 16.05.13 at 03:42, Mukesh Rathor >> >> >>> wrote: > .... >> > My understanding with previous maintainers was, establish a >> > baseline with something working, then keep adding bells and >> > whistles to it. This is an effort to that end. I am also OK >> > dropping the ball on pvh and let someones else who can finish it >> > all in one shot do it. >> >> And I already indicated various places where I'm fine with such >> compromises. But this one - with the code already working for PV >> and HVM guests - I simply expect would work without you doing >> _anything_ (or if not, it must be something really simple that needs >> adjustment). > > Actually, now that pvh.c has shrunk a lot, and code is very similar > to hvm.c, are you OK if I just add some code to hvm.c and get rid of > pvh.c? Sure. Jan