From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Jan Beulich" <JBeulich@suse.com>
Subject: Re: New Xen boot infrastructure proposal
Date: Tue, 21 May 2013 13:03:48 +0100
Message-ID: <519B7EC402000078000D7B3C@nat28.tlf.novell.com>
References: <363082f7-72f9-41cc-a5b4-75ce235e6493@default>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <363082f7-72f9-41cc-a5b4-75ce235e6493@default>
Content-Disposition: inline
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Daniel Kiper <daniel.kiper@oracle.com>
Cc: xen-devel <xen-devel@lists.xen.org>, keir@xen.org, ian.campbell@citrix.com, konrad.wilk@oracle.com, stefano.stabellini@eu.citrix.com
List-Id: xen-devel@lists.xenproject.org

>>> On 21.05.13 at 12:36, Daniel Kiper <daniel.kiper@oracle.com> wrote:
> /* Xen Boot Info Arch (XBIA) memory map structure. */
> typedef struct {
>   /*
>    * Amount of lower memory accordingly to The Multiboot
>    * Specification version 0.6.96.
>    */
>   u32 lower;
>   /*
>    * Amount of upper memory accordingly to The Multiboot
>    * Specification version 0.6.96.
>    */
>   u32 upper;
>   u32 map_size;
>   struct e820entry *e820map;
> } xbia_mem_t;

The concepts of lower, upper, and E820 memory are all very much
tied to x86.

> /* Xen Boot Info Arch (XBIA). */
> typedef struct {
>   EFI_SYSTEM_TABLE *efi_system_table;
>   u64 mps; /* Pointer to MPS. */
>   u64 acpi; /* Pointer to ACPI RSDP. */
>   u64 smbios; /* Pointer to SMBIOS. */
>   xbia_mem_t mem;
>   struct xen_vga_console_info vga_console_info;
>   struct edd_info *edd_info;
> } xbia_t;

As are - I think - MPS, EDD, perhaps SMBIOS, and maybe VGA.

If you want to design anything here (and other than you try to
suggest I don't think booting is really a process that can be made
almost arch neutral/generic), you'd need to completely separate
out any _potentially_ arch specific things, not just those that
today we know are specific to one arch or common between the
only two and a half we support. That may mean that _each_ of
the items above should become a separate one, in which case an
enumeration concept would likely be the better one.

Jan