From: Paolo Bonzini <pbonzini@redhat.com>
To: Stefan Priebe - Profihost AG <s.priebe@profihost.ag>
Cc: Josh Durgin <josh.durgin@inktank.com>,
Stefan Hajnoczi <stefanha@gmail.com>,
qemu-devel <qemu-devel@nongnu.org>,
"pve-devel@pve.proxmox.com" <pve-devel@pve.proxmox.com>,
Michael Roth <mdroth@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] segfault in aio_bh_poll async.c:80 WAS: Re: kvm process disappears
Date: Wed, 22 May 2013 10:41:15 +0200 [thread overview]
Message-ID: <519C84AB.6050203@redhat.com> (raw)
In-Reply-To: <6BCF67A6-A1D5-4B4D-B83D-DC32F7621C43@profihost.ag>
Il 22/05/2013 08:26, Stefan Priebe - Profihost AG ha scritto:
>> Hi,
>>
>> as i can't reproduce no ;-( i just saw the kernel segfault message and
>> used addr2line and a qemu dbg package to get the code line.
>
> I've now seen this again for two or three times. It always happens
> when we do an fstrim inside the guest.
> And I've seen this first since josh async rbd patch.
This one?
commit dc7588c1eb3008bda53dde1d6b890cd299758155
Author: Josh Durgin <josh.durgin@inktank.com>
Date: Fri Mar 29 13:03:23 2013 -0700
rbd: add an asynchronous flush
The existing bdrv_co_flush_to_disk implementation uses rbd_flush(),
which is sychronous and causes the main qemu thread to block until it
is complete. This results in unresponsiveness and extra latency for
the guest.
Fix this by using an asynchronous version of flush. This was added to
librbd with a special #define to indicate its presence, since it will
be backported to stable versions. Thus, there is no need to check the
version of librbd.
Implement this as bdrv_aio_flush, since it matches other aio functions
in the rbd block driver, and leave out bdrv_co_flush_to_disk when the
asynchronous version is available.
Reported-by: Oliver Francke <oliver@filoo.de>
Signed-off-by: Josh Durgin <josh.durgin@inktank.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Do you see it even with "-drive discard=off"?
Paolo
next prev parent reply other threads:[~2013-05-22 8:43 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-10 6:12 [Qemu-devel] kvm process disappears Stefan Priebe - Profihost AG
2013-05-10 7:15 ` [Qemu-devel] [pve-devel] " Alexandre DERUMIER
2013-05-10 7:20 ` Alexandre DERUMIER
2013-05-10 7:22 ` Stefan Priebe - Profihost AG
2013-05-10 7:28 ` Alexandre DERUMIER
2013-05-10 9:06 ` Stefan Priebe - Profihost AG
2013-05-10 7:42 ` [Qemu-devel] " Stefan Hajnoczi
2013-05-10 9:07 ` Stefan Priebe - Profihost AG
2013-05-10 11:09 ` Stefan Hajnoczi
2013-05-14 14:29 ` [Qemu-devel] segfault in aio_bh_poll async.c:80 WAS: " Stefan Priebe - Profihost AG
2013-05-14 15:05 ` Stefan Hajnoczi
2013-05-14 15:11 ` Stefan Priebe - Profihost AG
2013-05-22 6:26 ` Stefan Priebe - Profihost AG
2013-05-22 8:41 ` Paolo Bonzini [this message]
2013-05-22 12:24 ` Stefan Priebe - Profihost AG
2013-05-23 10:09 ` Paolo Bonzini
2013-05-23 19:22 ` Stefan Priebe
2013-05-27 21:09 ` [Qemu-devel] " Stefan Priebe
2013-05-28 8:06 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=519C84AB.6050203@redhat.com \
--to=pbonzini@redhat.com \
--cc=josh.durgin@inktank.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=pve-devel@pve.proxmox.com \
--cc=qemu-devel@nongnu.org \
--cc=s.priebe@profihost.ag \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.