From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759470Ab3EWPHn (ORCPT ); Thu, 23 May 2013 11:07:43 -0400 Received: from terminus.zytor.com ([198.137.202.10]:54606 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759226Ab3EWPHe (ORCPT ); Thu, 23 May 2013 11:07:34 -0400 Message-ID: <519E3089.8040701@zytor.com> Date: Thu, 23 May 2013 08:06:49 -0700 From: "H. Peter Anvin" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 MIME-Version: 1.0 To: Steven Rostedt CC: Rik van Riel , Stanislav Meduna , Linus Torvalds , "linux-rt-users@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Thomas Gleixner , Ingo Molnar , the arch/x86 maintainers , Hai Huang Subject: Re: [PATCH] mm: fix up a spurious page fault whenever it happens References: <5195ED8B.7060002@meduna.org> <1369183168.6828.168.camel@gandalf.local.home> <519CBB30.3060200@redhat.com> <20130522134111.33a695c5@cuia.bos.redhat.com> <519D08B0.8050707@meduna.org> <1369246316.6828.176.camel@gandalf.local.home> <519D0CAB.7020800@meduna.org> <519D0FF8.5080200@redhat.com> <519D118B.6010306@zytor.com> <519D11BF.5000604@redhat.com> <519DCE2A.4010801@meduna.org> <519E095A.4000105@redhat.com> <1369315769.6828.198.camel@gandalf.local.home> In-Reply-To: <1369315769.6828.198.camel@gandalf.local.home> X-Enigmail-Version: 1.5.1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/23/2013 06:29 AM, Steven Rostedt wrote: > On Thu, 2013-05-23 at 08:19 -0400, Rik van Riel wrote: > >> We can add a bit in the architecture bits that >> we use to check against other CPU and system >> errata, and conditionally flush the whole TLB >> from __native_flush_tlb_single(). > > If we find that some CPUs have issues and others do not, and we can > determine this by checking the CPU type at run time, I would strongly > suggest using the jump_label infrastructure to do the branches. I know > this is early to suggest something like this, but I just wanted to put > it in your head ;-) > We don't even need the jump_label infrastructure -- we have static_cpu_has*() which actually predates jump_label although it uses the same underlying ideas. -hpa