From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751153AbdE2MIJ (ORCPT ); Mon, 29 May 2017 08:08:09 -0400 Received: from mx2.suse.de ([195.135.220.15]:46914 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750989AbdE2MIH (ORCPT ); Mon, 29 May 2017 08:08:07 -0400 Subject: Re: [PATCH 2/3] mm, memory_hotplug: drop CONFIG_MOVABLE_NODE To: Michal Hocko , Andrew Morton Cc: linux-mm@kvack.org, Mel Gorman , Andrea Arcangeli , Jerome Glisse , Reza Arbab , Yasuaki Ishimatsu , qiuxishi@huawei.com, Kani Toshimitsu , slaoub@gmail.com, Joonsoo Kim , Andi Kleen , David Rientjes , Daniel Kiper , Igor Mammedov , Vitaly Kuznetsov , LKML , Michal Hocko References: <20170529114141.536-1-mhocko@kernel.org> <20170529114141.536-3-mhocko@kernel.org> From: Vlastimil Babka Message-ID: <519c2906-d2f5-4069-2d6a-d7c199e5980b@suse.cz> Date: Mon, 29 May 2017 14:08:02 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <20170529114141.536-3-mhocko@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/29/2017 01:41 PM, Michal Hocko wrote: > From: Michal Hocko > > 20b2f52b73fe ("numa: add CONFIG_MOVABLE_NODE for movable-dedicated > node") has introduced CONFIG_MOVABLE_NODE without a good explanation on > why it is actually useful. It makes a lot of sense to make movable node > semantic opt in but we already have that because the feature has to be > explicitly enabled on the kernel command line. A config option on top > only makes the configuration space larger without a good reason. It also > adds an additional ifdefery that pollutes the code. Just drop the config > option and make it de-facto always enabled. This shouldn't introduce any > change to the semantic. > > Acked-by: Reza Arbab > Signed-off-by: Michal Hocko Acked-by: Vlastimil Babka From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f70.google.com (mail-wm0-f70.google.com [74.125.82.70]) by kanga.kvack.org (Postfix) with ESMTP id 192906B0292 for ; Mon, 29 May 2017 08:08:09 -0400 (EDT) Received: by mail-wm0-f70.google.com with SMTP id b84so13088187wmh.0 for ; Mon, 29 May 2017 05:08:09 -0700 (PDT) Received: from mx1.suse.de (mx2.suse.de. [195.135.220.15]) by mx.google.com with ESMTPS id j14si8692478ede.2.2017.05.29.05.08.06 for (version=TLS1 cipher=AES128-SHA bits=128/128); Mon, 29 May 2017 05:08:07 -0700 (PDT) Subject: Re: [PATCH 2/3] mm, memory_hotplug: drop CONFIG_MOVABLE_NODE References: <20170529114141.536-1-mhocko@kernel.org> <20170529114141.536-3-mhocko@kernel.org> From: Vlastimil Babka Message-ID: <519c2906-d2f5-4069-2d6a-d7c199e5980b@suse.cz> Date: Mon, 29 May 2017 14:08:02 +0200 MIME-Version: 1.0 In-Reply-To: <20170529114141.536-3-mhocko@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Michal Hocko , Andrew Morton Cc: linux-mm@kvack.org, Mel Gorman , Andrea Arcangeli , Jerome Glisse , Reza Arbab , Yasuaki Ishimatsu , qiuxishi@huawei.com, Kani Toshimitsu , slaoub@gmail.com, Joonsoo Kim , Andi Kleen , David Rientjes , Daniel Kiper , Igor Mammedov , Vitaly Kuznetsov , LKML , Michal Hocko On 05/29/2017 01:41 PM, Michal Hocko wrote: > From: Michal Hocko > > 20b2f52b73fe ("numa: add CONFIG_MOVABLE_NODE for movable-dedicated > node") has introduced CONFIG_MOVABLE_NODE without a good explanation on > why it is actually useful. It makes a lot of sense to make movable node > semantic opt in but we already have that because the feature has to be > explicitly enabled on the kernel command line. A config option on top > only makes the configuration space larger without a good reason. It also > adds an additional ifdefery that pollutes the code. Just drop the config > option and make it de-facto always enabled. This shouldn't introduce any > change to the semantic. > > Acked-by: Reza Arbab > Signed-off-by: Michal Hocko Acked-by: Vlastimil Babka -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org