From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:33664) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UgCgQ-0006nD-Fe for qemu-devel@nongnu.org; Sat, 25 May 2013 07:30:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UgCgM-0000lp-Ih for qemu-devel@nongnu.org; Sat, 25 May 2013 07:30:46 -0400 Received: from mout.web.de ([212.227.17.11]:61889) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UgCgM-0000lb-8u for qemu-devel@nongnu.org; Sat, 25 May 2013 07:30:42 -0400 Message-ID: <51A0A0D5.5000706@web.de> Date: Sat, 25 May 2013 13:30:29 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <1369133851-1894-1-git-send-email-pbonzini@redhat.com> <1369133851-1894-18-git-send-email-pbonzini@redhat.com> <51A05CDF.1090106@web.de> <51A06C9B.5060302@redhat.com> <51A09018.7000901@web.de> <51A09E6F.7030109@redhat.com> In-Reply-To: <51A09E6F.7030109@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="----enig2XPLOHOLRHWQGEPJXUHXX" Subject: Re: [Qemu-devel] [PATCH 17/30] memory: add address_space_translate List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org, David Gibson This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2XPLOHOLRHWQGEPJXUHXX Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable On 2013-05-25 13:20, Paolo Bonzini wrote: > Il 25/05/2013 12:19, Jan Kiszka ha scritto: >> addr -=3D section->offset_within_address_space; >> - len =3D MIN(section->size - addr, len); > ^^^^^^^^^^^^^ ^^^^ >=20 > This is the size of a section minus an offset in the section. >=20 >> + diff =3D int128_sub(section->mr->size, int128_make64(addr)); > ^^^^^^^^^^^^^^^^^ ^^^^ >=20 > This is the size of a region minus the same offset in the section. >=20 >> + len =3D MIN(int128_get64(diff), len); >> =20 >> /* Compute offset within MemoryRegion */ >> addr +=3D section->offset_within_region; >=20 > So this has to be moved above. Right, fixed. > Do you have a branch pushed somewhere > that I can test against? git://git.kiszka.org/qemu.git queues/ioport Jan ------enig2XPLOHOLRHWQGEPJXUHXX Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iEYEARECAAYFAlGgoNgACgkQitSsb3rl5xT/CwCfY9KY0N4DWkA2YC3PePwAgfBx ivwAniNJn/vFpecl82oLfk/Vga6d8owC =H66x -----END PGP SIGNATURE----- ------enig2XPLOHOLRHWQGEPJXUHXX--